Update to PPDB spec for change in embedded source blob format by nguerrera · Pull Request #10560 · dotnet/corefx (original) (raw)

Skip to content

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Sign in

Sign up

Appearance settings

This repository was archived by the owner on Jan 23, 2023. It is now read-only.

dotnet / corefx Public archive

Additional navigation options

Merged

nguerrera merged 1 commit intodotnet:masterfromnguerrera:compression-format-change

Aug 4, 2016

Merged

Update to PPDB spec for change in embedded source blob format #10560

nguerrera merged 1 commit intodotnet:masterfromnguerrera:compression-format-change

Aug 4, 2016

Conversation3 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

nguerrera

Copy link

Contributor

@nguerrera nguerrera commented

Aug 4, 2016

@tmat

@dnfclas dnfclas added the cla-already-signed label

Aug 4, 2016

@dotnet-bot dotnet-bot added the 3 - Ready For Review label

Aug 4, 2016

@nguerrera nguerrera mentioned this pull request

Aug 4, 2016

Proposal: Embed sources in PDBsdotnet/roslyn#12625

Closed

3 tasks

tmat

tmat reviewed

Aug 4, 2016

View reviewed changes

src/System.Reflection.Metadata/specs/PortablePdb-Metadata.md

| @@ -514,8 +514,8 @@ The blob has the following structure: | | | | | --------------------------------------------------------- | --------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | | | | | | | | terminal | encoding | description | | | |:----------|:-----------------|:-------------| | | | | | | _format_ | uint16 | Indicates how the content is serialized. 0 = raw bytes, uncompressed. 1 = compressed in GZIP format. Other values reserved for future formats. | | | | _content_ | format-specific | The text of the document in the specified format. The length is implied by the length of the blob minus two bytes for the format. | | | | _format_ | int32 | Indicates how the content is serialized. 0 = raw bytes, uncompressed. Positve value = compressed by deflate algorithm and value indicates uncompressed size. Negative values reserved for future formats. | |

Copy link

Member

@tmat tmat

Aug 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo:

Positve

Copy link

Contributor Author

@nguerrera nguerrera

Aug 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Anything else?

@nguerrera

[Update to PPDB spec for change in embedded source blob format](/dotnet/corefx/pull/10560/commits/8415c4da2a984b6f6ea4c03036909eef2ac46672 "Update to PPDB spec for change in embedded source blob format")

[8415c4d](/dotnet/corefx/pull/10560/commits/8415c4da2a984b6f6ea4c03036909eef2ac46672)

@nguerrera nguerrera force-pushed the compression-format-change branch from5efbe86 to8415c4d Compare

August 4, 2016 02:54

@tmat

Copy link

Member

tmat commented

Aug 4, 2016

👍

@nguerrera nguerrera merged commit f6baef1 into dotnet:master

Aug 4, 2016

@nguerrera nguerrera deleted the compression-format-change branch

August 4, 2016 04:03

@dotnet-bot dotnet-bot removed the 3 - Ready For Review label

Aug 4, 2016

@karelz karelz modified the milestone:1.1.0

Dec 3, 2016

Sign up for free to subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

@nguerrera @tmat @karelz @dotnet-bot @dnfclas