Don't capture the ExecutionContext when registering for the cancellation by davidfowl · Pull Request #33235 · dotnet/corefx (original) (raw)

Appearance settings

By company size
- Enterprises
- Small and medium teams
- Startups
- Nonprofits
  By use case
- DevSecOps
- DevOps
- CI/CD
- View all use cases
  By industry
- Healthcare
- Financial services
- Manufacturing
- Government
- View all industries
  View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
  Explore
- Learning Pathways
- Events & Webinars
- Ebooks & Whitepapers
- Customer Stories
- Partners
- Executive Insights
- GitHub Sponsors Fund open source developers
- The ReadME Project GitHub community articles
  Repositories
- Topics
- Trending
- Collections
Pricing

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

This repository was archived by the owner on Jan 23, 2023. It is now read-only.

dotnet / corefx Public archive

Notifications You must be signed in to change notification settings
Fork4.9k
Star 17.6k
Code
Pull requests
Security
Insights

Additional navigation options

Merged

davidfowl merged 1 commit intomasterfromdavidfowl/unsafe-register

Nov 6, 2018

Merged

Don't capture the ExecutionContext when registering for the cancellation #33235

davidfowl merged 1 commit intomasterfromdavidfowl/unsafe-register

Nov 6, 2018

Conversation9 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Copy link

Member

@davidfowl davidfowl commented

Nov 4, 2018

Don't capture the ExecutionContext when registering for cancellation since we're invoking our own callback.

[Don't capture the execution context when registering for the cancalla…](/dotnet/corefx/pull/33235/commits/6904688e295ae511b059a169901f858eb110d9c9 "Don't capture the execution context when registering for the cancallation token on .NET Core.")

[6904688](/dotnet/corefx/pull/33235/commits/6904688e295ae511b059a169901f858eb110d9c9)

…tion token on .NET Core.

davidfowl requested a review from pakrym

November 4, 2018 17:24

davidfowl commented Nov 4, 2018

View reviewed changes

src/System.IO.Pipelines/src/Configurations.props

@@ -3,7 +3,7 @@


netstandard;
netcoreapp2.1;
netcoreapp;

Copy link

Member Author

@davidfowl davidfowl

Nov 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also drops 2.1 support, I can bring it back if that matters. The only difference is the allocation profile for the ThreadPoolScheduler.

stephentoub approved these changes Nov 4, 2018

View reviewed changes

Copy link

Member Author

davidfowl commented

Nov 5, 2018

The windows build hung for 7 hours 😄

Copy link

Member Author

davidfowl commented

Nov 5, 2018

@dotnet-bot test Windows x86 Release Build
@dotnet-bot test Windows x64 Debug Build

Copy link

Member Author

davidfowl commented

Nov 5, 2018

@dotnet-bot test Linux x64 Release Build

Copy link

Member Author

davidfowl commented

Nov 5, 2018

I assume windows is just dead.

Copy link

Member

stephentoub commented

Nov 5, 2018

I assume windows is just dead.

The Windows 7 VMs have been having trouble all weekend.
@dotnet/dnceng

Copy link

Member

MattGal commented

Nov 5, 2018

@stephentoub I am taking corrective action presently, my apologies for the inconvenience. Root cause analysis and fix status will be in https://github.com/dotnet/core-eng/issues/4551

Copy link

Member

MattGal commented

Nov 5, 2018

Windows 7 processing has caught up to real time now. We'll continue to track this issue until we find and fix the underlying cause.

Copy link

Member

stephentoub commented

Nov 5, 2018

@dotnet-bot test this please

davidfowl merged commit 4e6418b into master

Nov 6, 2018

weshaggard deleted the davidfowl/unsafe-register branch

November 6, 2018 01:57

karelz added this to the 3.0 milestone

Nov 15, 2018

picenka21 pushed a commit to picenka21/runtime that referenced this pull request

Feb 18, 2022

`[Don't capture the execution context when registering for the cancalla…](/picenka21/runtime/commit/fc7aadabe80e2753f1b1308808610d26e031979e "Don't capture the execution context when registering for the cancallation token on .NET Core. (dotnet/corefx#33235)

Commit migrated from https://github.com/dotnet/corefx/commit/4e6418b59af4c97d5596d21df09d08071275ae27") `

[fc7aada](/picenka21/runtime/commit/fc7aadabe80e2753f1b1308808610d26e031979e)

…tion token on .NET Core. (dotnet/corefx#33235)

Commit migrated from dotnet/corefx@4e6418b

Reviewers

stephentoub stephentoub approved these changes