Add CI test for eboot build by earlephilhower · Pull Request #7546 · esp8266/Arduino (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation1 Commits5 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

earlephilhower

Check that building the eboot.c block generates the same binary as
the verison checked into the repo. Catches the case where a library
or eboot.c file is changed, but an updated eboot.elf isn't included
in a PR.

Can't do simple binary diff of the ELFs because paths and compile
times will change, so dump the two sections we care about.

@earlephilhower

Check that building the eboot.c block generates the same binary as the verison checked into the repo. Catches the case where a library or eboot.c file is changed, but an updated eboot.elf isn't included in a PR.

Can't do simple binary diff of the ELFs because paths and compile times will change, so dump the two sections we care about.

@earlephilhower

Test that CI fails when eboot.c is changed w/o an updated eboot.elf.

@earlephilhower

Verified CI fail when eboot.c changed w/o corresponding eboot.elf update.

davisonja added a commit to davisonja/Arduino that referenced this pull request

Sep 10, 2020

@davisonja

1 participant

@earlephilhower