Add VM pause support by hyuan3 · Pull Request #239 · intel/haxm (original) (raw)

Skip to content

Sign in

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Sign in

Sign up

This repository was archived by the owner on Jan 28, 2023. It is now read-only.

intel / haxm Public archive

Additional navigation options

Merged

wcwang merged 1 commit intointel:masterfromhyuan3:work

Sep 25, 2019

Merged

Add VM pause support #239

wcwang merged 1 commit intointel:masterfromhyuan3:work

Sep 25, 2019

Conversation1 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

hyuan3

Copy link

Contributor

@hyuan3 hyuan3 commented

Sep 24, 2019

Check if Qemu wants to pause VM. If yes, don't enter guest. This is
helpful in snapshot scenario that Qemu can tell HAXM to pause after
it finishes last guest IO/MMIO instruction.

Signed-off-by: Hang Yuan hang.yuan@intel.com

@HaxmCI HaxmCI added CI:Build Pass

CI:Build Pass

CI:Mac Test Pass

CI:Mac Test Pass

labels

Sep 24, 2019

krytarowski

krytarowski reviewed Sep 24, 2019

View reviewed changes

core/vcpu.c Outdated

goto out;
}
err = cpu_vmx_execute(vcpu, htun);

Copy link

Contributor

@krytarowski krytarowski

Sep 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace issue.

@hyuan3 hyuan3 force-pushed the work branch from9c1b641 todca031c Compare

September 25, 2019 06:36

wcwang

wcwang approved these changes Sep 25, 2019

View reviewed changes

@wcwang wcwang merged commit 633e744 into intel:master

Sep 25, 2019

@hyuan3

`[Add VM pause support](/intel/haxm/pull/239/commits/dca031c05ce18d5423908613106dedd84f6f8e23 "Add VM pause support

Check if Qemu wants to pause VM. If yes, don't enter guest. This is used in snapshot scenario that Qemu pauses VM and tell HAXM not to enter guest after it finishes the last guest IO/MMIO instruction.

Signed-off-by: Hang Yuan hang.yuan@intel.com") `

[dca031c](/intel/haxm/pull/239/commits/dca031c05ce18d5423908613106dedd84f6f8e23)

Check if Qemu wants to pause VM. If yes, don't enter guest. This is used in snapshot scenario that Qemu pauses VM and tell HAXM not to enter guest after it finishes the last guest IO/MMIO instruction.

Signed-off-by: Hang Yuan hang.yuan@intel.com

Sign up for free to subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@krytarowski krytarowski krytarowski left review comments

@wcwang wcwang wcwang approved these changes

Assignees

No one assigned

Labels

CI:Build Pass

CI:Build Pass

CI:Mac Test Pass

CI:Mac Test Pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hyuan3 @wcwang @krytarowski @HaxmCI