[hexagon] Enable --eh-frame-hdr (#130225) · llvm/llvm-project@6657769 (original) (raw)
Navigation Menu
- GitHub Copilot Write better code with AI
- GitHub Models New Manage and compare prompts
- GitHub Advanced Security Find and fix vulnerabilities
- Actions Automate any workflow
- Codespaces Instant dev environments
- Issues Plan and track work
- Code Review Manage code changes
- Discussions Collaborate outside of code
- Code Search Find more, search less
- Explore
- Pricing
Provide feedback
Saved searches
Use saved searches to filter your results more quickly
Appearance settings
Commit 6657769
[hexagon] Enable --eh-frame-hdr (#130225)
The missing `PT_GNU_EH_FRAME` was causing C++ exception handling test failures in llvm-test-suite. We should unconditionally add this argument like the other drivers do. Discovered-by: Alexey Karyakin akaryaki@quicinc.com Fixes: #129745
File tree
3 files changed
lines changed
3 files changed
lines changed
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -313,6 +313,7 @@ constructHexagonLinkArgs(Compilation &C, const JobAction &JA, | ||
| 313 | 313 | // handled somewhere else. |
| 314 | 314 | Args.ClaimAllArgs(options::OPT_static_libgcc); |
| 315 | 315 | |
| 316 | + CmdArgs.push_back("--eh-frame-hdr"); | |
| 316 | 317 | //---------------------------------------------------------------------------- |
| 317 | 318 | // |
| 318 | 319 | //---------------------------------------------------------------------------- |
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -555,6 +555,7 @@ | ||
| 555 | 555 | // RUN: -ccc-install-dir %S/Inputs/hexagon_tree/Tools/bin \ |
| 556 | 556 | // RUN: -mcpu=hexagonv60 \ |
| 557 | 557 | // RUN: -fuse-ld=lld %s 2>&1 | FileCheck -check-prefix=CHECK382 %s |
| 558 | +// CHECK382: "--eh-frame-hdr | |
| 558 | 559 | // CHECK382-NOT: "-march= |
| 559 | 560 | // CHECK382-NOT: "-mcpu= |
| 560 | 561 | // ----------------------------------------------------------------------------- |
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -127,6 +127,7 @@ | ||
| 127 | 127 | // RUN: --target=hexagon-unknown-linux-musl %s -### 2>&1 \ |
| 128 | 128 | // RUN: | FileCheck -check-prefix=CHECK011 %s |
| 129 | 129 | // CHECK011: InstalledDir: [[INSTALLED_DIR:.+]] |
| 130 | +// CHECK011: "--eh-frame-hdr" | |
| 130 | 131 | // CHECK011: crt1.o |
| 131 | 132 | // CHECK011-NOT: "-lunwind" |
| 132 | 133 | // CHECK011-NOT: "-lgcc_eh" |