stream: remove dead code · nodejs/node@1a67c99 (original) (raw)

Skip to content

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Commit 1a67c99

marcosc90BridgeAR

authored and

committed

stream: remove dead code

Remove unreachable code. `state.ended` is always set to true in this part of the code. The `else` clause can't be executed. PR-URL: #27125Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Yongsheng Zhang zyszys98@gmail.com Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Tobias Nießen tniessen@tnie.de

File tree

1 file changed

lines changed

1 file changed

lines changed

Original file line number Diff line number Diff line change
@@ -521,11 +521,7 @@ function onEofChunk(stream, state) {
521 521 state.emittedReadable = true;
522 522 // We have to emit readable now that we are EOF. Modules
523 523 // in the ecosystem (e.g. dicer) rely on this event being sync.
524 -if (state.ended) {
525 -emitReadable_(stream);
526 -} else {
527 -process.nextTick(emitReadable_, stream);
528 -}
524 +emitReadable_(stream);
529 525 }
530 526 }
531 527