test: move known issue test to parallel · nodejs/node@b368571 (original) (raw)

Skip to content

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Commit b368571

test: move known issue test to parallel

As of libuv 1.28.0, this bug is fixed, and the test can be moved to parallel. This commit also updates an error code check to work on Windows. PR-URL: #27241Reviewed-By: Richard Lau riclau@uk.ibm.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Rich Trott rtrott@gmail.com Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Ben Noordhuis info@bnoordhuis.nl

File tree

1 file changed

lines changed

1 file changed

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number Diff line number Diff line change
@@ -23,7 +23,8 @@ function beforeEach() {
23 23 fs.chmodSync(dest, '444');
24 24
25 25 const check = (err) => {
26 -assert.strictEqual(err.code, 'EACCES');
26 +const expected = ['EACCES', 'EPERM'];
27 +assert(expected.includes(err.code), `${err.code} not in ${expected}`);
27 28 assert.strictEqual(fs.readFileSync(dest, 'utf8'), 'dest');
28 29 return true;
29 30 };