tty: add hasColors function by BridgeAR · Pull Request #26247 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation12 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

This adds a small wrapper around the getColorDepth function to check
if the stream supports at least a specific amount of colors. This is
convenient as the other API is not as straight forward and most use
cases likely only want to know if a specific amount of colors is
supported or not.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

addaleax added the semver-minor

PRs that contain new features and should be released in the next minor version.

label

Feb 21, 2019

BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Feb 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit... it's not clear from the documentation how the env bit works here. Perhaps an example?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two examples below but I'll try to improve the wording further.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

This adds a small wrapper around the getColorDepth function to check if the stream supports at least a specific amount of colors. This is convenient as the other API is not as straight forward and most use cases likely only want to know if a specific amount of colors is supported or not.

BridgeAR added a commit to BridgeAR/node that referenced this pull request

Mar 5, 2019

This adds a small wrapper around the getColorDepth function to check if the stream supports at least a specific amount of colors. This is convenient as the other API is not as straight forward and most use cases likely only want to know if a specific amount of colors is supported or not.

PR-URL: nodejs#26247 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Weijia Wang starkwang@126.com Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Sakthipriyan Vairamani thechargingvolcano@gmail.com

targos pushed a commit to targos/node that referenced this pull request

Mar 27, 2019

This adds a small wrapper around the getColorDepth function to check if the stream supports at least a specific amount of colors. This is convenient as the other API is not as straight forward and most use cases likely only want to know if a specific amount of colors is supported or not.

PR-URL: nodejs#26247 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Weijia Wang starkwang@126.com Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Sakthipriyan Vairamani thechargingvolcano@gmail.com

targos added a commit that referenced this pull request

Mar 27, 2019

Notable changes:

• events:
  • Added a once function to use EventEmitter with promises (#26078).
• tty:
  • Added a hasColors method to WriteStream (#26247).
  • Added NO_COLOR and FORCE_COLOR support (#26485).
• v8:
  • Added v8.getHeapSnapshot and v8.writeHeapSnapshot to generate snapshots in the format used by tools such as Chrome DevTools (#26501).
• meta:
  • Gireesh Punathil is now a member of the Technical Steering Committee (#26657).
  • Added ZYSzys to collaborators (#26730).

PR-URL: #26949

targos added a commit that referenced this pull request

Mar 28, 2019

Notable changes:

• crypto
  • Allow deriving public from private keys (Tobias Nießen) #26278.
• events
  • Added a once function to use EventEmitter with promises (Matteo Collina) #26078.
• tty
  • Added a hasColors method to WriteStream (Ruben Bridgewater) #26247.
  • Added NO_COLOR and FORCE_COLOR support (Ruben Bridgewater) #26485.
• v8
  • Added v8.getHeapSnapshot and v8.writeHeapSnapshot to generate snapshots in the format used by tools such as Chrome DevTools (James M Snell) #26501.
• worker
  • Added worker.moveMessagePortToContext. This enables using MessagePorts in different vm.Contexts, aiding with the isolation that the vm module seeks to provide (Anna Henningsen) #26497.
• C++ API
  • AddPromiseHook is now deprecated. This API was added to fill an use case that is served by async_hooks, since that has Promise support (Anna Henningsen) #26529.
  • Added a Stop API to shut down Node.js while it is running (Gireesh Punathil) #21283.
• meta
  • Gireesh Punathil is now a member of the Technical Steering Committee #26657.
  • Added Yongsheng Zhang to collaborators #26730.

PR-URL: #26949

targos added a commit that referenced this pull request

Mar 28, 2019

Notable changes:

• crypto
  • Allow deriving public from private keys (Tobias Nießen) #26278.
• events
  • Added a once function to use EventEmitter with promises (Matteo Collina) #26078.
• tty
  • Added a hasColors method to WriteStream (Ruben Bridgewater) #26247.
  • Added NO_COLOR and FORCE_COLOR support (Ruben Bridgewater) #26485.
• v8
  • Added v8.getHeapSnapshot and v8.writeHeapSnapshot to generate snapshots in the format used by tools such as Chrome DevTools (James M Snell) #26501.
• worker
  • Added worker.moveMessagePortToContext. This enables using MessagePorts in different vm.Contexts, aiding with the isolation that the vm module seeks to provide (Anna Henningsen) #26497.
• C++ API
  • AddPromiseHook is now deprecated. This API was added to fill an use case that is served by async_hooks, since that has Promise support (Anna Henningsen) #26529.
  • Added a Stop API to shut down Node.js while it is running (Gireesh Punathil) #21283.
• meta
  • Gireesh Punathil is now a member of the Technical Steering Committee #26657.
  • Added Yongsheng Zhang to collaborators #26730.

PR-URL: #26949

BethGriggs pushed a commit that referenced this pull request

Apr 5, 2019

Notable changes:

• crypto
  • Allow deriving public from private keys (Tobias Nießen) #26278.
• events
  • Added a once function to use EventEmitter with promises (Matteo Collina) #26078.
• tty
  • Added a hasColors method to WriteStream (Ruben Bridgewater) #26247.
  • Added NO_COLOR and FORCE_COLOR support (Ruben Bridgewater) #26485.
• v8
  • Added v8.getHeapSnapshot and v8.writeHeapSnapshot to generate snapshots in the format used by tools such as Chrome DevTools (James M Snell) #26501.
• worker
  • Added worker.moveMessagePortToContext. This enables using MessagePorts in different vm.Contexts, aiding with the isolation that the vm module seeks to provide (Anna Henningsen) #26497.
• C++ API
  • AddPromiseHook is now deprecated. This API was added to fill an use case that is served by async_hooks, since that has Promise support (Anna Henningsen) #26529.
  • Added a Stop API to shut down Node.js while it is running (Gireesh Punathil) #21283.
• meta
  • Gireesh Punathil is now a member of the Technical Steering Committee #26657.
  • Added Yongsheng Zhang to collaborators #26730.

PR-URL: #26949

BethGriggs pushed a commit that referenced this pull request

Apr 16, 2019

This adds a small wrapper around the getColorDepth function to check if the stream supports at least a specific amount of colors. This is convenient as the other API is not as straight forward and most use cases likely only want to know if a specific amount of colors is supported or not.

PR-URL: #26247 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Weijia Wang starkwang@126.com Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Sakthipriyan Vairamani thechargingvolcano@gmail.com

This was referenced

May 29, 2019

Qix- mentioned this pull request

Jul 12, 2019

Labels

author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

semver-minor

PRs that contain new features and should be released in the next minor version.

tty

Issues and PRs related to the tty subsystem.