crypto: allow deriving public from private keys by tniessen · Pull Request #26278 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation13 Commits2 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

This change allows passing private key objects to crypto.createPublicKey(), resulting in a KeyObject that represents a valid public key for the given private key. The returned public KeyObject can be used and exported safely without revealing information about the private key.

cc @sam-github, we talked about this in person and via Hangouts.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

This change allows passing private key objects to crypto.createPublicKey, resulting in a key object that represents a valid public key for the given private key. The returned public key object can be used and exported safely without revealing information about the private key.

nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

crypto

Issues and PRs related to the crypto subsystem.

labels

Feb 23, 2019

tniessen added the semver-minor

PRs that contain new features and should be released in the next minor version.

label

Feb 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some minor comments, address as you see fit.

tniessen added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Mar 4, 2019

Co-Authored-By: tniessen tniessen@users.noreply.github.com

tniessen added a commit that referenced this pull request

Mar 5, 2019

This change allows passing private key objects to crypto.createPublicKey, resulting in a key object that represents a valid public key for the given private key. The returned public key object can be used and exported safely without revealing information about the private key.

PR-URL: #26278 Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Ben Noordhuis info@bnoordhuis.nl Reviewed-By: Sam Roberts vieuxtech@gmail.com

targos pushed a commit to targos/node that referenced this pull request

Mar 27, 2019

This change allows passing private key objects to crypto.createPublicKey, resulting in a key object that represents a valid public key for the given private key. The returned public key object can be used and exported safely without revealing information about the private key.

Backport-PR-URL: nodejs#26688 PR-URL: nodejs#26278 Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Ben Noordhuis info@bnoordhuis.nl Reviewed-By: Sam Roberts vieuxtech@gmail.com

targos pushed a commit that referenced this pull request

Mar 27, 2019

This change allows passing private key objects to crypto.createPublicKey, resulting in a key object that represents a valid public key for the given private key. The returned public key object can be used and exported safely without revealing information about the private key.

Backport-PR-URL: #26688 PR-URL: #26278 Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Ben Noordhuis info@bnoordhuis.nl Reviewed-By: Sam Roberts vieuxtech@gmail.com

targos added a commit that referenced this pull request

Mar 28, 2019

Notable changes:

• crypto
  • Allow deriving public from private keys (Tobias Nießen) #26278.
• events
  • Added a once function to use EventEmitter with promises (Matteo Collina) #26078.
• tty
  • Added a hasColors method to WriteStream (Ruben Bridgewater) #26247.
  • Added NO_COLOR and FORCE_COLOR support (Ruben Bridgewater) #26485.
• v8
  • Added v8.getHeapSnapshot and v8.writeHeapSnapshot to generate snapshots in the format used by tools such as Chrome DevTools (James M Snell) #26501.
• worker
  • Added worker.moveMessagePortToContext. This enables using MessagePorts in different vm.Contexts, aiding with the isolation that the vm module seeks to provide (Anna Henningsen) #26497.
• C++ API
  • AddPromiseHook is now deprecated. This API was added to fill an use case that is served by async_hooks, since that has Promise support (Anna Henningsen) #26529.
  • Added a Stop API to shut down Node.js while it is running (Gireesh Punathil) #21283.
• meta
  • Gireesh Punathil is now a member of the Technical Steering Committee #26657.
  • Added Yongsheng Zhang to collaborators #26730.

PR-URL: #26949

targos added a commit that referenced this pull request

Mar 28, 2019

Notable changes:

• crypto
  • Allow deriving public from private keys (Tobias Nießen) #26278.
• events
  • Added a once function to use EventEmitter with promises (Matteo Collina) #26078.
• tty
  • Added a hasColors method to WriteStream (Ruben Bridgewater) #26247.
  • Added NO_COLOR and FORCE_COLOR support (Ruben Bridgewater) #26485.
• v8
  • Added v8.getHeapSnapshot and v8.writeHeapSnapshot to generate snapshots in the format used by tools such as Chrome DevTools (James M Snell) #26501.
• worker
  • Added worker.moveMessagePortToContext. This enables using MessagePorts in different vm.Contexts, aiding with the isolation that the vm module seeks to provide (Anna Henningsen) #26497.
• C++ API
  • AddPromiseHook is now deprecated. This API was added to fill an use case that is served by async_hooks, since that has Promise support (Anna Henningsen) #26529.
  • Added a Stop API to shut down Node.js while it is running (Gireesh Punathil) #21283.
• meta
  • Gireesh Punathil is now a member of the Technical Steering Committee #26657.
  • Added Yongsheng Zhang to collaborators #26730.

PR-URL: #26949

BethGriggs pushed a commit that referenced this pull request

Apr 5, 2019

Notable changes:

• crypto
  • Allow deriving public from private keys (Tobias Nießen) #26278.
• events
  • Added a once function to use EventEmitter with promises (Matteo Collina) #26078.
• tty
  • Added a hasColors method to WriteStream (Ruben Bridgewater) #26247.
  • Added NO_COLOR and FORCE_COLOR support (Ruben Bridgewater) #26485.
• v8
  • Added v8.getHeapSnapshot and v8.writeHeapSnapshot to generate snapshots in the format used by tools such as Chrome DevTools (James M Snell) #26501.
• worker
  • Added worker.moveMessagePortToContext. This enables using MessagePorts in different vm.Contexts, aiding with the isolation that the vm module seeks to provide (Anna Henningsen) #26497.
• C++ API
  • AddPromiseHook is now deprecated. This API was added to fill an use case that is served by async_hooks, since that has Promise support (Anna Henningsen) #26529.
  • Added a Stop API to shut down Node.js while it is running (Gireesh Punathil) #21283.
• meta
  • Gireesh Punathil is now a member of the Technical Steering Committee #26657.
  • Added Yongsheng Zhang to collaborators #26730.

PR-URL: #26949

tniessen removed the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Jan 14, 2021

abhishekumar-tyagi pushed a commit to abhishekumar-tyagi/node that referenced this pull request

May 5, 2024

This change allows passing private key objects to crypto.createPublicKey, resulting in a key object that represents a valid public key for the given private key. The returned public key object can be used and exported safely without revealing information about the private key.

PR-URL: nodejs/node#26278 Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Ben Noordhuis info@bnoordhuis.nl Reviewed-By: Sam Roberts vieuxtech@gmail.com

Reviewers

panva panva left review comments

BridgeAR BridgeAR left review comments

sam-github sam-github approved these changes

bnoordhuis bnoordhuis approved these changes

jasnell jasnell approved these changes

Labels

c++

Issues and PRs that require attention from people who are familiar with C++.

crypto

Issues and PRs related to the crypto subsystem.

semver-minor

PRs that contain new features and should be released in the next minor version.