chore(core): define kEnumerableProperty atomically by aduh95 · Pull Request #5332 · nodejs/undici (original) (raw)
Conversation
This relates to...
Rationale
We have a lint rule to enforce use __proto__: over Object.create, I think the rationale is that the engine has less work to do to optimize it
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status
- I have read and agreed to the Developer's Certificate of Origin
- Tested
- Benchmarked (optional)
- Documented
- Review ready
- In review
- Merge ready
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.21%. Comparing base (99912e8) to head (124c125).
⚠️ Report is 2 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@ ## main #5332 +/- ##
Coverage 93.21% 93.21%
Files 110 110
Lines 36598 36600 +2
- Hits 34116 34118 +2
Misses 2482 2482
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
ronag added a commit to nxtedition/undici that referenced this pull request
Downstreamed from nodejs#5332.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})