bpo-35499: make profile-opt don't override CFLAGS_NODIST by vstinner · Pull Request #11164 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation8 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

"make profile-opt" no longer replaces CFLAGS_NODIST with CFLAGS. It
now adds profile-guided optimization (PGO) flags to CFLAGS_NODIST,
existing CFLAGS_NODIST flags are kept.

https://bugs.python.org/issue35499

"make profile-opt" no longer replaces CFLAGS_NODIST with CFLAGS. It now adds profile-guided optimization (PGO) flags to CFLAGS_NODIST, existing CFLAGS_NODIST flags are kept.

It looks good in principle but I won't be able to test until next week.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense.

Thanks for the review! I wasn't confident with this change.

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Dec 16, 2018

)

"make profile-opt" no longer replaces CFLAGS_NODIST with CFLAGS. It now adds profile-guided optimization (PGO) flags to CFLAGS_NODIST, existing CFLAGS_NODIST flags are kept. (cherry picked from commit 640ed52)

Co-authored-by: Victor Stinner vstinner@redhat.com

vstinner added a commit that referenced this pull request

Dec 16, 2018

…H-11179)

Co-authored-by: Victor Stinner vstinner@redhat.com

Any chance for a 3.6 backport?

This was referenced

Dec 17, 2018

ned-deily pushed a commit that referenced this pull request

Dec 20, 2018

…H-11267)

"make profile-opt" no longer replaces CFLAGS_NODIST with CFLAGS. It now adds profile-guided optimization (PGO) flags to CFLAGS_NODIST, existing CFLAGS_NODIST flags are kept.

(cherry picked from commit 640ed52)

ned-deily pushed a commit to ned-deily/cpython that referenced this pull request

Dec 23, 2018

) (pythonGH-11179)

Co-authored-by: Victor Stinner vstinner@redhat.com