[3.7] bpo-35499: make profile-opt don't override CFLAGS_NODIST (GH-11164) by miss-islington · Pull Request #11179 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation5 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
"make profile-opt" no longer replaces CFLAGS_NODIST with CFLAGS. It now adds profile-guided optimization (PGO) flags to CFLAGS_NODIST, existing CFLAGS_NODIST flags are kept. (cherry picked from commit 640ed52)
Co-authored-by: Victor Stinner vstinner@redhat.com
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good bot.
@vstinner: Status check is done, and it's a success ✅ .
Sorry, I can't merge this PR. Reason: `Invalid request.
For 'properties/commit_message', ["bpo-35499: make profile-opt don't override CFLAGS_NODIST (GH-11164)", "", ""make profile-opt" no longer replaces CFLAGS_NODIST with CFLAGS. It", "now adds profile-guided optimization (PGO) flags to CFLAGS_NODIST,", "existing CFLAGS_NODIST flags are kept.", "(cherry picked from commit 640ed52)", "", "Co-authored-by: Victor Stinner vstinner@redhat.com"] is not a string.`.
@vstinner: Status check is done, and it's a success ✅ .
Sorry, I can't merge this PR. Reason: `Invalid request.
For 'properties/commit_message', ["bpo-35499: make profile-opt don't override CFLAGS_NODIST (GH-11164)", "", ""make profile-opt" no longer replaces CFLAGS_NODIST with CFLAGS. It", "now adds profile-guided optimization (PGO) flags to CFLAGS_NODIST,", "existing CFLAGS_NODIST flags are kept.", "(cherry picked from commit 640ed52)", "", "Co-authored-by: Victor Stinner vstinner@redhat.com"] is not a string.`.
ned-deily pushed a commit to ned-deily/cpython that referenced this pull request
) (pythonGH-11179)
"make profile-opt" no longer replaces CFLAGS_NODIST with CFLAGS. It now adds profile-guided optimization (PGO) flags to CFLAGS_NODIST, existing CFLAGS_NODIST flags are kept. (cherry picked from commit 640ed52)
Co-authored-by: Victor Stinner vstinner@redhat.com