bpo-36670: Enhance regrtest WindowsLoadTracker by vstinner · Pull Request #16553 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation2 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
The last line is now passed to the parser even if it does not end with a newline, but only if it's a valid value.
| @@ -14,7 +14,7 @@ |
|---|
| LOAD_FACTOR_1 = 0.9200444146293232478931553241 |
| # Seconds per measurement |
| SAMPLING_INTERVAL = 5 |
| SAMPLING_INTERVAL = 1 |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't taken a deeper look at the rest of the code but if the values are actually being sampled at a faster rate, the LOAD_FACTOR_1 constant needs to be updated. It assumes a sample rate of 1/s right now.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh. I didn't know that LOAD_FACTOR_1 value depends on SAMPLING_INTERVAL: I wrote PR #16555 to restore SAMPLING_INTERVAL=5.
vstinner added a commit that referenced this pull request
WindowsLoadTracker.read_output() now uses a short buffer for incomplete line.
(cherry picked from commit 3e04cd2)
The last line is now passed to the parser even if it does not end with a newline, but only if it's a valid value.
(cherry picked from commit c65119d)
Add log() method: add timestamp and load average prefixes to main messages.
WindowsLoadTracker:
- LOAD_FACTOR_1 is now computed using SAMPLING_INTERVAL
- Initialize the load to the arithmetic mean of the first 5 values of the Processor Queue Length value (so over 5 seconds), rather than 0.0.
- Handle BrokenPipeError and when typeperf exit.
format_duration(1.5) now returns '1.5 sec', rather than '1 sec 500 ms'
(cherry picked from commit 098e256)
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
…ythonGH-16550) (pythonGH-16560)
- bpo-36670, regrtest: Fix WindowsLoadTracker() for partial line (pythonGH-16550)
WindowsLoadTracker.read_output() now uses a short buffer for incomplete line.
(cherry picked from commit 3e04cd2)
- bpo-36670: Enhance regrtest WindowsLoadTracker (pythonGH-16553)
The last line is now passed to the parser even if it does not end with a newline, but only if it's a valid value.
(cherry picked from commit c65119d)
bpo-36670: Enhance regrtest (pythonGH-16556)
Add log() method: add timestamp and load average prefixes to main messages.
WindowsLoadTracker:
- LOAD_FACTOR_1 is now computed using SAMPLING_INTERVAL
- Initialize the load to the arithmetic mean of the first 5 values of the Processor Queue Length value (so over 5 seconds), rather than 0.0.
- Handle BrokenPipeError and when typeperf exit.
format_duration(1.5) now returns '1.5 sec', rather than '1 sec 500 ms'
(cherry picked from commit 098e256) (cherry picked from commit de3195c)
Co-authored-by: Victor Stinner vstinner@python.org
miss-islington added a commit that referenced this pull request
WindowsLoadTracker.read_output() now uses a short buffer for incomplete line.
(cherry picked from commit 3e04cd2)
The last line is now passed to the parser even if it does not end with a newline, but only if it's a valid value.
(cherry picked from commit c65119d)
Add log() method: add timestamp and load average prefixes to main messages.
WindowsLoadTracker:
- LOAD_FACTOR_1 is now computed using SAMPLING_INTERVAL
- Initialize the load to the arithmetic mean of the first 5 values of the Processor Queue Length value (so over 5 seconds), rather than 0.0.
- Handle BrokenPipeError and when typeperf exit.
format_duration(1.5) now returns '1.5 sec', rather than '1 sec 500 ms'
(cherry picked from commit 098e256) (cherry picked from commit de3195c)
Co-authored-by: Victor Stinner vstinner@python.org
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request
The last line is now passed to the parser even if it does not end with a newline, but only if it's a valid value.