[3.8] bpo-36670, regrtest: Fix WindowsLoadTracker() for partial line (GH-16550) by vstinner · Pull Request #16560 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation2 Commits3 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

)

WindowsLoadTracker.read_output() now uses a short buffer for incomplete line.

(cherry picked from commit 3e04cd2)

The last line is now passed to the parser even if it does not end with a newline, but only if it's a valid value.

(cherry picked from commit c65119d)

• Add log() method: add timestamp and load average prefixes to main messages.

• WindowsLoadTracker:

  • LOAD_FACTOR_1 is now computed using SAMPLING_INTERVAL
  • Initialize the load to the arithmetic mean of the first 5 values of the Processor Queue Length value (so over 5 seconds), rather than 0.0.
  • Handle BrokenPipeError and when typeperf exit.

• format_duration(1.5) now returns '1.5 sec', rather than '1 sec 500 ms'

(cherry picked from commit 098e256)

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Oct 3, 2019

…ythonGH-16550) (pythonGH-16560)

• bpo-36670, regrtest: Fix WindowsLoadTracker() for partial line (pythonGH-16550)

WindowsLoadTracker.read_output() now uses a short buffer for incomplete line.

(cherry picked from commit 3e04cd2)

• bpo-36670: Enhance regrtest WindowsLoadTracker (pythonGH-16553)

The last line is now passed to the parser even if it does not end with a newline, but only if it's a valid value.

(cherry picked from commit c65119d)

• bpo-36670: Enhance regrtest (pythonGH-16556)

• Add log() method: add timestamp and load average prefixes to main messages.

• WindowsLoadTracker:

  • LOAD_FACTOR_1 is now computed using SAMPLING_INTERVAL
  • Initialize the load to the arithmetic mean of the first 5 values of the Processor Queue Length value (so over 5 seconds), rather than 0.0.
  • Handle BrokenPipeError and when typeperf exit.

• format_duration(1.5) now returns '1.5 sec', rather than '1 sec 500 ms'

(cherry picked from commit 098e256) (cherry picked from commit de3195c)

Co-authored-by: Victor Stinner vstinner@python.org

miss-islington added a commit that referenced this pull request

Oct 3, 2019

…H-16550) (GH-16560)

• bpo-36670, regrtest: Fix WindowsLoadTracker() for partial line (GH-16550)

WindowsLoadTracker.read_output() now uses a short buffer for incomplete line.

(cherry picked from commit 3e04cd2)

• bpo-36670: Enhance regrtest WindowsLoadTracker (GH-16553)

The last line is now passed to the parser even if it does not end with a newline, but only if it's a valid value.

(cherry picked from commit c65119d)

• bpo-36670: Enhance regrtest (GH-16556)

• Add log() method: add timestamp and load average prefixes to main messages.

• WindowsLoadTracker:

  • LOAD_FACTOR_1 is now computed using SAMPLING_INTERVAL
  • Initialize the load to the arithmetic mean of the first 5 values of the Processor Queue Length value (so over 5 seconds), rather than 0.0.
  • Handle BrokenPipeError and when typeperf exit.

• format_duration(1.5) now returns '1.5 sec', rather than '1 sec 500 ms'

(cherry picked from commit 098e256) (cherry picked from commit de3195c)

Co-authored-by: Victor Stinner vstinner@python.org