bpo-42345: Fix three issues with typing.Literal parameters by uriyyo · Pull Request #23294 · python/cpython (original) (raw)
Literal equality no longer depends on the order of arguments.
Fix issue related to typing.Literal
caching by adding typed
parameter to typing._tp_cache
function.
Add deduplication of typing.Literal
arguments.
https://bugs.python.org/issue42345
Automerge-Triggered-By: GH:gvanrossum
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, thank you for your PR to cpython! This looks very good to me, just one thing about de-duplicating literals pointed out in the review below.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think that Literal should de-duplicate its __args__
similar to Union, although I now see the set
approach won't work. Maybe you can call set
on the _value_and_type_iter
function, then extract out the parameters again, something like:
def Literal: ... parameters = [p for p, _ in set(_value_and_type_iter(parameters))] return _LiteralGenericAlias(self, parameters)
This probably needs more discussion, and Guido/Ivan's decision on what the expected behavior should be. Maybe we can ask on the bpo issue.
@Fidget-Spinner There is a problem with Literal
caching.
Code like this will fail because of type caching:
Literal[0] == Literal[False] False
Code below will show the root cause of this problem:
(Literal[0], Literal[False]) (Litera[0], Literal[0])
As a solution, we can disable caching for a Literal
.
What do you think about that?
Code like this will fail because of type caching:
One possible workaround for that is to pass typed=True
for lru_cache
in tp_cache
, then it will differentiate 0 and False.
The only problem is I realized that set
will still fail for passing in dict Literal.
A possible workaround is to just loop through them and check the other args one by one (not particularly efficient but I don't expect Literals to be too long, and with cache it should offset some of it), something like what _remove_dups_flatten
for Union does, but instead you can't use set
due to non-hashable args. Something like:
more code here to keep track and store the unique elements
... for index, i_elem in enumerate(parameters): is_duplicate = False for j_elem in parameters[index:]: if i_elem == j_elem: is_duplicate = True break ... # more code for logic to handle the unique elements
I think before we progress further, we should wait for a core dev to respond on the bpo. They might think just having comparisons work is sufficient, and that de-duplicating args isn't needed. So let's save our effort for now 😉 .
Edit:
I just remembered that _tp_cache
will just default to non-cache behavior for dict literals, so it's fine to just leave it mostly untouched.
@Fidget-Spinner I forget about lru_cache
typed
parameter, thanks for the reminder
I totally agree with you, let wait for a decision from Guido and Ivan regarding Literal
args de-duplicating.
As for me, we can skip args de-duplication because Literal
equals method will convert everything to set
so duplicates won't be a problem.
Please change the title and news text. We don’t use the style that describes the new state, we describe the action of the PR as a change to the behavior. For examples, just look at the commit log.
uriyyo changed the title
bpo-42345: Literal equality no longer depends on order of arguments bpo-42345: Fix typing.Literal equals method to ignore the order of arguments
I have updated the title and news.
Sorry for that, I didn't notice this convention. My bad.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, except for one nit.
You might mention in the description (not the title) and the news file that you also fixed an issue where incorrectly Literal[0] == Literal[False]
-- good catch, that!
@gvanrossum I have seen your message regarding Literal
args deduplication, so I have implemented it in the scope of this PR.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting very close :). Thank you for your patience.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and sorry for the weird tangents I went off on in some places!
@Fidget-Spinner thanks for the review and all comments 🙂
What will be the next step regarding this PR?
@Fidget-Spinner thanks for the review and all comments 🙂
What will be the next step regarding this PR?
@uriyyo A core dev like Guido/Ivan will take a look, once they're satisfied and approve it, it will be merged into 3.10. And probably backported to 3.9 and 3.8 too (done automatically via bots). This may take some time depending on how busy the core devs are.
I'm looking forward to see your first commit to cpython :).
I will look at it some time this week.
miss-islington pushed a commit that referenced this pull request
Literal equality no longer depends on the order of arguments.
Fix issue related to typing.Literal
caching by adding typed
parameter to typing._tp_cache
function.
Add deduplication of typing.Literal
arguments.
(cherry picked from commit f03d318)
Co-authored-by: Yurii Karabas 1998uriyyo@gmail.com
Should the docs of typing.get_args be updated to mention
Literal
as well (similar to #23254)?Sure, but I would make a minimal change, e.g. changing "Union" in that paragraph to "Union or Literal".
@uriyyo What about updating the docs of typing.get_args
?
Should the docs of typing.get_args be updated to mention
Literal
as well (similar to #23254)?Sure, but I would make a minimal change, e.g. changing "Union" in that paragraph to "Union or Literal".
@uriyyo What about updating the docs of
typing.get_args
?
@Dominik1123, not sure if this is a bug, but hash()
of Literal is dependent on args order in the current code, so the type caching problem won't happen. Currently, it's still only Union affected.
hash(Literal[1, 2, 3]) 3136223724409791019 hash(Literal[3, 2, 1]) 4438910888190981000
@Fidget-Spinner Looks like we should not update docs because Literal
can't be parametrized with generics so this problem will not exist for Literal
. Please correct me if I miss smth.
But Literal can occur inside other types, e.g. Tuple[str, str, Literal[0, 1, 2]]
.
@uriyyo yeah, sorry if I wasn't clear in my original statement - I was in support of not updating the docs. Although my reasoning is slightly different. It's not about generics, the behavior Dominik mentioned happens when Union's nested in anything. The real reason why we don't need a docs update is because the __hash__
of Literal in your patch is order-dependent.
Edit:
Eg:
Union with args not preserving order when nested due to type caching.
Tuple[Union[int, str]].args (typing.Union[int, str],) Tuple[Union[str, int]].args (typing.Union[int, str],)
Literal doesn't have that issue
Tuple[Literal[1, 2]].args (typing.Literal[1, 2],) Tuple[Literal[2, 1]].args (typing.Literal[2, 1],)
@uriyyo Awesome! I'm glad I was able to help :).
Oops, forgot to say this: Congrats to your first commit to CPython!
Should the docs of typing.get_args be updated to mention
Literal
as well (similar to #23254)?Sure, but I would make a minimal change, e.g. changing "Union" in that paragraph to "Union or Literal".
@uriyyo What about updating the docs of
typing.get_args
?@Dominik1123, not sure if this is a bug, but
hash()
of Literal is dependent on args order in the current code, so the type caching problem won't happen. Currently, it's still only Union affected.hash(Literal[1, 2, 3]) 3136223724409791019 hash(Literal[3, 2, 1]) 4438910888190981000
@Fidget-Spinner @uriyyo I see, I didn't notice before. But isn't this very unusual in terms of behavior? So we can have two objects that compare equal but their hashes are different. AFAIK nowhere else in Python this is the case. The closest that comes to it in terms "being equal, but not having the same hash" is set
and frozenset
but in that case at least set
will raise. Now for Literal
it's yet another level, since the hashes are actually computed, and it's even the same type.
To quote the Python data model on __hash__
:
The only required property is that objects which compare equal have the same hash value;
So according to that it's a bug and the hash should not be order dependent.
@Dominik1123 Agree with you, looks like it's a bug related to Literal
hash implementation, basically, we should change implementation from:
def __hash__(self):
return hash(tuple(_value_and_type_iter(self.__args__)))
to:
def __hash__(self):
return hash(frozentset(_value_and_type_iter(self.__args__)))
@Fidget-Spinner should we create issue regarding this bug?
@Dominik1123 Agree with you, looks like it's a bug related to
Literal
hash implementation, basically, we should change implementation from:def hash(self): return hash(tuple(_value_and_type_iter(self.args)))
to:
def hash(self): return hash(frozentset(_value_and_type_iter(self.args)))
I'm not sure if frozenset
is too restrictive in terms of the values it can work with. Right now PEP 586 disallows literals of mutable types, but only at type check time. The PEP also contains the following comment:
[...] the actual implementation of
typing.Literal
will not perform any checks at runtime. [...] This is partly to help us preserve flexibility in case we want to expand the scope of what Literal can be used for in the future [...]
Using frozenset
would take away on that flexibility regarding literals of mutable types. Not sure if that's relevant though. I think we should wait for @gvanrossum to comment on this.
Whoa, this is a bug. It not allowed to have two objects that compare equal but have a different hash. So since Literal[1, 2] == Literal[2, 1]
, those two should have the same hash. I'm sorry I didn't catch this!
Using set() or frozenset() here is totally fine, we already use those in __eq__
. I'd use set().
@gvanrossum Should we create a separate issue or just open a new PR that will point to the same issue as this PR?
Create a new PR pointing to the same issue -- I already reopened it.
miss-islington pushed a commit that referenced this pull request
Fix hash implementation of typing.Literal
.
Update docs regarding typing.Litaral
caching.
Base implementation was done in PR #23294.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
Fix hash implementation of typing.Literal
.
Update docs regarding typing.Litaral
caching.
Base implementation was done in PR pythonGH-23294. (cherry picked from commit 1b54077)
Co-authored-by: Yurii Karabas 1998uriyyo@gmail.com
miss-islington added a commit that referenced this pull request
Fix hash implementation of typing.Literal
.
Update docs regarding typing.Litaral
caching.
Base implementation was done in PR GH-23294. (cherry picked from commit 1b54077)
Co-authored-by: Yurii Karabas 1998uriyyo@gmail.com
adorilson pushed a commit to adorilson/cpython that referenced this pull request
Literal equality no longer depends on the order of arguments.
Fix issue related to typing.Literal
caching by adding typed
parameter to typing._tp_cache
function.
Add deduplication of typing.Literal
arguments.
adorilson pushed a commit to adorilson/cpython that referenced this pull request
Fix hash implementation of typing.Literal
.
Update docs regarding typing.Litaral
caching.
Base implementation was done in PR python#23294.
kraj pushed a commit to YoeDistro/poky that referenced this pull request
Changelog:
- Fix use of @deprecated on classes with new but no init.
- Fix regression in version 4.6.1 where comparing a generic class against a runtime-checkable protocol using isinstance() would cause AttributeError to be raised if using Python 3.7.
- Change deprecated @runtime to formal API @runtime_checkable in the error message.
- Fix regression in 4.6.0 where attempting to define a Protocol that was generic over a ParamSpec or a TypeVarTuple would cause TypeError to be raised.
- typing_extensions is now documented at https://typing-extensions.readthedocs.io/en/latest/.
- Add typing_extensions.Buffer, a marker class for buffer types, as proposed by PEP 688. Equivalent to collections.abc.Buffer in Python 3.12.
- Backport two CPython PRs fixing various issues with typing.Literal: python/cpython#23294 and python/cpython#23383. Both CPython PRs were originally, and both were backported to Python >=3.9.1, but no earlier.
- A side effect of one of the changes is that equality comparisons of Literal objects will now raise a TypeError if one of the Literal objects being compared has a mutable parameter. (Using mutable parameters with Literal is not supported by PEP 586 or by any major static type checkers.)
- Literal is now reimplemented on all Python versions <= 3.10.0.
- Backport CPython PR 26067, ensuring that isinstance() calls on protocols raise TypeError when the protocol is not decorated with @runtime_checkable.
- Backport several significant performance improvements to runtime-checkable protocols that have been made in Python 3.12 (see python/cpython#74690 for details).
- A side effect of one of the performance improvements is that the members of a runtime-checkable protocol are now considered "frozen" at runtime as soon as the class has been created. Monkey-patching attributes onto a runtime-checkable protocol will still work, but will have no impact on isinstance() checks comparing objects to the protocol. See "What's New in Python 3.12" for more details.
- isinstance() checks against runtime-checkable protocols now use inspect.getattr_static() rather than hasattr() to lookup whether attributes exist (backporting python/cpython#103034).
- Backport the ability to define init methods on Protocol classes, a change made in Python 3.11 (originally implemented in python/cpython#31628
- Speedup isinstance(3, typing_extensions.SupportsIndex) by >10x on Python <3.12.
- Add typing_extensions versions of SupportsInt, SupportsFloat, SupportsComplex, SupportsBytes, SupportsAbs and SupportsRound. These have the same semantics as the versions from the typing module, but isinstance() checks against the typing_extensions versions are >10x faster at runtime on Python <3.12.
- Add orig_bases to non-generic TypedDicts, call-based TypedDicts, and call-based NamedTuples.
- Add typing_extensions.get_original_bases, a backport of types.get_original_bases, introduced in Python 3.12 (CPython PR python/cpython#101827, originally
- This function should always produce correct results when called on classes constructed using features from typing_extensions.
- Constructing a call-based TypedDict using keyword arguments for the fields now causes a DeprecationWarning to be emitted. This matches the behaviour of typing.TypedDict on 3.11 and 3.12.
- Backport the implementation of NewType from 3.10 (where it is implemented as a class rather than a function). This allows user-defined NewTypes to be pickled.
- Fix tests and import on Python 3.12, where typing.TypeVar can no longer be subclassed.
- Add typing_extensions.TypeAliasType, a backport of typing.TypeAliasType from PEP 695.
- Backport changes to the repr of typing.Unpack that were made in order to implement PEP 692 (backport of python/cpython#104048).
(From OE-Core rev: 2b1d07c7deb4f0247765bc737fb11a1747143edf)
Signed-off-by: Wang Mingyu wangmy@fujitsu.com Signed-off-by: Alexandre Belloni alexandre.belloni@bootlin.com
rpurdie pushed a commit to yoctoproject/poky that referenced this pull request
Changelog:
- Fix use of @deprecated on classes with new but no init.
- Fix regression in version 4.6.1 where comparing a generic class against a runtime-checkable protocol using isinstance() would cause AttributeError to be raised if using Python 3.7.
- Change deprecated @runtime to formal API @runtime_checkable in the error message.
- Fix regression in 4.6.0 where attempting to define a Protocol that was generic over a ParamSpec or a TypeVarTuple would cause TypeError to be raised.
- typing_extensions is now documented at https://typing-extensions.readthedocs.io/en/latest/.
- Add typing_extensions.Buffer, a marker class for buffer types, as proposed by PEP 688. Equivalent to collections.abc.Buffer in Python 3.12.
- Backport two CPython PRs fixing various issues with typing.Literal: python/cpython#23294 and python/cpython#23383. Both CPython PRs were originally, and both were backported to Python >=3.9.1, but no earlier.
- A side effect of one of the changes is that equality comparisons of Literal objects will now raise a TypeError if one of the Literal objects being compared has a mutable parameter. (Using mutable parameters with Literal is not supported by PEP 586 or by any major static type checkers.)
- Literal is now reimplemented on all Python versions <= 3.10.0.
- Backport CPython PR 26067, ensuring that isinstance() calls on protocols raise TypeError when the protocol is not decorated with @runtime_checkable.
- Backport several significant performance improvements to runtime-checkable protocols that have been made in Python 3.12 (see python/cpython#74690 for details).
- A side effect of one of the performance improvements is that the members of a runtime-checkable protocol are now considered "frozen" at runtime as soon as the class has been created. Monkey-patching attributes onto a runtime-checkable protocol will still work, but will have no impact on isinstance() checks comparing objects to the protocol. See "What's New in Python 3.12" for more details.
- isinstance() checks against runtime-checkable protocols now use inspect.getattr_static() rather than hasattr() to lookup whether attributes exist (backporting python/cpython#103034).
- Backport the ability to define init methods on Protocol classes, a change made in Python 3.11 (originally implemented in python/cpython#31628
- Speedup isinstance(3, typing_extensions.SupportsIndex) by >10x on Python <3.12.
- Add typing_extensions versions of SupportsInt, SupportsFloat, SupportsComplex, SupportsBytes, SupportsAbs and SupportsRound. These have the same semantics as the versions from the typing module, but isinstance() checks against the typing_extensions versions are >10x faster at runtime on Python <3.12.
- Add orig_bases to non-generic TypedDicts, call-based TypedDicts, and call-based NamedTuples.
- Add typing_extensions.get_original_bases, a backport of types.get_original_bases, introduced in Python 3.12 (CPython PR python/cpython#101827, originally
- This function should always produce correct results when called on classes constructed using features from typing_extensions.
- Constructing a call-based TypedDict using keyword arguments for the fields now causes a DeprecationWarning to be emitted. This matches the behaviour of typing.TypedDict on 3.11 and 3.12.
- Backport the implementation of NewType from 3.10 (where it is implemented as a class rather than a function). This allows user-defined NewTypes to be pickled.
- Fix tests and import on Python 3.12, where typing.TypeVar can no longer be subclassed.
- Add typing_extensions.TypeAliasType, a backport of typing.TypeAliasType from PEP 695.
- Backport changes to the repr of typing.Unpack that were made in order to implement PEP 692 (backport of python/cpython#104048).
(From OE-Core rev: a37154b9166323d05cca970ebb37bee0d5250893)
Signed-off-by: Wang Mingyu wangmy@fujitsu.com Signed-off-by: Alexandre Belloni alexandre.belloni@bootlin.com Signed-off-by: Richard Purdie richard.purdie@linuxfoundation.org
halstead pushed a commit to openembedded/openembedded-core that referenced this pull request
Changelog:
- Fix use of @deprecated on classes with new but no init.
- Fix regression in version 4.6.1 where comparing a generic class against a runtime-checkable protocol using isinstance() would cause AttributeError to be raised if using Python 3.7.
- Change deprecated @runtime to formal API @runtime_checkable in the error message.
- Fix regression in 4.6.0 where attempting to define a Protocol that was generic over a ParamSpec or a TypeVarTuple would cause TypeError to be raised.
- typing_extensions is now documented at https://typing-extensions.readthedocs.io/en/latest/.
- Add typing_extensions.Buffer, a marker class for buffer types, as proposed by PEP 688. Equivalent to collections.abc.Buffer in Python 3.12.
- Backport two CPython PRs fixing various issues with typing.Literal: python/cpython#23294 and python/cpython#23383. Both CPython PRs were originally, and both were backported to Python >=3.9.1, but no earlier.
- A side effect of one of the changes is that equality comparisons of Literal objects will now raise a TypeError if one of the Literal objects being compared has a mutable parameter. (Using mutable parameters with Literal is not supported by PEP 586 or by any major static type checkers.)
- Literal is now reimplemented on all Python versions <= 3.10.0.
- Backport CPython PR 26067, ensuring that isinstance() calls on protocols raise TypeError when the protocol is not decorated with @runtime_checkable.
- Backport several significant performance improvements to runtime-checkable protocols that have been made in Python 3.12 (see python/cpython#74690 for details).
- A side effect of one of the performance improvements is that the members of a runtime-checkable protocol are now considered "frozen" at runtime as soon as the class has been created. Monkey-patching attributes onto a runtime-checkable protocol will still work, but will have no impact on isinstance() checks comparing objects to the protocol. See "What's New in Python 3.12" for more details.
- isinstance() checks against runtime-checkable protocols now use inspect.getattr_static() rather than hasattr() to lookup whether attributes exist (backporting python/cpython#103034).
- Backport the ability to define init methods on Protocol classes, a change made in Python 3.11 (originally implemented in python/cpython#31628
- Speedup isinstance(3, typing_extensions.SupportsIndex) by >10x on Python <3.12.
- Add typing_extensions versions of SupportsInt, SupportsFloat, SupportsComplex, SupportsBytes, SupportsAbs and SupportsRound. These have the same semantics as the versions from the typing module, but isinstance() checks against the typing_extensions versions are >10x faster at runtime on Python <3.12.
- Add orig_bases to non-generic TypedDicts, call-based TypedDicts, and call-based NamedTuples.
- Add typing_extensions.get_original_bases, a backport of types.get_original_bases, introduced in Python 3.12 (CPython PR python/cpython#101827, originally
- This function should always produce correct results when called on classes constructed using features from typing_extensions.
- Constructing a call-based TypedDict using keyword arguments for the fields now causes a DeprecationWarning to be emitted. This matches the behaviour of typing.TypedDict on 3.11 and 3.12.
- Backport the implementation of NewType from 3.10 (where it is implemented as a class rather than a function). This allows user-defined NewTypes to be pickled.
- Fix tests and import on Python 3.12, where typing.TypeVar can no longer be subclassed.
- Add typing_extensions.TypeAliasType, a backport of typing.TypeAliasType from PEP 695.
- Backport changes to the repr of typing.Unpack that were made in order to implement PEP 692 (backport of python/cpython#104048).
Signed-off-by: Wang Mingyu wangmy@fujitsu.com Signed-off-by: Alexandre Belloni alexandre.belloni@bootlin.com
renovate bot referenced this pull request in allenporter/flux-local
This PR contains the following updates:
Package | Change | Age | Adoption | Passing | Confidence |
---|---|---|---|---|---|
typing-extensions | |||||
(changelog) | |||||
==4.5.0 -> ==4.6.3 |
|||||
Release Notes
python/typing_extensions
- Fix a regression introduced in v4.6.0 in the implementation of
runtime-checkable protocols. The regression meant
that doing
class Foo(X, typing_extensions.Protocol)
, whereX
was a class that hadabc.ABCMeta
as its metaclass, would then cause subsequentisinstance(1, X)
calls to erroneously raiseTypeError
. Patch by Alex Waygood (backporting the CPythonhttps://github.com/python/cpython/pull/105152l/105152). - Sync the repository's LICENSE file with that of CPython.
typing_extensions
is distributed under the same license as CPython itself. - Skip a problematic test on Python 3.12.0b1. The test fails on 3.12.0b1
due to
a bug in CPython, which will be fixed in 3.12.0b2. The
typing_extensions
test suite now passes on 3.12.0b1.
- Fix use of
@deprecated
on classes with__new__
but no__init__
. Patch by Jelle Zijlstra. - Fix regression in version 4.6.1 where comparing a generic class
against a
runtime-checkable protocol using
isinstance()
would causeAttributeError
to be raised if using Python 3.7.
- Change deprecated
@runtime
to formal API@runtime_checkable
in the error message. Patch by Xuehai Pan. - Fix regression in 4.6.0 where attempting to define a
Protocol
that was generic over aParamSpec
or aTypeVarTuple
would causeTypeError
to be raised. Patch by Alex Waygood.
typing_extensions
is now documented at https://typing-extensions.readthedocs.io/en/latest/. Patch by Jelle Zijlstra.- Add
typing_extensions.Buffer
, a marker class for buffer types, as proposed by PEP 688. Equivalent tocollections.abc.Buffer
in Python 3.12. Patch by Jelle Zijlstra. - Backport two CPython PRs fixing various issues with
typing.Literal
:
https://github.com/python/cpython/pull/232943294 https://github.com/python/cpython/pull/23383ll/23383. Both CPython PRs were originally by Yurii Karabas, and both were backported to Python >=3.9.1, but no earlier. Patch by Alex Waygood.
A side effect of one of the changes is that equality comparisons of
Literal
objects will now raise a TypeError
if one of the Literal
objects
being
compared has a mutable parameter. (Using mutable parameters with
Literal
is
not supported by PEP 586 or by any major static type checkers.)
Literal
is now reimplemented on all Python versions <= 3.10.0. Thetyping_extensions
version does not suffer from the bug that was fixed in
https://github.com/python/cpython/pull/293349334. (The CPython bugfix was backported to CPython 3.10.1 and 3.9.8, but no earlier.)
- Backport CPython PR
26067
(originally by Yurii Karabas), ensuring that
isinstance()
calls on protocols raiseTypeError
when the protocol is not decorated with@runtime_checkable
. Patch by Alex Waygood. - Backport several significant performance improvements to runtime-checkable protocols that have been made in Python 3.12 (https://github.com/python/cpython/issues/74690es/74690 for details). Patch by Alex Waygood.
A side effect of one of the performance improvements is that the members
of
a runtime-checkable protocol are now considered “frozen” at runtime as
soon
as the class has been created. Monkey-patching attributes onto a
runtime-checkable protocol will still work, but will have no impact on
isinstance()
checks comparing objects to the protocol. See
"What's New in Python
3.12"
for more details.
isinstance()
checks against runtime-checkable protocols now useinspect.getattr_static()
rather thanhasattr()
to lookup whether attributes exist (backporthttps://github.com/python/cpython/pull/1030343034). This means that descriptors and__getattr__
methods are no longer unexpectedly evaluated duringisinstance()
checks against runtime-checkable protocols. However, it may also mean that some objects which used to be considered instances of a runtime-checkable protocol on older versions oftyping_extensions
may no longer be considered instances of that protocol using the new release, and vice versa. Most users are unlikely to be affected by this change. Patch by Alex Waygood.- Backport the ability to define
__init__
methods on Protocol classes, a change made in Python 3.11 (originally implementedhttps://github.com/python/cpython/pull/31628ll/31628 by Adrian Garcia Badaracco). Patch by Alex Waygood. - Speedup
isinstance(3, typing_extensions.SupportsIndex)
by >10x on Python <3.12. Patch by Alex Waygood. - Add
typing_extensions
versions ofSupportsInt
,SupportsFloat
,SupportsComplex
,SupportsBytes
,SupportsAbs
andSupportsRound
. These have the same semantics as the versions from thetyping
module, butisinstance()
checks against thetyping_extensions
versions are >10x faster at runtime on Python <3.12. Patch by Alex Waygood. - Add
__orig_bases__
to non-generic TypedDicts, call-based TypedDicts, and call-based NamedTuples. Other TypedDicts and NamedTuples already had the attribute. Patch by Adrian Garcia Badaracco. - Add
typing_extensions.get_original_bases
, a backport of
types.get_original_bases
,
introduced in Python 3.12
(CPythonhttps://github.com/python/cpython/pull/101827l/101827,
originally by James
Hilton-Balfe). Patch by Alex Waygood.
This function should always produce correct results when called on
classes
constructed using features from typing_extensions
. However, it may
produce incorrect results when called on some NamedTuple
or
TypedDict
classes that use typing.{NamedTuple,TypedDict}
on Python <=3.11.
- Constructing a call-based
TypedDict
using keyword arguments for the fields now causes aDeprecationWarning
to be emitted. This matches the behaviour oftyping.TypedDict
on 3.11 and 3.12. - Backport the implementation of
NewType
from 3.10 (where it is implemented as a class rather than a function). This allows user-definedNewType
s to be pickled. Patch by Alex Waygood. - Fix tests and import on Python 3.12, where
typing.TypeVar
can no longer be subclassed. Patch by Jelle Zijlstra. - Add
typing_extensions.TypeAliasType
, a backport oftyping.TypeAliasType
from PEP 695. Patch by Jelle Zijlstra. - Backport changes to the repr of
typing.Unpack
that were made in order to implement PEP 692 (backport of
https://github.com/python/cpython/pull/1040484048). Patch by Alex Waygood.
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
- If you want to rebase/retry this PR, check this box
This PR has been generated by Mend Renovate. View repository job log here.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
daregit pushed a commit to daregit/yocto-combined that referenced this pull request
Changelog:
- Fix use of @deprecated on classes with new but no init.
- Fix regression in version 4.6.1 where comparing a generic class against a runtime-checkable protocol using isinstance() would cause AttributeError to be raised if using Python 3.7.
- Change deprecated @runtime to formal API @runtime_checkable in the error message.
- Fix regression in 4.6.0 where attempting to define a Protocol that was generic over a ParamSpec or a TypeVarTuple would cause TypeError to be raised.
- typing_extensions is now documented at https://typing-extensions.readthedocs.io/en/latest/.
- Add typing_extensions.Buffer, a marker class for buffer types, as proposed by PEP 688. Equivalent to collections.abc.Buffer in Python 3.12.
- Backport two CPython PRs fixing various issues with typing.Literal: python/cpython#23294 and python/cpython#23383. Both CPython PRs were originally, and both were backported to Python >=3.9.1, but no earlier.
- A side effect of one of the changes is that equality comparisons of Literal objects will now raise a TypeError if one of the Literal objects being compared has a mutable parameter. (Using mutable parameters with Literal is not supported by PEP 586 or by any major static type checkers.)
- Literal is now reimplemented on all Python versions <= 3.10.0.
- Backport CPython PR 26067, ensuring that isinstance() calls on protocols raise TypeError when the protocol is not decorated with @runtime_checkable.
- Backport several significant performance improvements to runtime-checkable protocols that have been made in Python 3.12 (see python/cpython#74690 for details).
- A side effect of one of the performance improvements is that the members of a runtime-checkable protocol are now considered "frozen" at runtime as soon as the class has been created. Monkey-patching attributes onto a runtime-checkable protocol will still work, but will have no impact on isinstance() checks comparing objects to the protocol. See "What's New in Python 3.12" for more details.
- isinstance() checks against runtime-checkable protocols now use inspect.getattr_static() rather than hasattr() to lookup whether attributes exist (backporting python/cpython#103034).
- Backport the ability to define init methods on Protocol classes, a change made in Python 3.11 (originally implemented in python/cpython#31628
- Speedup isinstance(3, typing_extensions.SupportsIndex) by >10x on Python <3.12.
- Add typing_extensions versions of SupportsInt, SupportsFloat, SupportsComplex, SupportsBytes, SupportsAbs and SupportsRound. These have the same semantics as the versions from the typing module, but isinstance() checks against the typing_extensions versions are >10x faster at runtime on Python <3.12.
- Add orig_bases to non-generic TypedDicts, call-based TypedDicts, and call-based NamedTuples.
- Add typing_extensions.get_original_bases, a backport of types.get_original_bases, introduced in Python 3.12 (CPython PR python/cpython#101827, originally
- This function should always produce correct results when called on classes constructed using features from typing_extensions.
- Constructing a call-based TypedDict using keyword arguments for the fields now causes a DeprecationWarning to be emitted. This matches the behaviour of typing.TypedDict on 3.11 and 3.12.
- Backport the implementation of NewType from 3.10 (where it is implemented as a class rather than a function). This allows user-defined NewTypes to be pickled.
- Fix tests and import on Python 3.12, where typing.TypeVar can no longer be subclassed.
- Add typing_extensions.TypeAliasType, a backport of typing.TypeAliasType from PEP 695.
- Backport changes to the repr of typing.Unpack that were made in order to implement PEP 692 (backport of python/cpython#104048).
(From OE-Core rev: a37154b9166323d05cca970ebb37bee0d5250893)
Signed-off-by: Wang Mingyu wangmy@fujitsu.com Signed-off-by: Alexandre Belloni alexandre.belloni@bootlin.com Signed-off-by: Richard Purdie richard.purdie@linuxfoundation.org