bpo-44807: Allow Protocol classes to define init by adriangb · Pull Request #31628 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation9 Commits7 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

adriangb marked this pull request as ready for review

March 1, 2022 06:23

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But presumably P(1) will work?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch. This is a bad assertion with an even worse comment: this TypeError is occurring because it's missing an argument, not because of the no-instantiation check. I'm inclined to just remove this assertRaises. What do you think?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that the current test doesn't make much sense. It would be useful though to add a test that asserts that P.__init__ doesn't get clobbered. For example, you could call P.__init__(some_object, 1) directly.

(Also, unrelatedly, this change will need a NEWS entry.)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the feedback.

I split up the test into 2:

1. Verify that __init__ is no longer clobbered (as per your suggestion)
2. Check that concrete subclasses can inherit and use init from a protocol class

Co-authored-by: Jelle Zijlstra jelle.zijlstra@gmail.com

Co-authored-by: Jelle Zijlstra jelle.zijlstra@gmail.com

Co-authored-by: Jelle Zijlstra jelle.zijlstra@gmail.com

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gobot1234 added a commit to Gobot1234/typing_extensions that referenced this pull request

Feb 20, 2023

kraj pushed a commit to YoeDistro/poky that referenced this pull request

Jun 1, 2023

Changelog:

• Fix use of @deprecated on classes with new but no init.
• Fix regression in version 4.6.1 where comparing a generic class against a runtime-checkable protocol using isinstance() would cause AttributeError to be raised if using Python 3.7.
• Change deprecated @runtime to formal API @runtime_checkable in the error message.
• Fix regression in 4.6.0 where attempting to define a Protocol that was generic over a ParamSpec or a TypeVarTuple would cause TypeError to be raised.
• typing_extensions is now documented at https://typing-extensions.readthedocs.io/en/latest/.
• Add typing_extensions.Buffer, a marker class for buffer types, as proposed by PEP 688. Equivalent to collections.abc.Buffer in Python 3.12.
• Backport two CPython PRs fixing various issues with typing.Literal: python/cpython#23294 and python/cpython#23383. Both CPython PRs were originally, and both were backported to Python >=3.9.1, but no earlier.
• A side effect of one of the changes is that equality comparisons of Literal objects will now raise a TypeError if one of the Literal objects being compared has a mutable parameter. (Using mutable parameters with Literal is not supported by PEP 586 or by any major static type checkers.)
• Literal is now reimplemented on all Python versions <= 3.10.0.
• Backport CPython PR 26067, ensuring that isinstance() calls on protocols raise TypeError when the protocol is not decorated with @runtime_checkable.
• Backport several significant performance improvements to runtime-checkable protocols that have been made in Python 3.12 (see python/cpython#74690 for details).
• A side effect of one of the performance improvements is that the members of a runtime-checkable protocol are now considered "frozen" at runtime as soon as the class has been created. Monkey-patching attributes onto a runtime-checkable protocol will still work, but will have no impact on isinstance() checks comparing objects to the protocol. See "What's New in Python 3.12" for more details.
• isinstance() checks against runtime-checkable protocols now use inspect.getattr_static() rather than hasattr() to lookup whether attributes exist (backporting python/cpython#103034).
• Backport the ability to define init methods on Protocol classes, a change made in Python 3.11 (originally implemented in python/cpython#31628
• Speedup isinstance(3, typing_extensions.SupportsIndex) by >10x on Python <3.12.
• Add typing_extensions versions of SupportsInt, SupportsFloat, SupportsComplex, SupportsBytes, SupportsAbs and SupportsRound. These have the same semantics as the versions from the typing module, but isinstance() checks against the typing_extensions versions are >10x faster at runtime on Python <3.12.
• Add orig_bases to non-generic TypedDicts, call-based TypedDicts, and call-based NamedTuples.
• Add typing_extensions.get_original_bases, a backport of types.get_original_bases, introduced in Python 3.12 (CPython PR python/cpython#101827, originally
• This function should always produce correct results when called on classes constructed using features from typing_extensions.
• Constructing a call-based TypedDict using keyword arguments for the fields now causes a DeprecationWarning to be emitted. This matches the behaviour of typing.TypedDict on 3.11 and 3.12.
• Backport the implementation of NewType from 3.10 (where it is implemented as a class rather than a function). This allows user-defined NewTypes to be pickled.
• Fix tests and import on Python 3.12, where typing.TypeVar can no longer be subclassed.
• Add typing_extensions.TypeAliasType, a backport of typing.TypeAliasType from PEP 695.
• Backport changes to the repr of typing.Unpack that were made in order to implement PEP 692 (backport of python/cpython#104048).

(From OE-Core rev: 2b1d07c7deb4f0247765bc737fb11a1747143edf)

Signed-off-by: Wang Mingyu wangmy@fujitsu.com Signed-off-by: Alexandre Belloni alexandre.belloni@bootlin.com

rpurdie pushed a commit to yoctoproject/poky that referenced this pull request

Jun 2, 2023

Changelog:

• Fix use of @deprecated on classes with new but no init.
• Fix regression in version 4.6.1 where comparing a generic class against a runtime-checkable protocol using isinstance() would cause AttributeError to be raised if using Python 3.7.
• Change deprecated @runtime to formal API @runtime_checkable in the error message.
• Fix regression in 4.6.0 where attempting to define a Protocol that was generic over a ParamSpec or a TypeVarTuple would cause TypeError to be raised.
• typing_extensions is now documented at https://typing-extensions.readthedocs.io/en/latest/.
• Add typing_extensions.Buffer, a marker class for buffer types, as proposed by PEP 688. Equivalent to collections.abc.Buffer in Python 3.12.
• Backport two CPython PRs fixing various issues with typing.Literal: python/cpython#23294 and python/cpython#23383. Both CPython PRs were originally, and both were backported to Python >=3.9.1, but no earlier.
• A side effect of one of the changes is that equality comparisons of Literal objects will now raise a TypeError if one of the Literal objects being compared has a mutable parameter. (Using mutable parameters with Literal is not supported by PEP 586 or by any major static type checkers.)
• Literal is now reimplemented on all Python versions <= 3.10.0.
• Backport CPython PR 26067, ensuring that isinstance() calls on protocols raise TypeError when the protocol is not decorated with @runtime_checkable.
• Backport several significant performance improvements to runtime-checkable protocols that have been made in Python 3.12 (see python/cpython#74690 for details).
• A side effect of one of the performance improvements is that the members of a runtime-checkable protocol are now considered "frozen" at runtime as soon as the class has been created. Monkey-patching attributes onto a runtime-checkable protocol will still work, but will have no impact on isinstance() checks comparing objects to the protocol. See "What's New in Python 3.12" for more details.
• isinstance() checks against runtime-checkable protocols now use inspect.getattr_static() rather than hasattr() to lookup whether attributes exist (backporting python/cpython#103034).
• Backport the ability to define init methods on Protocol classes, a change made in Python 3.11 (originally implemented in python/cpython#31628
• Speedup isinstance(3, typing_extensions.SupportsIndex) by >10x on Python <3.12.
• Add typing_extensions versions of SupportsInt, SupportsFloat, SupportsComplex, SupportsBytes, SupportsAbs and SupportsRound. These have the same semantics as the versions from the typing module, but isinstance() checks against the typing_extensions versions are >10x faster at runtime on Python <3.12.
• Add orig_bases to non-generic TypedDicts, call-based TypedDicts, and call-based NamedTuples.
• Add typing_extensions.get_original_bases, a backport of types.get_original_bases, introduced in Python 3.12 (CPython PR python/cpython#101827, originally
• This function should always produce correct results when called on classes constructed using features from typing_extensions.
• Constructing a call-based TypedDict using keyword arguments for the fields now causes a DeprecationWarning to be emitted. This matches the behaviour of typing.TypedDict on 3.11 and 3.12.
• Backport the implementation of NewType from 3.10 (where it is implemented as a class rather than a function). This allows user-defined NewTypes to be pickled.
• Fix tests and import on Python 3.12, where typing.TypeVar can no longer be subclassed.
• Add typing_extensions.TypeAliasType, a backport of typing.TypeAliasType from PEP 695.
• Backport changes to the repr of typing.Unpack that were made in order to implement PEP 692 (backport of python/cpython#104048).

(From OE-Core rev: a37154b9166323d05cca970ebb37bee0d5250893)

Signed-off-by: Wang Mingyu wangmy@fujitsu.com Signed-off-by: Alexandre Belloni alexandre.belloni@bootlin.com Signed-off-by: Richard Purdie richard.purdie@linuxfoundation.org

halstead pushed a commit to openembedded/openembedded-core that referenced this pull request

Jun 2, 2023

Changelog:

• Fix use of @deprecated on classes with new but no init.
• Fix regression in version 4.6.1 where comparing a generic class against a runtime-checkable protocol using isinstance() would cause AttributeError to be raised if using Python 3.7.
• Change deprecated @runtime to formal API @runtime_checkable in the error message.
• Fix regression in 4.6.0 where attempting to define a Protocol that was generic over a ParamSpec or a TypeVarTuple would cause TypeError to be raised.
• typing_extensions is now documented at https://typing-extensions.readthedocs.io/en/latest/.
• Add typing_extensions.Buffer, a marker class for buffer types, as proposed by PEP 688. Equivalent to collections.abc.Buffer in Python 3.12.
• Backport two CPython PRs fixing various issues with typing.Literal: python/cpython#23294 and python/cpython#23383. Both CPython PRs were originally, and both were backported to Python >=3.9.1, but no earlier.
• A side effect of one of the changes is that equality comparisons of Literal objects will now raise a TypeError if one of the Literal objects being compared has a mutable parameter. (Using mutable parameters with Literal is not supported by PEP 586 or by any major static type checkers.)
• Literal is now reimplemented on all Python versions <= 3.10.0.
• Backport CPython PR 26067, ensuring that isinstance() calls on protocols raise TypeError when the protocol is not decorated with @runtime_checkable.
• Backport several significant performance improvements to runtime-checkable protocols that have been made in Python 3.12 (see python/cpython#74690 for details).
• A side effect of one of the performance improvements is that the members of a runtime-checkable protocol are now considered "frozen" at runtime as soon as the class has been created. Monkey-patching attributes onto a runtime-checkable protocol will still work, but will have no impact on isinstance() checks comparing objects to the protocol. See "What's New in Python 3.12" for more details.
• isinstance() checks against runtime-checkable protocols now use inspect.getattr_static() rather than hasattr() to lookup whether attributes exist (backporting python/cpython#103034).
• Backport the ability to define init methods on Protocol classes, a change made in Python 3.11 (originally implemented in python/cpython#31628
• Speedup isinstance(3, typing_extensions.SupportsIndex) by >10x on Python <3.12.
• Add typing_extensions versions of SupportsInt, SupportsFloat, SupportsComplex, SupportsBytes, SupportsAbs and SupportsRound. These have the same semantics as the versions from the typing module, but isinstance() checks against the typing_extensions versions are >10x faster at runtime on Python <3.12.
• Add orig_bases to non-generic TypedDicts, call-based TypedDicts, and call-based NamedTuples.
• Add typing_extensions.get_original_bases, a backport of types.get_original_bases, introduced in Python 3.12 (CPython PR python/cpython#101827, originally
• This function should always produce correct results when called on classes constructed using features from typing_extensions.
• Constructing a call-based TypedDict using keyword arguments for the fields now causes a DeprecationWarning to be emitted. This matches the behaviour of typing.TypedDict on 3.11 and 3.12.
• Backport the implementation of NewType from 3.10 (where it is implemented as a class rather than a function). This allows user-defined NewTypes to be pickled.
• Fix tests and import on Python 3.12, where typing.TypeVar can no longer be subclassed.
• Add typing_extensions.TypeAliasType, a backport of typing.TypeAliasType from PEP 695.
• Backport changes to the repr of typing.Unpack that were made in order to implement PEP 692 (backport of python/cpython#104048).

Signed-off-by: Wang Mingyu wangmy@fujitsu.com Signed-off-by: Alexandre Belloni alexandre.belloni@bootlin.com

renovate bot referenced this pull request in allenporter/flux-local

Jun 3, 2023

](https://renovatebot.com)

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
typing-extensions
(changelog)
==4.5.0 -> ==4.6.3
](https://docs.renovatebot.com/merge-confidence/)
](https://docs.renovatebot.com/merge-confidence/)
](https://docs.renovatebot.com/merge-confidence/)
](https://docs.renovatebot.com/merge-confidence/)

Release Notes

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

• If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

daregit pushed a commit to daregit/yocto-combined that referenced this pull request

May 22, 2024

Changelog:

• Fix use of @deprecated on classes with new but no init.
• Fix regression in version 4.6.1 where comparing a generic class against a runtime-checkable protocol using isinstance() would cause AttributeError to be raised if using Python 3.7.
• Change deprecated @runtime to formal API @runtime_checkable in the error message.
• Fix regression in 4.6.0 where attempting to define a Protocol that was generic over a ParamSpec or a TypeVarTuple would cause TypeError to be raised.
• typing_extensions is now documented at https://typing-extensions.readthedocs.io/en/latest/.
• Add typing_extensions.Buffer, a marker class for buffer types, as proposed by PEP 688. Equivalent to collections.abc.Buffer in Python 3.12.
• Backport two CPython PRs fixing various issues with typing.Literal: python/cpython#23294 and python/cpython#23383. Both CPython PRs were originally, and both were backported to Python >=3.9.1, but no earlier.
• A side effect of one of the changes is that equality comparisons of Literal objects will now raise a TypeError if one of the Literal objects being compared has a mutable parameter. (Using mutable parameters with Literal is not supported by PEP 586 or by any major static type checkers.)
• Literal is now reimplemented on all Python versions <= 3.10.0.
• Backport CPython PR 26067, ensuring that isinstance() calls on protocols raise TypeError when the protocol is not decorated with @runtime_checkable.
• Backport several significant performance improvements to runtime-checkable protocols that have been made in Python 3.12 (see python/cpython#74690 for details).
• A side effect of one of the performance improvements is that the members of a runtime-checkable protocol are now considered "frozen" at runtime as soon as the class has been created. Monkey-patching attributes onto a runtime-checkable protocol will still work, but will have no impact on isinstance() checks comparing objects to the protocol. See "What's New in Python 3.12" for more details.
• isinstance() checks against runtime-checkable protocols now use inspect.getattr_static() rather than hasattr() to lookup whether attributes exist (backporting python/cpython#103034).
• Backport the ability to define init methods on Protocol classes, a change made in Python 3.11 (originally implemented in python/cpython#31628
• Speedup isinstance(3, typing_extensions.SupportsIndex) by >10x on Python <3.12.
• Add typing_extensions versions of SupportsInt, SupportsFloat, SupportsComplex, SupportsBytes, SupportsAbs and SupportsRound. These have the same semantics as the versions from the typing module, but isinstance() checks against the typing_extensions versions are >10x faster at runtime on Python <3.12.
• Add orig_bases to non-generic TypedDicts, call-based TypedDicts, and call-based NamedTuples.
• Add typing_extensions.get_original_bases, a backport of types.get_original_bases, introduced in Python 3.12 (CPython PR python/cpython#101827, originally
• This function should always produce correct results when called on classes constructed using features from typing_extensions.
• Constructing a call-based TypedDict using keyword arguments for the fields now causes a DeprecationWarning to be emitted. This matches the behaviour of typing.TypedDict on 3.11 and 3.12.
• Backport the implementation of NewType from 3.10 (where it is implemented as a class rather than a function). This allows user-defined NewTypes to be pickled.
• Fix tests and import on Python 3.12, where typing.TypeVar can no longer be subclassed.
• Add typing_extensions.TypeAliasType, a backport of typing.TypeAliasType from PEP 695.
• Backport changes to the repr of typing.Unpack that were made in order to implement PEP 692 (backport of python/cpython#104048).

(From OE-Core rev: a37154b9166323d05cca970ebb37bee0d5250893)

Signed-off-by: Wang Mingyu wangmy@fujitsu.com Signed-off-by: Alexandre Belloni alexandre.belloni@bootlin.com Signed-off-by: Richard Purdie richard.purdie@linuxfoundation.org