bpo-30726: PCbuild _elementtree: remove duplicate defines by vstinner · Pull Request #2348 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation4 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

vstinner

bpo-30726, bpo-29591: libexpat 2.2.1 of Modules/expat/ now uses
a winconfig.h configuration file which already defines:

Remove these defines from PCbuild/_elementtree.vcxproj to prevent
compiler warnings.

Co-Authored-By: Jeremy Kloth jeremy.kloth@gmail.com

@vstinner @jkloth

bpo-30726, bpo-29591: libexpat 2.2.1 of Modules/expat/ now uses a winconfig.h configuration file which already defines:

Remove these defines from PCbuild/_elementtree.vcxproj to prevent compiler warnings.

Co-Authored-By: Jeremy Kloth jeremy.kloth@gmail.com

@mention-bot

@Haypo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @briancurtin and @zooba to be potential reviewers.

@segevfiner

@Haypo See: #2319.

In my PR, I didn't remove these:

But I probably should have. And I also silenced another unrelated warning.

Tell me if you want me to fix up my PR to also remove the other defines. Just remember to close whichever PR you don't merge. 😉

@vstinner

I tested manually: I confirm that this change fixes warnings about "defines" defined twice.

@bedevere-bot

@bedevere-bot

vstinner added a commit that referenced this pull request

Jun 23, 2017

@vstinner

… (#2350)

bpo-30726, bpo-29591: libexpat 2.2.1 of Modules/expat/ now uses a winconfig.h configuration file which already defines:

Remove these defines from PCbuild/_elementtree.vcxproj to prevent compiler warnings.

Co-Authored-By: Jeremy Kloth jeremy.kloth@gmail.com (cherry picked from commit c8fb58b)

Caused by usage of getenv which should be safe. And a few integer truncations which should also be ok.

(cherry picked from commit 87c6555)

vstinner added a commit that referenced this pull request

Jun 23, 2017

@vstinner

… (#2349)

bpo-30726, bpo-29591: libexpat 2.2.1 of Modules/expat/ now uses a winconfig.h configuration file which already defines:

Remove these defines from PCbuild/_elementtree.vcxproj to prevent compiler warnings.

Co-Authored-By: Jeremy Kloth jeremy.kloth@gmail.com (cherry picked from commit c8fb58b)

Caused by usage of getenv which should be safe. And a few integer truncations which should also be ok.

(cherry picked from commit 87c6555)

ned-deily pushed a commit to ned-deily/cpython that referenced this pull request

Jul 7, 2017

@vstinner @ned-deily

…on#2348) (python#2349)

bpo-30726, bpo-29591: libexpat 2.2.1 of Modules/expat/ now uses a winconfig.h configuration file which already defines:

Remove these defines from PCbuild/_elementtree.vcxproj to prevent compiler warnings.

Co-Authored-By: Jeremy Kloth jeremy.kloth@gmail.com (cherry picked from commit c8fb58b)

Caused by usage of getenv which should be safe. And a few integer truncations which should also be ok.

(cherry picked from commit 87c6555) (cherry picked from commit d32a059)

larryhastings pushed a commit that referenced this pull request

Jul 12, 2017

@vstinner @larryhastings

…2164) (#2203)

Remove the configuration (Modules/expat/*config.h) of unsupported platforms:

The XML_HAS_SET_HASH_SALT define of Modules/expat/expat.h became useless since our local expat copy was upgrade to expat 2.1 (it's now expat 2.2.0).

(cherry picked from commit 23ec4b5)

New file: Modules/expat/siphash.h. (cherry picked from commit 5ff7132)

bpo-30726, bpo-29591: libexpat 2.2.1 of Modules/expat/ now uses a winconfig.h configuration file which already defines:

Remove these defines from PCbuild/_elementtree.vcxproj to prevent compiler warnings.

Co-Authored-By: Jeremy Kloth jeremy.kloth@gmail.com (cherry picked from commit c8fb58b)

Caused by usage of getenv which should be safe. And a few integer truncations which should also be ok.

(cherry picked from commit 87c6555)

ned-deily pushed a commit that referenced this pull request

Jul 16, 2017

@vstinner @ned-deily

…2164) (#2204)

Remove the configuration (Modules/expat/*config.h) of unsupported platforms:

The XML_HAS_SET_HASH_SALT define of Modules/expat/expat.h became useless since our local expat copy was upgrade to expat 2.1 (it's now expat 2.2.0).

(cherry picked from commit 23ec4b5)

New file: Modules/expat/siphash.h. (cherry picked from commit 5ff7132)

bpo-30726, bpo-29591: libexpat 2.2.1 of Modules/expat/ now uses a winconfig.h configuration file which already defines:

Remove these defines from PCbuild/_elementtree.vcxproj to prevent compiler warnings.

Co-Authored-By: Jeremy Kloth jeremy.kloth@gmail.com (cherry picked from commit c8fb58b)

Caused by usage of getenv which should be safe. And a few integer truncations which should also be ok.

(cherry picked from commit 87c6555)