[3.6] bpo-30726: PCbuild _elementtree: remove duplicate defines (#2348) by vstinner · Pull Request #2349 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation0 Commits2 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
bpo-30726, bpo-29591: libexpat 2.2.1 of Modules/expat/ now uses
a winconfig.h configuration file which already defines:
- XML_NS
- XML_DTD
- BYTEORDER=1234
- XML_CONTEXT_BYTES=1024
- HAVE_MEMMOVE
Remove these defines from PCbuild/_elementtree.vcxproj to prevent
compiler warnings.
Co-Authored-By: Jeremy Kloth jeremy.kloth@gmail.com
(cherry picked from commit c8fb58b)
bpo-30726, bpo-29591: libexpat 2.2.1 of Modules/expat/ now uses a winconfig.h configuration file which already defines:
- XML_NS
- XML_DTD
- BYTEORDER=1234
- XML_CONTEXT_BYTES=1024
- HAVE_MEMMOVE
Remove these defines from PCbuild/_elementtree.vcxproj to prevent compiler warnings.
Co-Authored-By: Jeremy Kloth jeremy.kloth@gmail.com (cherry picked from commit c8fb58b)
- bpo-30726: Fix elementtree warnings on Windows
Caused by usage of getenv which should be safe. And a few integer
truncations which should also be ok.
- bpo-30726: Don't ignore libexpat warnings which haypo intends to fix upstream
(cherry picked from commit 87c6555)
ned-deily pushed a commit to ned-deily/cpython that referenced this pull request
- bpo-30726: PCbuild _elementtree: remove duplicate defines (python#2348)
bpo-30726, bpo-29591: libexpat 2.2.1 of Modules/expat/ now uses a winconfig.h configuration file which already defines:
- XML_NS
- XML_DTD
- BYTEORDER=1234
- XML_CONTEXT_BYTES=1024
- HAVE_MEMMOVE
Remove these defines from PCbuild/_elementtree.vcxproj to prevent compiler warnings.
Co-Authored-By: Jeremy Kloth jeremy.kloth@gmail.com (cherry picked from commit c8fb58b)
bpo-30726: Fix elementtree warnings on Windows due to expat upgrade (python#2319)
bpo-30726: Fix elementtree warnings on Windows
Caused by usage of getenv which should be safe. And a few integer
truncations which should also be ok.
- bpo-30726: Don't ignore libexpat warnings which haypo intends to fix upstream
(cherry picked from commit 87c6555) (cherry picked from commit d32a059)