Adding unit test fixes to improve compatibility with MacOS. by petyaslavova · Pull Request #3486 · redis/redis-py (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation3 Commits4 Checks35 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Pull Request check-list
Please make sure to review and check all of these items:
- Do tests and lints pass with this change?
- Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
- Is the new or changed code fully tested?
- Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
- Is there an example added to the examples folder (if applicable)?
- Was the change added to CHANGES file?
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Adding unit text fixes to improve compatibility with MacOS.
Adding unit text fixes to improve compatibility with MacOS. Adding unit test fixes to improve compatibility with MacOS.
vladvildanov added a commit that referenced this pull request
Adding unit text fixes to improve compatibility with MacOS.
Applying review comments
Unifying the exception msg validation pattern for both test_connection.py files
Co-authored-by: Vladyslav Vildanov 117659936+vladvildanov@users.noreply.github.com
vladvildanov added a commit that referenced this pull request
Fixed flacky TokenManager test (#3468)
Fixed flacky TokenManager test
Fixed additional flacky test
Removed token count assertion
Skipped test on version 3.9
Fix incorrect attribute reuse (#3456)
add CacheEntry
Co-authored-by: zhousheng06 zhousheng06@meituan.com Co-authored-by: Vladyslav Vildanov 117659936+vladvildanov@users.noreply.github.com
- Expand type for EncodedT (#3472)
As of PEP 688, type checkers will no longer implicitly consider bytearray to be compatible with bytes
Moved self._lock initialisation to Pool constructor (#3473)
Moved self._lock initialisation to Pool constructor
Added test case
Codestyle fixes
Added correct annotations
DOC-4423: add TCEs for various command pages (#3476)
Co-authored-by: Vladyslav Vildanov 117659936+vladvildanov@users.noreply.github.com
DOC-4345 added testable JSON search examples for home page (#3407)
DOC-4345 added testable JSON search examples for home page
DOC-4345 avoid possible non-deterministic results in tests
DOC-4345 close connection at end of example
DOC-4345 remove unnecessary blank lines
Adding unit text fixes to improve compatibility with MacOS. (#3486)
Adding unit text fixes to improve compatibility with MacOS.
Applying review comments
Unifying the exception msg validation pattern for both test_connection.py files
Co-authored-by: Vladyslav Vildanov 117659936+vladvildanov@users.noreply.github.com
Co-authored-by: Vladyslav Vildanov 117659936+vladvildanov@users.noreply.github.com
- Add types to execute method of pipelines (#3494)
Co-authored-by: Vladyslav Vildanov 117659936+vladvildanov@users.noreply.github.com
- DOC-4796 fixed capped lists example (#3493)
Co-authored-by: Vladyslav Vildanov 117659936+vladvildanov@users.noreply.github.com
typing for client init (#3357)
typing for client init
typing with string literals
retry_on_error more specific typing
retry typing
fix lint
Co-authored-by: Vladyslav Vildanov 117659936+vladvildanov@users.noreply.github.com
test: Updated CredentialProvider test infrastructure (#3502)
test: Updated CredentialProvider test infrastructure
Added linter exclusion
Updated dev dependency
Codestyle fixes
Updated async test infra
Added missing constant
Updated package version
Updated testing versions and docs
Updated server versions
Fixed test
Co-authored-by: zs-neo 48560952+zs-neo@users.noreply.github.com Co-authored-by: zhousheng06 zhousheng06@meituan.com Co-authored-by: Shantanu 12621235+hauntsaninja@users.noreply.github.com Co-authored-by: David Dougherty dwdougherty@gmail.com Co-authored-by: andy-stark-redis 164213578+andy-stark-redis@users.noreply.github.com Co-authored-by: petyaslavova petya.slavova@redis.com Co-authored-by: Patrick Arminio patrick.arminio@gmail.com Co-authored-by: Artur Mostowski artur.mostowski@protonmail.com
2 participants
