Tracking Issue for RFC 3373: Avoid non-local definitions in functions · Issue #120363 · rust-lang/rust (original) (raw)

Skip to content

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

@traviscross

Description

@traviscross

This is a tracking issue for the RFC 3373: Avoid non-local definitions in functions (rust-lang/rfcs#3373).

Summary

Add a warn-by-default lint for items inside functions or expressions that implement methods or traits that are visible outside the function or expression.

warning: non-local impl definition, they should be avoided as they go against expectation --> src/de/impls.rs:21:9 | 21 | / impl Visitor for Place<()> { 22 | | fn null(&mut self) -> Result<()> { 23 | | self.out = Some(()); 24 | | Ok(()) 25 | | } 26 | | } | |_________^ | = help: move this impl block outside the of the current associated function begin = note: an impl definition is non-local if it is nested inside an item and neither the type nor the trait are at the same nesting level as the impl block = note: one exception to the rule are anon-const (const _: () = { ... }) at top-level module and anon-const at the same nesting as the trait or type = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue https://github.com/rust-lang/rust/issues/120363 = note: #[warn(non_local_definitions)] on by default

About tracking issues

Tracking issues are used to record the overall progress of implementation. They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions. A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature. Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Steps

Unresolved questions