Switch back `non_local_definitions` lint to allow-by-default by Urgau · Pull Request #127015 · rust-lang/rust (original) (raw)

What’s the PR that made this specific case warn? Was it #120393 as that landed 2 releases ago. If so, we could also nominate for a stable backport in case a point release happens.

yes it was #120393 but since then the implementation was already changed and improved quite a bit, leading to the lint not currently being warn-by-default in any stable releases, one can check that by looking at the current allow-by-default list of current stable

📌 Commit 0c0dfb8 has been approved by lqd

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Noratrieb removed the T-rustdoc

Relevant to the rustdoc team, which will review and decide on the PR/issue.

label

leading to the lint not currently being warn-by-default in any stable releases

To make the backport request a bit clearer to people, could you list how? The lint was made warn-by-default in 2f2d5cc so this PR basically reverts that, was it not registered as a lint or what else did not make it the default when that landed in 1.79?

So the PR causing #126768 is not only #120393 but some combination with #122747 and unknown others that are only on beta right now, and this PR will effectively prevent that from landing on stable.

it was put back to allow-by-default in #125183 for 1.79, but left as warn-by-default in 1.80, this PR would make it allow in 1.81 and the backport would make it allow in 1.80

So the PR causing #126768 is not only #120393 but some combination with #122747 and unknown others that are only on beta right now, and this PR will effectively prevent that from landing on stable.

not really, we improved the rules with #122747 but the "root" cause is still the original impl #126768

So to answer the question of how we don't have problems on stable is because cfae8b2 prevented the lint from being enabled there, despite being warn-by-default on master. This is clearer, thank you.

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request

Switch back non_local_definitions lint to allow-by-default

This PR switch back (again) the non_local_definitions lint to allow-by-default as T-lang is requesting some (major) changes in the lint inner workings in rust-lang#126768 (comment).

This PR will need to be beta-backported, as the lint is currently warn-by-default in beta.

bors added a commit to rust-lang-ci/rust that referenced this pull request

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Switch back non_local_definitions lint to allow-by-default

This PR switch back (again) the non_local_definitions lint to allow-by-default as T-lang is requesting some (major) changes in the lint inner workings in rust-lang#126768 (comment).

This PR will need to be beta-backported, as the lint is currently warn-by-default in beta.

bors added a commit to rust-lang-ci/rust that referenced this pull request

jhpratt added a commit to jhpratt/rust that referenced this pull request

Switch back non_local_definitions lint to allow-by-default

This PR switch back (again) the non_local_definitions lint to allow-by-default as T-lang is requesting some (major) changes in the lint inner workings in rust-lang#126768 (comment).

This PR will need to be beta-backported, as the lint is currently warn-by-default in beta.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Switch back non_local_definitions lint to allow-by-default

This PR switch back (again) the non_local_definitions lint to allow-by-default as T-lang is requesting some (major) changes in the lint inner workings in rust-lang#126768 (comment).

This PR will need to be beta-backported, as the lint is currently warn-by-default in beta.

bors added a commit to rust-lang-ci/rust that referenced this pull request

bors added a commit to rust-lang-ci/rust that referenced this pull request

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request

Switch back non_local_definitions lint to allow-by-default

This PR switch back (again) the non_local_definitions lint to allow-by-default as T-lang is requesting some (major) changes in the lint inner workings in rust-lang#126768 (comment).

This PR will need to be beta-backported, as the lint is currently warn-by-default in beta.

bors added a commit to rust-lang-ci/rust that referenced this pull request

bors added a commit to rust-lang-ci/rust that referenced this pull request

…llaumeGomez

Rollup of 10 pull requests

Successful merges:

rust-lang#123714 (Add test for fn pointer duplication.)
rust-lang#124091 (Update AST validation module docs)
rust-lang#126963 (Add basic Serde serialization capabilities to Stable MIR)
rust-lang#127015 (Switch back non_local_definitions lint to allow-by-default)
rust-lang#127016 (docs: check if the disambiguator matches its suffix)
rust-lang#127029 (Fix Markdown tables in platform-support.md)
rust-lang#127032 (Enable const casting for f16 and f128)
rust-lang#127041 (Migrate run-make/override-aliased-flags to rmake.rs)
rust-lang#127045 (Rename super_predicates_of and similar queries to explicit_* to note that they're not elaborated)
rust-lang#127075 (rustc_data_structures: Explicitly check for 64-bit atomics support)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

bors added a commit to rust-lang-ci/rust that referenced this pull request

…iaskrgr

Rollup of 11 pull requests

Successful merges:

rust-lang#123714 (Add test for fn pointer duplication.)
rust-lang#124091 (Update AST validation module docs)
rust-lang#127015 (Switch back non_local_definitions lint to allow-by-default)
rust-lang#127016 (docs: check if the disambiguator matches its suffix)
rust-lang#127029 (Fix Markdown tables in platform-support.md)
rust-lang#127032 (Enable const casting for f16 and f128)
rust-lang#127055 (Mark Hasher::finish as #[must_use])
rust-lang#127068 (Stall computing instance for drop shim until it has no unsubstituted const params)
rust-lang#127070 (add () to the marker_impls macro for ConstParamTy)
rust-lang#127071 (Remove (deprecated & unstable) {to,from}_bits pointer methods)
rust-lang#127078 (Enable full tools and profiler for LoongArch Linux targets)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 29, 2024

…iaskrgr

Rollup of 11 pull requests

Successful merges:

rust-lang#123714 (Add test for fn pointer duplication.)
rust-lang#124091 (Update AST validation module docs)
rust-lang#127015 (Switch back non_local_definitions lint to allow-by-default)
rust-lang#127016 (docs: check if the disambiguator matches its suffix)
rust-lang#127029 (Fix Markdown tables in platform-support.md)
rust-lang#127032 (Enable const casting for f16 and f128)
rust-lang#127055 (Mark Hasher::finish as #[must_use])
rust-lang#127068 (Stall computing instance for drop shim until it has no unsubstituted const params)
rust-lang#127070 (add () to the marker_impls macro for ConstParamTy)
rust-lang#127071 (Remove (deprecated & unstable) {to,from}_bits pointer methods)
rust-lang#127078 (Enable full tools and profiler for LoongArch Linux targets)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 29, 2024

…iaskrgr

Rollup of 11 pull requests

Successful merges:

rust-lang#123714 (Add test for fn pointer duplication.)
rust-lang#124091 (Update AST validation module docs)
rust-lang#127015 (Switch back non_local_definitions lint to allow-by-default)
rust-lang#127016 (docs: check if the disambiguator matches its suffix)
rust-lang#127029 (Fix Markdown tables in platform-support.md)
rust-lang#127032 (Enable const casting for f16 and f128)
rust-lang#127055 (Mark Hasher::finish as #[must_use])
rust-lang#127068 (Stall computing instance for drop shim until it has no unsubstituted const params)
rust-lang#127070 (add () to the marker_impls macro for ConstParamTy)
rust-lang#127071 (Remove (deprecated & unstable) {to,from}_bits pointer methods)
rust-lang#127078 (Enable full tools and profiler for LoongArch Linux targets)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Jun 29, 2024

Rollup merge of rust-lang#127015 - Urgau:non_local_def-tmp-allow, r=lqd

Switch back non_local_definitions lint to allow-by-default

This PR switch back (again) the non_local_definitions lint to allow-by-default as T-lang is requesting some (major) changes in the lint inner workings in rust-lang#126768 (comment).

This PR will need to be beta-backported, as the lint is currently warn-by-default in beta.

Beta backport accepted as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle.

@rustbot label +beta-accepted

bors added a commit to rust-lang-ci/rust that referenced this pull request

bors added a commit to rust-lang-ci/rust that referenced this pull request

bors added a commit to rust-lang-ci/rust that referenced this pull request

bors added a commit to rust-lang-ci/rust that referenced this pull request