Revert "Mention rust-analyzer maintainers when proc_macro
bridge is changed" by jonas-schievink · Pull Request #101418 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation4 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Reverts #99183
rust-analyzer is now a subtree, and CI fails when the proc_macro
bridge changes break our tests, so these notifications aren't needed anymore.
(rust-highfive has picked a reviewer for you, use r? to override)
📌 Commit f5cd223 has been approved by Mark-Simulacrum
It is now in the queue for this repository.
bors added S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
cc @rust-lang/wg-rls-2 for visibility
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…mention-r-a, r=Mark-Simulacrum
Revert "Mention rust-analyzer maintainers when proc_macro
bridge is changed"
Reverts rust-lang#99183
rust-analyzer is now a subtree, and CI fails when the proc_macro
bridge changes break our tests, so these notifications aren't needed anymore.
JohnTitor added a commit to JohnTitor/rust that referenced this pull request
…mention-r-a, r=Mark-Simulacrum
Revert "Mention rust-analyzer maintainers when proc_macro
bridge is changed"
Reverts rust-lang#99183
rust-analyzer is now a subtree, and CI fails when the proc_macro
bridge changes break our tests, so these notifications aren't needed anymore.
This was referenced
Sep 5, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 7 pull requests
Successful merges:
- rust-lang#99291 (Add let else drop order tests)
- rust-lang#101402 (Add a Machine hook for inline assembly)
- rust-lang#101404 (Fix cleanup for uninitialized stdout)
- rust-lang#101418 (Revert "Mention rust-analyzer maintainers when
proc_macro
bridge is changed") - rust-lang#101425 (Point at type parameter in plain path expr)
- rust-lang#101426 (Don't duplicate file descriptors into stdio fds)
- rust-lang#101447 (Remove generics_def_id_map from the resolver.)
Failed merges:
r? @ghost
@rustbot
modify labels: rollup
bors deleted the revert-99183-proc_macro-mention-r-a branch
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.