Resolve async fn signature even without body (e.g., in trait) by compiler-errors · Pull Request #102161 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation15 Commits3 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Fixes #102138
This "bail if no body" behavior was introduced in #69539 to fix #69401, but that ICE does not reproduce any more. The error message changes a bit, but that's all, and I don't think it's a particularly diagnostic bad regression.
Relevant to the compiler team, which will review and decide on the PR/issue.
label
r? @davidtwco
(rust-highfive has picked a reviewer for you, use r? to override)
Ugh, actually this passes now and might not after the changes:
fn main() {}
trait Foo { fn fn_with_type_named_same_as_local_in_param(b: i32, b: i32); }
Let me see if I can avoid this.
Okay, fixed that bug by just doing the only part of resolve that we need for AFIT.
📌 Commit 271a0680197e08405c67dd0b4d4bac87ea9a28bc has been approved by tmandry
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Ugh, actually this passes now and might not after the changes:
Actually, want to add a test for this? (and r=me)
Not sure it's the behavior I would want, but it's too late for that anyway :)
@bors r-
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
📌 Commit e87fcc0 has been approved by tmandry
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…andry
Resolve async fn signature even without body (e.g., in trait)
Fixes rust-lang#102138
This "bail if no body" behavior was introduced in rust-lang#69539 to fix rust-lang#69401, but that ICE does not reproduce any more. The error message changes a bit, but that's all, and I don't think it's a particularly diagnostic bad regression.
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 5 pull requests
Successful merges:
- rust-lang#102016 (implied_bounds: deal with inference vars)
- rust-lang#102161 (Resolve async fn signature even without body (e.g., in trait))
- rust-lang#102216 (rustdoc: Stabilize --diagnostic-width)
- rust-lang#102240 (rustdoc: remove unused CSS
#main-content > .line-numbers) - rust-lang#102242 (rustdoc: remove unused CSS
.summary)
Failed merges:
r? @ghost
@rustbot modify labels: rollup