late resolve, visit_fn: bail early if there's no body. by Centril · Pull Request #69539 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation2 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
📌 Commit 85b585d has been approved by petrochenkov
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request
bors added a commit that referenced this pull request
Rollup of 10 pull requests
Successful merges:
- #68989 (Update RELEASES.md for 1.42.0)
- #69340 (instantiate_value_path: on
SelfCtor, avoid unconstrained tyvars) - #69384 (parser:
token->normalized_token,nonnormalized_token->token) - #69452 (typeck: use
Patternobligation cause more for better diagnostics) - #69481 (use char instead of &str for single char patterns)
- #69522 (error_derive_forbidden_on_non_adt: be more graceful)
- #69538 (Stabilize
boxed_slice_try_from) - #69539 (late resolve, visit_fn: bail early if there's no body.)
- #69541 (Remove unneeded calls to format!())
- #69547 (remove redundant clones, references to operands, explicit boolean comparisons and filter(x).next() calls.)
Failed merges:
r? @ghost
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…andry
Resolve async fn signature even without body (e.g., in trait)
Fixes rust-lang#102138
This "bail if no body" behavior was introduced in rust-lang#69539 to fix rust-lang#69401, but that ICE does not reproduce any more. The error message changes a bit, but that's all, and I don't think it's a particularly diagnostic bad regression.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…andry
Resolve async fn signature even without body (e.g., in trait)
Fixes rust-lang#102138
This "bail if no body" behavior was introduced in rust-lang#69539 to fix rust-lang#69401, but that ICE does not reproduce any more. The error message changes a bit, but that's all, and I don't think it's a particularly diagnostic bad regression.
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.