Fix warning when libcore is compiled with no_fp_fmt_parse by nbdd0121 · Pull Request #105434 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation7 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Discovered when trying to compile Rust-for-Linux with Rust 1.66 beta.
It'll be helpful if this is backported to beta (should be trivial enough for backporting), so Rust-for-Linux's rust version bump wouldn't need to do --cap-lints allow for libcore.
r? @thomcc
(rustbot has picked a reviewer for you, use r? to override)
Status: Awaiting review from the assignee but also interested parties.
Relevant to the library team, which will review and decide on the PR/issue.
labels
Hey! It looks like you've submitted a new PR for the library teams!
If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.
Examples of T-libs-api changes:
- Stabilizing library features
- Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
- Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
- Changing public documentation in ways that create new stability guarantees
- Changing observable runtime behavior of library APIs
📌 Commit a3c4c2e has been approved by thomcc
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
It'll be helpful if this is backported to beta (should be trivial enough for backporting), so Rust-for-Linux's rust version bump wouldn't need to do
--cap-lints allowfor libcore.
I've marked it as nominated for beta backport, although I'm probably opposed -- I don't really like the thought that these configurations are considered so important that a beta-backport is justified for a warning (and if they are that important, we should check them in CI). But I don't feel that strongly.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
Fix warning when libcore is compiled with no_fp_fmt_parse
Discovered when trying to compile Rust-for-Linux with Rust 1.66 beta.
It'll be helpful if this is backported to beta (should be trivial enough for backporting), so Rust-for-Linux's rust version bump wouldn't need to do --cap-lints allow for libcore.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
Fix warning when libcore is compiled with no_fp_fmt_parse
Discovered when trying to compile Rust-for-Linux with Rust 1.66 beta.
It'll be helpful if this is backported to beta (should be trivial enough for backporting), so Rust-for-Linux's rust version bump wouldn't need to do --cap-lints allow for libcore.
if they are that important, we should check them in CI
There is indeed a test to verify that libcore can compile with this custom cfg (but it doesn't currently use -Dwarnings).
bors added a commit to rust-lang-ci/rust that referenced this pull request
16 tasks
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request
Fix warning when libcore is compiled with no_fp_fmt_parse
Discovered when trying to compile Rust-for-Linux with Rust 1.66 beta.
It'll be helpful if this is backported to beta (should be trivial enough for backporting), so Rust-for-Linux's rust version bump wouldn't need to do --cap-lints allow for libcore.
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request
y86-dev pushed a commit to y86-dev/linux that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
vvarma pushed a commit to vvarma/rusty-linux that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
asahilina pushed a commit to AsahiLinux/linux that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
asahilina pushed a commit to AsahiLinux/linux that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
mairacanal pushed a commit to mairacanal/linux that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
jannau pushed a commit to jannau/linux that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
jannau pushed a commit to jannau/linux that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
eaxeax pushed a commit to eaxeax/asahi-linux-pf that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
WhatAmISupposedToPutHere pushed a commit to WhatAmISupposedToPutHere/linux that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
asahilina pushed a commit to AsahiLinux/linux that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
asahilina pushed a commit to AsahiLinux/linux that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
Kaz205 pushed a commit to Kaz205/linux that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
herrnst pushed a commit to herrnst/linux-asahi that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux/linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
herrnst pushed a commit to herrnst/linux-asahi that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux/linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
herrnst pushed a commit to herrnst/linux-asahi that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux/linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
herrnst pushed a commit to herrnst/linux-asahi that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux/linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
herrnst pushed a commit to herrnst/linux-asahi that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux/linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
herrnst pushed a commit to herrnst/linux-asahi that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux/linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
herrnst pushed a commit to herrnst/linux-asahi that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux/linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
herrnst pushed a commit to herrnst/linux-asahi that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux/linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
herrnst pushed a commit to herrnst/linux-asahi that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux/linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
herrnst pushed a commit to herrnst/linux-asahi that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux/linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
herrnst pushed a commit to herrnst/linux-asahi that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux/linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
herrnst pushed a commit to herrnst/linux-asahi that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux/linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
herrnst pushed a commit to herrnst/linux-asahi that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux/linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
Kaz205 pushed a commit to Kaz205/linux that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
kkpan11 pushed a commit to kkpan11/AsahiLinux-linux that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux/linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the library team, which will review and decide on the PR/issue.