core: ensure no_fp_fmt_parse builds are warning-free by ojeda · Pull Request #105811 · rust-lang/rust (original) (raw)
Rust recently introduced a new unused_imports warning in no_fp_fmt_parse builds, which was fixed in
#105434.
To avoid accumulating more over time, let's keep the builds warning-free. This ensures projects compiling core with this custom config do not see the warnings in the future and that they can keep enabling -Dwarnings.
Similarly, #98652 did it for alloc's no_global_oom_handling.
Rust recently introduced a new unused_imports warning
in no_fp_fmt_parse builds, which was fixed in
rust-lang#105434.
To avoid accumulating more over time, let's keep the builds
warning-free. This ensures projects compiling core with
this custom config do not see the warnings in the future
and that they can keep enabling -Dwarnings.
Similarly, rust-lang#98652 did it
for alloc's no_global_oom_handling.
Signed-off-by: Miguel Ojeda ojeda@kernel.org
This was referenced
Dec 17, 2022
📌 Commit af7f222 has been approved by Mark-Simulacrum
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Finished benchmarking commit (74699b8): comparison URL.
Overall result: no relevant changes - no action needed
@rustbot label: -perf-regression
Instruction count
This benchmark run did not return any relevant results for this metric.
Max RSS (memory usage)
Results
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | - | - | 0 |
| Regressions ❌ (secondary) | 2.9% | [2.2%, 4.5%] | 3 |
| Improvements ✅ (primary) | - | - | 0 |
| Improvements ✅ (secondary) | -2.8% | [-2.9%, -2.7%] | 2 |
| All ❌✅ (primary) | - | - | 0 |
Cycles
This benchmark run did not return any relevant results for this metric.
y86-dev pushed a commit to y86-dev/linux that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
vvarma pushed a commit to vvarma/rusty-linux that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
asahilina pushed a commit to AsahiLinux/linux that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
asahilina pushed a commit to AsahiLinux/linux that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
mairacanal pushed a commit to mairacanal/linux that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
jannau pushed a commit to jannau/linux that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
jannau pushed a commit to jannau/linux that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
eaxeax pushed a commit to eaxeax/asahi-linux-pf that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
WhatAmISupposedToPutHere pushed a commit to WhatAmISupposedToPutHere/linux that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
asahilina pushed a commit to AsahiLinux/linux that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
asahilina pushed a commit to AsahiLinux/linux that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
Kaz205 pushed a commit to Kaz205/linux that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
herrnst pushed a commit to herrnst/linux-asahi that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux/linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
herrnst pushed a commit to herrnst/linux-asahi that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux/linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
herrnst pushed a commit to herrnst/linux-asahi that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux/linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
herrnst pushed a commit to herrnst/linux-asahi that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux/linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
herrnst pushed a commit to herrnst/linux-asahi that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux/linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
herrnst pushed a commit to herrnst/linux-asahi that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux/linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
herrnst pushed a commit to herrnst/linux-asahi that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux/linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
herrnst pushed a commit to herrnst/linux-asahi that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux/linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
herrnst pushed a commit to herrnst/linux-asahi that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux/linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
herrnst pushed a commit to herrnst/linux-asahi that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux/linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
herrnst pushed a commit to herrnst/linux-asahi that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux/linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
herrnst pushed a commit to herrnst/linux-asahi that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux/linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
herrnst pushed a commit to herrnst/linux-asahi that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux/linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
Kaz205 pushed a commit to Kaz205/linux that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org
kkpan11 pushed a commit to kkpan11/AsahiLinux-linux that referenced this pull request
Upgrade the Rust version from 1.62.0 to 1.66.0.
The overwhelming majority of the commit is about upgrading our alloc
fork to the new version from upstream [1]. License has not changed [2][3]
(there were changes in the COPYRIGHT file, but unrelated to alloc).
As in the previous version upgrades (done out of tree so far), upgrading
alloc requires checking that our small additions (try_*) still match
their original (non-try_*) versions.
With this version upgrade, the following unstable Rust features were
stabilized: bench_black_box (1.66.0), const_ptr_offset_from (1.65.0),
core_ffi_c (1.64.0) and generic_associated_types (1.65.0). Thus
remove them.
This also implies that only two unstable features remain allowed for
non-rust/ code: allocator_api and const_refs_to_cell.
There are some new Clippy warnings that we are triggering (i.e. introduced since 1.62.0), as well as a few others that were not triggered before, thus allow them in this commit and clean up or remove them as needed later on:
borrow_deref_ref(new in 1.63.0).explicit_auto_deref(new in 1.64.0).bool_to_int_with_if(new in 1.65.0).needless_borrow.type_complexity.unnecessary_cast(allowed only onCONFIG_ARM).
Furthermore, rustdoc lint broken_intra_doc_links is triggering on
links pointing to macro_export macro_rules defined in the same
module (i.e. appearing in the crate root).
However, even if the warning appears, the link still gets generated like in previous versions, thus it is a bit confusing. An issue has been opened upstream [4], and it appears that the link still being generated was a compatibility measure, thus we will need to adapt to the new behavior (done in the next patch).
In addition, there is an added #[const_trait] attribute in
RawDeviceId, due to 1.66.0's PR "Require #[const_trait] on Trait
for impl const Trait") [5].
Finally, the -Aunused-imports was added for compiling core. This was
fixed upstream for 1.67.0 in PR "Fix warning when libcore is compiled
with no_fp_fmt_parse" [6], and prevented for the future for that cfg
in PR "core: ensure no_fp_fmt_parse builds are warning-free" [7].
Reviewed-by: Björn Roy Baron bjorn3_gh@protonmail.com Reviewed-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Tested-by: Martin Rodriguez Reboredo yakoyoku@gmail.com Reviewed-by: Gary Guo gary@garyguo.net Reviewed-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com Reviewed-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Tested-by: Alice Ferrazzi alice.ferrazzi@miraclelinux.com Reviewed-by: Neal Gompa neal@gompa.dev Tested-by: Neal Gompa neal@gompa.dev Link: Rust-for-Linux/linux#947 Link: https://github.com/rust-lang/rust/tree/1.66.0/library/alloc/src [1] Link: https://github.com/rust-lang/rust/blob/1.66.0/library/alloc/Cargo.toml#L4 [2] Link: https://github.com/rust-lang/rust/blob/1.66.0/COPYRIGHT [3] Link: rust-lang/rust#106142 [4] Link: rust-lang/rust#100982 [5] Link: rust-lang/rust#105434 [6] Link: rust-lang/rust#105811 [7] Signed-off-by: Miguel Ojeda ojeda@kernel.org