Fix closure-inherit-target-feature test for SGX platform by raoulstrackx · Pull Request #117082 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation4 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
PR #116078 adds the closure-inherit-target-feature.rs test that checks the generated assembly code for closures. These checks explicitly check the presence of ret instructions. This is incompatible with the SGX target as it explicitly rewrites all ret instructions to mitigate LVI vulnerabilities of certain processors. This PR simply ignores these tests for the SGX platform.
cc: @jethrogb
📌 Commit c094ba0 has been approved by Mark-Simulacrum
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request
…_target_feature_sgx, r=Mark-Simulacrum
Fix closure-inherit-target-feature test for SGX platform
PR rust-lang#116078 adds the closure-inherit-target-feature.rs test that checks the generated assembly code for closures. These checks explicitly check the presence of ret instructions. This is incompatible with the SGX target as it explicitly rewrites all ret instructions to mitigate LVI vulnerabilities of certain processors. This PR simply ignores these tests for the SGX platform.
cc: @jethrogb
bors added a commit to rust-lang-ci/rust that referenced this pull request
…kingjubilee
Rollup of 5 pull requests
Successful merges:
- rust-lang#115968 (Don't use LFS64 symbols on musl)
- rust-lang#117043 (add bootstrap flag
--skip-stage0-validation) - rust-lang#117082 (Fix closure-inherit-target-feature test for SGX platform)
- rust-lang#117312 (memcpy assumptions: link to source showing that GCC makes the same assumption)
- rust-lang#117328 (pass
CODEGEN_BACKENDSto docker)
r? @ghost
@rustbot modify labels: rollup
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request
…_target_feature_sgx, r=Mark-Simulacrum
Fix closure-inherit-target-feature test for SGX platform
PR rust-lang#116078 adds the closure-inherit-target-feature.rs test that checks the generated assembly code for closures. These checks explicitly check the presence of ret instructions. This is incompatible with the SGX target as it explicitly rewrites all ret instructions to mitigate LVI vulnerabilities of certain processors. This PR simply ignores these tests for the SGX platform.
cc: @jethrogb
This was referenced
Oct 29, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request
…llaumeGomez
Rollup of 5 pull requests
Successful merges:
- rust-lang#115968 (Don't use LFS64 symbols on musl)
- rust-lang#117043 (add bootstrap flag
--skip-stage0-validation) - rust-lang#117082 (Fix closure-inherit-target-feature test for SGX platform)
- rust-lang#117312 (memcpy assumptions: link to source showing that GCC makes the same assumption)
- rust-lang#117337 (rustdoc: Use
ThinVecinGenericParamDefKind)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#117082 - fortanix:raoul/fix_closure_inherit_target_feature_sgx, r=Mark-Simulacrum
Fix closure-inherit-target-feature test for SGX platform
PR rust-lang#116078 adds the closure-inherit-target-feature.rs test that checks the generated assembly code for closures. These checks explicitly check the presence of ret instructions. This is incompatible with the SGX target as it explicitly rewrites all ret instructions to mitigate LVI vulnerabilities of certain processors. This PR simply ignores these tests for the SGX platform.
cc: @jethrogb
bors-ferrocene bot added a commit to ferrocene/ferrocene that referenced this pull request
bors-ferrocene bot added a commit to ferrocene/ferrocene that referenced this pull request
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.