pass CODEGEN_BACKENDS to docker by lqd · Pull Request #117328 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation26 Commits3 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Member
• Loading
The backends to build are now defined in the CODEGEN_BACKENDS env var. It's correctly set in CI, but wasn't passed to docker, hence cg_clif wasn't actually built in #81746.
r? @Kobzol: I locally tried CODEGEN_BACKENDS="cranelift" DEPLOY=1 src/ci/docker/run.sh dist-x86_64-linux and this change was enough for ci/run.sh to read the env var.
So I'll try as-is and we'll see.
Area: The testsuite used to check the correctness of rustc
Status: Awaiting review from the assignee but also interested parties.
Relevant to the infrastructure team, which will review and decide on the PR/issue.
labels
bors added a commit to rust-lang-ci/rust that referenced this pull request
pass CODEGEN_BACKENDS to docker
The backends to build are now defined in the CODEGEN_BACKENDS env var. It's correctly set in CI, but wasn't passed to docker, hence cg_clif wasn't actually built in rust-lang#81746.
r? @Kobzol: I locally tried CODEGEN_BACKENDS="cranelift" DEPLOY=1 src/ci/docker/run.sh dist-x86_64-linux and this change was enough for ci/run.sh to read the env var. However, we can also see people doing both --env DEPLOY as-is and --env BASE_COMMIT="$BASE_COMMIT" \ and I wonder why, do you know?
So I'll try as-is and we'll see.
(Opened as draft for your feedback, and for me to get a try build going and look at the artifacts)
Either generate it with the actual codegen backend dylib or omit it entirely when the cranelift backend is disabled for this build.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
label
(The logs show the cg_clif backend as being built this time)
It's starting to look good IMHO. I'll mark this "ready to review" if jakub wants to take a look, but I will still look for the PR builder and test the try build component when/if it's available.
Member Author
lqd commented
• Loading
Member Author
lqd commented
• Loading
The bot hasn't posted yet but the try build is done, and works. (Note it was done on the first commit only, but the PR builder worked with both commits)
$ find ~/.rustup/toolchains/72df36e74f2c2df78b3e8802b13aa34540bbf7a2 -name "*cranelift*.so"
/home/lqd/.rustup/toolchains/72df36e74f2c2df78b3e8802b13aa34540bbf7a2/lib/rustlib/x86_64-unknown-linux-gnu/codegen-backends/librustc_codegen_cranelift-1.75.0-nightly.so
$ rustup-toolchain-install-master 72df36e74f2c2df78b3e8802b13aa34540bbf7a2 -c rustc-codegen-cranelift && CARGO_PROFILE_DEV_CODEGEN_BACKEND=cranelift cargo +72df36e74f2c2df78b3e8802b13aa34540bbf7a2 run -q
Hello, world!
(also tested via Cargo.toml changes, not just the env var)
📌 Commit aefd7ac has been approved by Mark-Simulacrum
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request
…acrum
pass CODEGEN_BACKENDS to docker
The backends to build are now defined in the CODEGEN_BACKENDS env var. It's correctly set in CI, but wasn't passed to docker, hence cg_clif wasn't actually built in rust-lang#81746.
r? @Kobzol: I locally tried CODEGEN_BACKENDS="cranelift" DEPLOY=1 src/ci/docker/run.sh dist-x86_64-linux and this change was enough for ci/run.sh to read the env var.
So I'll try as-is and we'll see.
bors added a commit to rust-lang-ci/rust that referenced this pull request
…kingjubilee
Rollup of 5 pull requests
Successful merges:
- rust-lang#115968 (Don't use LFS64 symbols on musl)
- rust-lang#117043 (add bootstrap flag
--skip-stage0-validation) - rust-lang#117082 (Fix closure-inherit-target-feature test for SGX platform)
- rust-lang#117312 (memcpy assumptions: link to source showing that GCC makes the same assumption)
- rust-lang#117328 (pass
CODEGEN_BACKENDSto docker)
r? @ghost
@rustbot modify labels: rollup
Failed in #117339
assertion failed: found_backend
@bors rollup=iffy
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request
…acrum
pass CODEGEN_BACKENDS to docker
The backends to build are now defined in the CODEGEN_BACKENDS env var. It's correctly set in CI, but wasn't passed to docker, hence cg_clif wasn't actually built in rust-lang#81746.
r? @Kobzol: I locally tried CODEGEN_BACKENDS="cranelift" DEPLOY=1 src/ci/docker/run.sh dist-x86_64-linux and this change was enough for ci/run.sh to read the env var.
So I'll try as-is and we'll see.
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
The job aarch64-gnu failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)
[RUSTC-TIMING] serde_json test:false 1.817
Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
##[group]Clock drift check
##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
network time: Mon, 30 Oct 2023 00:01:53 GMT
##[endgroup]
##[endgroup]
Session terminated, killing shell...[RUSTC-TIMING] tidy test:false 4.044
...killed.
##[error]The operation was canceled.
@bors retry The runner has received a shutdown signal
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Finished benchmarking commit (1dfb6b1): comparison URL.
Overall result: no relevant changes - no action needed
@rustbot label: -perf-regression
Instruction count
This benchmark run did not return any relevant results for this metric.
Max RSS (memory usage)
Results
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | 2.3% | [2.3%, 2.3%] | 1 |
| Regressions ❌ (secondary) | - | - | 0 |
| Improvements ✅ (primary) | - | - | 0 |
| Improvements ✅ (secondary) | - | - | 0 |
| All ❌✅ (primary) | 2.3% | [2.3%, 2.3%] | 1 |
Cycles
Results
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | - | - | 0 |
| Regressions ❌ (secondary) | 3.0% | [3.0%, 3.0%] | 1 |
| Improvements ✅ (primary) | - | - | 0 |
| Improvements ✅ (secondary) | - | - | 0 |
| All ❌✅ (primary) | - | - | 0 |
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 635.477s -> 635.247s (-0.04%)
Artifact size: 304.44 MiB -> 304.45 MiB (0.00%)
bors-ferrocene bot added a commit to ferrocene/ferrocene that referenced this pull request
bors-ferrocene bot added a commit to ferrocene/ferrocene that referenced this pull request
RalfJung added a commit to RalfJung/rust that referenced this pull request
…-Simulacrum"
This reverts commit 1dfb6b1, reversing changes made to bcb5798.
That commit broke generating nightly rustc docs. Revert it until we can figure out how to have both, cranelift and docs.
bors added a commit to rust-lang-ci/rust that referenced this pull request
Revert "Auto merge of rust-lang#117328 - lqd:cranelift-rocket, r=Mark-Simulacrum"
This reverts commit 1dfb6b1, reversing changes made to bcb5798.
That commit broke generating nightly rustc docs. Revert it until we can figure out how to have both, cranelift and docs.
Fixes rust-lang#117430
Unfortunately, this caused #117430 (probably surfacing some pre-existing issue in how docs generation interacts with codegen backend builds), so it is being reverted in #117535.
bors added a commit to rust-lang-ci/rust that referenced this pull request
Revert "Auto merge of rust-lang#117328 - lqd:cranelift-rocket, r=Mark-Simulacrum"
This reverts commit 1dfb6b1, reversing changes made to bcb5798.
That commit broke generating nightly rustc docs. Revert it until we can figure out how to have both, cranelift and docs.
Fixes rust-lang#117430
bors added a commit to rust-lang-ci/rust that referenced this pull request
…g, r=
re-enable cranelift on CI
First commit addresses the linking issue with compiler crates. Second one ensures that compiler crates are linked correctly, allowing us to detect these hard-to-catch bugs on CI. The remaining three commits cherry-picked from rust-lang#117328 to re-enable the Cranelift backend on CI.
More info: rust-lang#117430
cc @bjorn3 @RalfJung
bors added a commit to rust-lang-ci/rust that referenced this pull request
…g, r=
re-enable cranelift on CI
First commit addresses the linking issue with compiler crates. Second one ensures that compiler crates are linked correctly, allowing us to detect these hard-to-catch bugs on CI. The remaining three commits cherry-picked from rust-lang#117328 to re-enable the Cranelift backend on CI.
More info: rust-lang#117430
cc @bjorn3 @RalfJung
bors added a commit to rust-lang-ci/rust that referenced this pull request
…g, r=
re-enable cranelift on CI
First commit addresses the linking issue with compiler crates. Second one ensures that compiler crates are linked correctly, allowing us to detect these hard-to-catch bugs on CI. The remaining three commits cherry-picked from rust-lang#117328 to re-enable the Cranelift backend on CI.
More info: rust-lang#117430
cc @bjorn3 @RalfJung
bors added a commit to rust-lang-ci/rust that referenced this pull request
…g, r=
re-enable cranelift on CI
First commit addresses the linking issue with compiler crates. Second one ensures that compiler crates are linked correctly, allowing us to detect these hard-to-catch bugs on CI. Following three commits cherry-picked from rust-lang#117328 to re-enable the Cranelift backend on CI.
More info: rust-lang#117430
cc @bjorn3 @RalfJung
bors added a commit to rust-lang-ci/rust that referenced this pull request
…g, r=
re-enable cranelift on CI
First commit addresses the linking issue with compiler crates. Second one ensures that compiler crates are linked correctly, allowing us to detect these hard-to-catch bugs on CI. Following three commits cherry-picked from rust-lang#117328 to re-enable the Cranelift backend on CI.
More info: rust-lang#117430
cc @bjorn3 @RalfJung
bors added a commit to rust-lang-ci/rust that referenced this pull request
…g, r=
re-enable cranelift on CI
First commit addresses the linking issue with compiler crates. Second one ensures that compiler crates are linked correctly, allowing us to detect these hard-to-catch bugs on CI. Following three commits cherry-picked from rust-lang#117328 to re-enable the Cranelift backend on CI.
More info: rust-lang#117430
cc @bjorn3 @RalfJung
bors added a commit to rust-lang-ci/rust that referenced this pull request
…g, r=Mark-Simulacrum
improve compiler&tool documenting and re-enable cranelift on CI
First commit addresses the linking issue with compiler crates. Second one ensures that compiler crates are linked correctly (with later commits we added this check for tools as well), allowing us to detect these hard-to-catch bugs on CI. Following three commits cherry-picked from rust-lang#117328 to re-enable the Cranelift backend on CI.
More info: rust-lang#117430
cc @bjorn3 @RalfJung
Labels
Area: The testsuite used to check the correctness of rustc
This PR was explicitly merged by bors.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Relevant to the infrastructure team, which will review and decide on the PR/issue.