Use zip_eq to enforce that things being zipped have equal sizes by compiler-errors · Pull Request #119971 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation5 Commits2 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Some zips are best enforced to be equal, since size mismatches suggest deeper bugs in the compiler.
r? @cjgillot
(rustbot has picked a reviewer for you, use r? to override)
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.
If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.
I just added the zip_eqs that I could most easily validate. There are likely more that need help.
📌 Commit c811662 has been approved by nnethercote
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
Use zip_eq to enforce that things being zipped have equal sizes
Some zips are best enforced to be equal, since size mismatches suggest deeper bugs in the compiler.
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#119508 (coverage: Simplify building the coverage graph with
CoverageSuccessors) - rust-lang#119818 (Silence some follow-up errors [3/x])
- rust-lang#119870 (std: Doc blocking behavior of LazyLock)
- rust-lang#119963 (Fix
allow_internal_unstablefor(min_)specialization) - rust-lang#119968 (Remove unused/unnecessary features)
- rust-lang#119971 (Use
zip_eqto enforce that things being zipped have equal sizes) - rust-lang#119974 (Minor
trimmed_def_pathsimprovements)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 6 pull requests
Successful merges:
- rust-lang#119818 (Silence some follow-up errors [3/x])
- rust-lang#119870 (std: Doc blocking behavior of LazyLock)
- rust-lang#119897 (
OutputTypeParameterMismatch->SignatureMismatch) - rust-lang#119963 (Fix
allow_internal_unstablefor(min_)specialization) - rust-lang#119971 (Use
zip_eqto enforce that things being zipped have equal sizes) - rust-lang#119974 (Minor
trimmed_def_pathsimprovements)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 6 pull requests
Successful merges:
- rust-lang#119818 (Silence some follow-up errors [3/x])
- rust-lang#119870 (std: Doc blocking behavior of LazyLock)
- rust-lang#119897 (
OutputTypeParameterMismatch->SignatureMismatch) - rust-lang#119963 (Fix
allow_internal_unstablefor(min_)specialization) - rust-lang#119971 (Use
zip_eqto enforce that things being zipped have equal sizes) - rust-lang#119974 (Minor
trimmed_def_pathsimprovements)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 6 pull requests
Successful merges:
- rust-lang#119818 (Silence some follow-up errors [3/x])
- rust-lang#119870 (std: Doc blocking behavior of LazyLock)
- rust-lang#119897 (
OutputTypeParameterMismatch->SignatureMismatch) - rust-lang#119963 (Fix
allow_internal_unstablefor(min_)specialization) - rust-lang#119971 (Use
zip_eqto enforce that things being zipped have equal sizes) - rust-lang#119974 (Minor
trimmed_def_pathsimprovements)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#119971 - compiler-errors:zip-eq, r=nnethercote
Use zip_eq to enforce that things being zipped have equal sizes
Some zips are best enforced to be equal, since size mismatches suggest deeper bugs in the compiler.
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.