Fix allow_internal_unstable for (min_)specialization by clubby789 · Pull Request #119963 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation4 Commits2 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

clubby789

Fixes #119950

Blocked on #119949 (comment doesn't make sense until that merges)

I'd like to follow this up and look for more instances of not properly checking spans for features but I wanted to fix the motivating issue.

@clubby789

@rustbot

r? @WaffleLapkin

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Jan 14, 2024

compiler-errors

@clubby789

compiler-errors

@compiler-errors

r? compiler-errors @bors r+

@bors

📌 Commit eb63d3a has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jan 14, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jan 15, 2024

@matthiaskrgr

…able, r=compiler-errors

Fix allow_internal_unstable for (min_)specialization

Fixes rust-lang#119950

Blocked on rust-lang#119949 (comment doesn't make sense until that merges)

I'd like to follow this up and look for more instances of not properly checking spans for features but I wanted to fix the motivating issue.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jan 15, 2024

@bors

…iaskrgr

Rollup of 7 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jan 15, 2024

@bors

…iaskrgr

Rollup of 6 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jan 15, 2024

@bors

…iaskrgr

Rollup of 6 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jan 15, 2024

@bors

…iaskrgr

Rollup of 6 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Jan 15, 2024

@rust-timer

Rollup merge of rust-lang#119963 - clubby789:spec-allow-internal-unstable, r=compiler-errors

Fix allow_internal_unstable for (min_)specialization

Fixes rust-lang#119950

Blocked on rust-lang#119949 (comment doesn't make sense until that merges)

I'd like to follow this up and look for more instances of not properly checking spans for features but I wanted to fix the motivating issue.

This was referenced

Feb 10, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Feb 10, 2024

@matthiaskrgr

…rrors

Remove unnecessary #![feature(min_specialization)]

As of rust-lang#119963 and rust-lang#120676, we can now rely on newtype_index! having #[allow_internal_unstable(min_specialization)], so there are a few compiler crates that no longer need to include min-spec in their own crate features.

Some of the expansions of newtype_index! still appear to require min-spec in the crate features. I think this is because #[orderable] causes the expansion to include an implementation of TrustedStep, which is flagged with #[rustc_specialization_trait], and for whatever reason that isn't permitted by allow-internal-unstable. So this PR only touches the crates where that isn't the case.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Feb 10, 2024

@matthiaskrgr

Allow restricted trait impls under #[allow_internal_unstable(min_specialization)]

This is a follow-up to rust-lang#119963 and a companion to rust-lang#120866, though it can land independently from the latter.

We have several compiler crates that only enable #[feature(min_specialization)] because it is required by their expansions of newtype_index!, in order to implement traits marked with #[rustc_specialization_trait].

This PR allows those traits to be implemented internally by macros with #[allow_internal_unstable(min_specialization)], without needing specialization to be enabled in the enclosing crate.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Feb 10, 2024

@matthiaskrgr

…rrors

Remove unnecessary #![feature(min_specialization)]

As of rust-lang#119963 and rust-lang#120676, we can now rely on newtype_index! having #[allow_internal_unstable(min_specialization)], so there are a few compiler crates that no longer need to include min-spec in their own crate features.

Some of the expansions of newtype_index! still appear to require min-spec in the crate features. I think this is because #[orderable] causes the expansion to include an implementation of TrustedStep, which is flagged with #[rustc_specialization_trait], and for whatever reason that isn't permitted by allow-internal-unstable. So this PR only touches the crates where that isn't the case.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Feb 10, 2024

@matthiaskrgr

Allow restricted trait impls under #[allow_internal_unstable(min_specialization)]

This is a follow-up to rust-lang#119963 and a companion to rust-lang#120866, though it can land independently from the latter.

We have several compiler crates that only enable #[feature(min_specialization)] because it is required by their expansions of newtype_index!, in order to implement traits marked with #[rustc_specialization_trait].

This PR allows those traits to be implemented internally by macros with #[allow_internal_unstable(min_specialization)], without needing specialization to be enabled in the enclosing crate.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Feb 10, 2024

@matthiaskrgr

…rrors

Remove unnecessary #![feature(min_specialization)]

As of rust-lang#119963 and rust-lang#120676, we can now rely on newtype_index! having #[allow_internal_unstable(min_specialization)], so there are a few compiler crates that no longer need to include min-spec in their own crate features.

Some of the expansions of newtype_index! still appear to require min-spec in the crate features. I think this is because #[orderable] causes the expansion to include an implementation of TrustedStep, which is flagged with #[rustc_specialization_trait], and for whatever reason that isn't permitted by allow-internal-unstable. So this PR only touches the crates where that isn't the case.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Feb 10, 2024

@matthiaskrgr

Allow restricted trait impls under #[allow_internal_unstable(min_specialization)]

This is a follow-up to rust-lang#119963 and a companion to rust-lang#120866, though it can land independently from the latter.

We have several compiler crates that only enable #[feature(min_specialization)] because it is required by their expansions of newtype_index!, in order to implement traits marked with #[rustc_specialization_trait].

This PR allows those traits to be implemented internally by macros with #[allow_internal_unstable(min_specialization)], without needing specialization to be enabled in the enclosing crate.

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Feb 10, 2024

@rust-timer

Rollup merge of rust-lang#120870 - Zalathar:allow-min-spec, r=oli-obk

Allow restricted trait impls under #[allow_internal_unstable(min_specialization)]

This is a follow-up to rust-lang#119963 and a companion to rust-lang#120866, though it can land independently from the latter.

We have several compiler crates that only enable #[feature(min_specialization)] because it is required by their expansions of newtype_index!, in order to implement traits marked with #[rustc_specialization_trait].

This PR allows those traits to be implemented internally by macros with #[allow_internal_unstable(min_specialization)], without needing specialization to be enabled in the enclosing crate.

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Feb 10, 2024

@rust-timer

Rollup merge of rust-lang#120866 - Zalathar:no-min-spec, r=compiler-errors

Remove unnecessary #![feature(min_specialization)]

As of rust-lang#119963 and rust-lang#120676, we can now rely on newtype_index! having #[allow_internal_unstable(min_specialization)], so there are a few compiler crates that no longer need to include min-spec in their own crate features.

Some of the expansions of newtype_index! still appear to require min-spec in the crate features. I think this is because #[orderable] causes the expansion to include an implementation of TrustedStep, which is flagged with #[rustc_specialization_trait], and for whatever reason that isn't permitted by allow-internal-unstable. So this PR only touches the crates where that isn't the case.

Labels

F-min_specialization

`#![feature(min_specialization)]`

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.