Use <T, U> for array/slice equality impls by wackbyte · Pull Request #120384 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation9 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Makes the trait implementation documentation for arrays and slices appear more consistent.
Example: mixed A, B, and U.
This change makes them all U.
r? @thomcc
(rustbot has picked a reviewer for you, use r? to override)
Status: Awaiting review from the assignee but also interested parties.
Relevant to the library team, which will review and decide on the PR/issue.
labels
This comment has been minimized.
(I made the patch in GitHub's web editor so I was unaware of the failing tests. But at least now there are more examples of the inconsistency :P)
Use Use <T, U> for array equality impls<T, U> for array/slice equality impls
This comment has been minimized.
Makes the trait implementation documentation for arrays and slices appear more consistent.
Area: Documentation for any part of the project, including the compiler, standard library, and tools
label
I'm going to be away for a few months, so I'm rerolling my PRs so that folks don't have to wait for me. Sorry/thanks.
r? libs
📌 Commit 3f3a153 has been approved by Mark-Simulacrum
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#119481 (Clarify ambiguity in select_nth_unstable docs)
- rust-lang#120384 (Use
<T, U>for array/slice equalityimpls) - rust-lang#120423 (update indirect structural match lints to match RFC and to show up for dependencies)
- rust-lang#120458 (Document
&CStrtoCStringconversion) - rust-lang#120558 (Stop bailing out from compilation just because there were incoherent traits)
- rust-lang#120572 (Update libc to 0.2.153)
- rust-lang#120641 (rustdoc: trait.impl, type.impl: sort impls to make it not depend on serialization order)
r? @ghost
@rustbot modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#113833 (
std::error::Error-> Trait Implementations: lifetimes consistency improvement) - rust-lang#115386 (PartialEq, PartialOrd: update and synchronize handling of transitive chains)
- rust-lang#116284 (make matching on NaN a hard error, and remove the rest of illegal_floating_point_literal_pattern)
- rust-lang#118960 (Add LocalWaker and ContextBuilder types to core, and LocalWake trait to alloc.)
- rust-lang#120060 (Use the same mir-opt bless targets on all platforms)
- rust-lang#120214 (match lowering: consistently lower bindings deepest-first)
- rust-lang#120384 (Use
<T, U>for array/slice equalityimpls)
r? @ghost
@rustbot modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#113833 (
std::error::Error-> Trait Implementations: lifetimes consistency improvement) - rust-lang#115386 (PartialEq, PartialOrd: update and synchronize handling of transitive chains)
- rust-lang#116284 (make matching on NaN a hard error, and remove the rest of illegal_floating_point_literal_pattern)
- rust-lang#118960 (Add LocalWaker and ContextBuilder types to core, and LocalWake trait to alloc.)
- rust-lang#120384 (Use
<T, U>for array/slice equalityimpls) - rust-lang#120518 (riscv only supports split_debuginfo=off for now)
- rust-lang#120619 (Assert that params with the same index have the same name)
- rust-lang#120657 (Remove unused struct)
- rust-lang#120661 (target: default to the medium code model on LoongArch targets)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#113833 (
std::error::Error-> Trait Implementations: lifetimes consistency improvement) - rust-lang#115386 (PartialEq, PartialOrd: update and synchronize handling of transitive chains)
- rust-lang#116284 (make matching on NaN a hard error, and remove the rest of illegal_floating_point_literal_pattern)
- rust-lang#118960 (Add LocalWaker and ContextBuilder types to core, and LocalWake trait to alloc.)
- rust-lang#120384 (Use
<T, U>for array/slice equalityimpls) - rust-lang#120518 (riscv only supports split_debuginfo=off for now)
- rust-lang#120657 (Remove unused struct)
- rust-lang#120661 (target: default to the medium code model on LoongArch targets)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#113833 (
std::error::Error-> Trait Implementations: lifetimes consistency improvement) - rust-lang#115386 (PartialEq, PartialOrd: update and synchronize handling of transitive chains)
- rust-lang#116284 (make matching on NaN a hard error, and remove the rest of illegal_floating_point_literal_pattern)
- rust-lang#118960 (Add LocalWaker and ContextBuilder types to core, and LocalWake trait to alloc.)
- rust-lang#120384 (Use
<T, U>for array/slice equalityimpls) - rust-lang#120518 (riscv only supports split_debuginfo=off for now)
- rust-lang#120657 (Remove unused struct)
- rust-lang#120661 (target: default to the medium code model on LoongArch targets)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Labels
Area: Documentation for any part of the project, including the compiler, standard library, and tools
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the library team, which will review and decide on the PR/issue.