rustdoc: trait.impl, type.impl: sort impls to make it not depend on serialization order by klensy · Pull Request #120641 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation7 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Can be tested by running cargo doc with different rust versions on some crate and comparing doc folders: files in trait.impl and type.impl will sometimes have different order of impls.
r? @fmease
(rustbot has picked a reviewer for you, use r? to override)
Status: Awaiting review from the assignee but also interested parties.
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
Should i add fixme that this fixes only symptom, not source of instability?
That would be great, yes! And link to the issue
r? notriddle
@bors r+ rollup
📌 Commit cb4e69a has been approved by notriddle
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Ah, thanks for approving I was afk until now.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
rustdoc: trait.impl, type.impl: sort impls to make it not depend on serialization order
Can be tested by running cargo doc with different rust versions on some crate and comparing doc folders: files in trait.impl and type.impl will sometimes have different order of impls.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
rustdoc: trait.impl, type.impl: sort impls to make it not depend on serialization order
Can be tested by running cargo doc with different rust versions on some crate and comparing doc folders: files in trait.impl and type.impl will sometimes have different order of impls.
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#119481 (Clarify ambiguity in select_nth_unstable docs)
- rust-lang#120384 (Use
<T, U>for array/slice equalityimpls) - rust-lang#120423 (update indirect structural match lints to match RFC and to show up for dependencies)
- rust-lang#120458 (Document
&CStrtoCStringconversion) - rust-lang#120558 (Stop bailing out from compilation just because there were incoherent traits)
- rust-lang#120572 (Update libc to 0.2.153)
- rust-lang#120641 (rustdoc: trait.impl, type.impl: sort impls to make it not depend on serialization order)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#120641 - klensy:copypaste-me, r=notriddle
rustdoc: trait.impl, type.impl: sort impls to make it not depend on serialization order
Can be tested by running cargo doc with different rust versions on some crate and comparing doc folders: files in trait.impl and type.impl will sometimes have different order of impls.
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the rustdoc team, which will review and decide on the PR/issue.