Remove unused args from functions by compiler-errors · Pull Request #120590 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation10 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

#[instrument] suppresses the unused arguments from a function, and suppresses unused methods too! This PR removes things which are only used via #[instrument] calls, and fixes some other errors (privacy?) that I will comment inline.

It's possible that some of these arguments were being passed in for the purposes of being instrumented, but I am unconvinced by most of them.

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

rustbot added A-query-system

Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)

S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

WG-trait-system-refactor

The Rustc Trait System Refactor Initiative (-Znext-solver)

labels

Feb 2, 2024

Some changes might have occurred in exhaustiveness checking

cc @Nadrieril

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Type relation code was changed

cc @compiler-errors, @lcnr

@@ -52,7 +52,7 @@ impl From for QueryInvocationId {
}
}

pub(crate) struct MarkFrame<'a> {
pub struct MarkFrame<'a> {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We started getting a private-in-public error when the instrument call was removed from try_mark_parent_green.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool. :( that tracing stops the unused vars, i wish there was a way to mark uses as not used

📌 Commit 6b2a824 has been approved by Nilstrieb

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Feb 2, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Feb 3, 2024

Remove unused args from functions

It's possible that some of these arguments were being passed in for the purposes of being instrumented, but I am unconvinced by most of them.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Feb 4, 2024

Remove unused args from functions

It's possible that some of these arguments were being passed in for the purposes of being instrumented, but I am unconvinced by most of them.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 5, 2024

bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Feb 5, 2024

lmao this pr has nothing to do with that rollup failure

@bors r=Nilstrieb

📌 Commit 6b2a824 has been approved by Nilstrieb

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Feb 8, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Feb 8, 2024

Remove unused args from functions

It's possible that some of these arguments were being passed in for the purposes of being instrumented, but I am unconvinced by most of them.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Feb 8, 2024

Remove unused args from functions

It's possible that some of these arguments were being passed in for the purposes of being instrumented, but I am unconvinced by most of them.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Feb 8, 2024

Remove unused args from functions

It's possible that some of these arguments were being passed in for the purposes of being instrumented, but I am unconvinced by most of them.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Feb 8, 2024

Remove unused args from functions

It's possible that some of these arguments were being passed in for the purposes of being instrumented, but I am unconvinced by most of them.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 8, 2024

…iaskrgr

Rollup of 10 pull requests

Successful merges:

rust-lang#113026 (Introduce run-make V2 infrastructure, a run_make_support library and port over 2 tests as example)
rust-lang#120589 (std::thread::available_parallelism merging linux/android/freebsd version)
rust-lang#120590 (Remove unused args from functions)
rust-lang#120596 ([rustdoc] Correctly generate path for non-local items in source code pages)
rust-lang#120693 (Invert diagnostic lints.)
rust-lang#120704 (A drive-by rewrite of give_region_a_name())
rust-lang#120750 (No need to take ImplTraitContext by ref)
rust-lang#120765 (Reorder diagnostics API)
rust-lang#120772 (Remove myself from review rotation.)
rust-lang#120783 (Add release note for new ambiguous_wide_pointer_comparisons lint)

Failed merges:

rust-lang#120782 (Fix mir pass ICE in the presence of other errors)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 8, 2024

…iaskrgr

Rollup of 9 pull requests

Successful merges:

rust-lang#120590 (Remove unused args from functions)
rust-lang#120750 (No need to take ImplTraitContext by ref)
rust-lang#120769 (make future diffs minimal)
rust-lang#120772 (Remove myself from review rotation.)
rust-lang#120775 (Make min_exhaustive_patterns match exhaustive_patterns better)
rust-lang#120778 (Deduplicate tcx.instance_mir(instance) calls in try_instance_mir)
rust-lang#120782 (Fix mir pass ICE in the presence of other errors)
rust-lang#120783 (Add release note for new ambiguous_wide_pointer_comparisons lint)
rust-lang#120801 (Avoid ICE in drop recursion check in case of invalid drop impls)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Feb 8, 2024

Rollup merge of rust-lang#120590 - compiler-errors:dead, r=Nilstrieb

Remove unused args from functions

It's possible that some of these arguments were being passed in for the purposes of being instrumented, but I am unconvinced by most of them.

Labels

A-query-system

Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

WG-trait-system-refactor

The Rustc Trait System Refactor Initiative (-Znext-solver)