No need to take ImplTraitContext by ref by compiler-errors · Pull Request #120750 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation4 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

We used to mutate ImplTraitContext, so it used to be &mut mutable ref. Then I think it used to have non-Copy data in it, so we took it by & ref. Now, none of that remains, so just copy it around.

r? @michaelwoerister

rustbot has assigned @michaelwoerister.
They will have a look at your PR within the next two weeks and either review your PR or
reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Feb 7, 2024

📌 Commit cd21b1d has been approved by cjgillot

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Feb 7, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Feb 8, 2024

…gillot

No need to take ImplTraitContext by ref

We used to mutate ImplTraitContext, so it used to be &mut mutable ref. Then I think it used to have non-Copy data in it, so we took it by & ref. Now, none of that remains, so just copy it around.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Feb 8, 2024

…gillot

No need to take ImplTraitContext by ref

We used to mutate ImplTraitContext, so it used to be &mut mutable ref. Then I think it used to have non-Copy data in it, so we took it by & ref. Now, none of that remains, so just copy it around.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Feb 8, 2024

…gillot

No need to take ImplTraitContext by ref

We used to mutate ImplTraitContext, so it used to be &mut mutable ref. Then I think it used to have non-Copy data in it, so we took it by & ref. Now, none of that remains, so just copy it around.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Feb 8, 2024

…gillot

No need to take ImplTraitContext by ref

We used to mutate ImplTraitContext, so it used to be &mut mutable ref. Then I think it used to have non-Copy data in it, so we took it by & ref. Now, none of that remains, so just copy it around.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 8, 2024

…iaskrgr

Rollup of 10 pull requests

Successful merges:

• rust-lang#113026 (Introduce run-make V2 infrastructure, a run_make_support library and port over 2 tests as example)
• rust-lang#120589 (std::thread::available_parallelism merging linux/android/freebsd version)
• rust-lang#120590 (Remove unused args from functions)
• rust-lang#120596 ([rustdoc] Correctly generate path for non-local items in source code pages)
• rust-lang#120693 (Invert diagnostic lints.)
• rust-lang#120704 (A drive-by rewrite of give_region_a_name())
• rust-lang#120750 (No need to take ImplTraitContext by ref)
• rust-lang#120765 (Reorder diagnostics API)
• rust-lang#120772 (Remove myself from review rotation.)
• rust-lang#120783 (Add release note for new ambiguous_wide_pointer_comparisons lint)

Failed merges:

• rust-lang#120782 (Fix mir pass ICE in the presence of other errors)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 8, 2024

…iaskrgr

Rollup of 9 pull requests

Successful merges:

• rust-lang#120590 (Remove unused args from functions)
• rust-lang#120750 (No need to take ImplTraitContext by ref)
• rust-lang#120769 (make future diffs minimal)
• rust-lang#120772 (Remove myself from review rotation.)
• rust-lang#120775 (Make min_exhaustive_patterns match exhaustive_patterns better)
• rust-lang#120778 (Deduplicate tcx.instance_mir(instance) calls in try_instance_mir)
• rust-lang#120782 (Fix mir pass ICE in the presence of other errors)
• rust-lang#120783 (Add release note for new ambiguous_wide_pointer_comparisons lint)
• rust-lang#120801 (Avoid ICE in drop recursion check in case of invalid drop impls)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Feb 8, 2024

Rollup merge of rust-lang#120750 - compiler-errors:itctx-by-val, r=cjgillot

No need to take ImplTraitContext by ref

We used to mutate ImplTraitContext, so it used to be &mut mutable ref. Then I think it used to have non-Copy data in it, so we took it by & ref. Now, none of that remains, so just copy it around.

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.