Move the extra directives for Mode::CoverageRun into iter_header by Zalathar · Pull Request #121233 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation6 Commits2 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
When these extra directives were ported over as part of #112300, it made sense to introduce iter_header_extra and pass them in as an extra argument.
But now that #120881 has added a mode parameter to iter_header for its own purposes, it's slightly simpler to move the coverage special-case code directly into iter_header as well. This lets us get rid of iter_header_extra.
r? @oli-obk
rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Area: The testsuite used to check the correctness of rustc
Status: Awaiting review from the assignee but also interested parties.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
When these extra directives were ported over as part of rust-lang#112300, it made sense
to introduce iter_header_extra and pass them in as an extra argument.
But now that rust-lang#120881 has added a mode parameter to iter_header for its own
purposes, it's slightly simpler to move the coverage special-case code directly
into iter_header as well. This lets us get rid of iter_header_extra.
📌 Commit c521d7f has been approved by oli-obk
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
saethlin added a commit to saethlin/rust that referenced this pull request
Move the extra directives for Mode::CoverageRun into iter_header
When these extra directives were ported over as part of rust-lang#112300, it made sense to introduce iter_header_extra and pass them in as an extra argument.
But now that rust-lang#120881 has added a mode parameter to iter_header for its own purposes, it's slightly simpler to move the coverage special-case code directly into iter_header as well. This lets us get rid of iter_header_extra.
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 8 pull requests
Successful merges:
- rust-lang#120718 (Add "algebraic" fast-math intrinsics, based on fast-math ops that cannot return poison)
- rust-lang#121195 (unstable-book: Separate testing and production sanitizers)
- rust-lang#121205 (Merge
CompilerError::CompilationFailedandCompilerError::ICE.) - rust-lang#121233 (Move the extra directives for
Mode::CoverageRunintoiter_header) - rust-lang#121256 (Allow AST and HIR visitors to return
ControlFlow) - rust-lang#121307 (Drive-by
DUMMY_SP->Spanand fmt changes) - rust-lang#121310 (Remove an old hack for rustdoc)
- rust-lang#121311 (Make
is_nonoverlapping#[inline])
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#121233 - Zalathar:extra-directives, r=oli-obk
Move the extra directives for Mode::CoverageRun into iter_header
When these extra directives were ported over as part of rust-lang#112300, it made sense to introduce iter_header_extra and pass them in as an extra argument.
But now that rust-lang#120881 has added a mode parameter to iter_header for its own purposes, it's slightly simpler to move the coverage special-case code directly into iter_header as well. This lets us get rid of iter_header_extra.
Labels
Area: The testsuite used to check the correctness of rustc
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)