Drive-by DUMMY_SP -> Span and fmt changes by estebank · Pull Request #121307 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation3 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Noticed these while doing something else. There's no practical change, but it's preferable to use DUMMY_SP as little as possible, particularly when we have perfectlly useful Spans available.
Noticed these while doing something else. There's no practical change, but it's preferable to use DUMMY_SP as little as possible, particularly when we have perfectlly useful Spans available.
r? @davidtwco
rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
📌 Commit b4a424f has been approved by compiler-errors
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
saethlin added a commit to saethlin/rust that referenced this pull request
Drive-by DUMMY_SP -> Span and fmt changes
Noticed these while doing something else. There's no practical change, but it's preferable to use DUMMY_SP as little as possible, particularly when we have perfectlly useful Spans available.
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 8 pull requests
Successful merges:
- rust-lang#120718 (Add "algebraic" fast-math intrinsics, based on fast-math ops that cannot return poison)
- rust-lang#121195 (unstable-book: Separate testing and production sanitizers)
- rust-lang#121205 (Merge
CompilerError::CompilationFailedandCompilerError::ICE.) - rust-lang#121233 (Move the extra directives for
Mode::CoverageRunintoiter_header) - rust-lang#121256 (Allow AST and HIR visitors to return
ControlFlow) - rust-lang#121307 (Drive-by
DUMMY_SP->Spanand fmt changes) - rust-lang#121310 (Remove an old hack for rustdoc)
- rust-lang#121311 (Make
is_nonoverlapping#[inline])
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#121307 - estebank:drive-by, r=compiler-errors
Drive-by DUMMY_SP -> Span and fmt changes
Noticed these while doing something else. There's no practical change, but it's preferable to use DUMMY_SP as little as possible, particularly when we have perfectlly useful Spans available.
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.