Fix OutsideLoop's error suggestion: adding label 'block for if block. by surechen · Pull Request #123623 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation26 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
For OutsideLoop we should not suggest add 'block label in if block, or we wiil get another err: block label not supported here.
fixes #123261
r? @estebank
rustbot has assigned @estebank.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
This comment has been minimized.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some nitpicks, I need a bit more time to properly review. Thank you for taking the time to address this!
Left some nitpicks, I need a bit more time to properly review. Thank you for taking the time to address this!
Okay, thank you very much, your review reply is very prompt, 👍 I'll fix the above problem first.
This comment has been minimized.
This comment has been minimized.
…r we wiil get another err: block label not supported here.
fixes rust-lang#123261
📌 Commit 8fde7e3 has been approved by estebank
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#122665 (Add some tests for public-private dependencies.)
- rust-lang#123623 (Fix OutsideLoop's error suggestion: adding label
'blockforifblock.) - rust-lang#125054 (Handle
ReVarinnote_and_explain_region) - rust-lang#125156 (Expand
for_loops_over_fallibleslint to lint on fallibles behind references.) - rust-lang#125222 (Migrate
run-make/issue-46239tormake) - rust-lang#125316 (Tweak
Spacinguse) - rust-lang#125392 (Wrap Context.ext in AssertUnwindSafe)
- rust-lang#125417 (self-contained linker: retry linking without
-fuse-ld=lldon CCs that don't support it)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#123623 - surechen:fix_123261, r=estebank
Fix OutsideLoop's error suggestion: adding label 'block for if block.
For OutsideLoop we should not suggest add 'block label in if block, or we wiil get another err: block label not supported here.
fixes rust-lang#123261
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.