Migrate run-make/issue-46239 to rmake by Oneirical · Pull Request #125222 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation16 Commits1 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Oneirical

@rustbot

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite

Area: The testsuite used to check the correctness of rustc

S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

labels

May 17, 2024

@rustbot

Some changes occurred in run-make tests.

cc @jieyouxu

@rustbot

The run-make-support library was changed

cc @jieyouxu

jieyouxu

@@ -0,0 +1,14 @@
// In the rustc_trans crate, references returned by a Frozen pointer type

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is outdated, we don't have a rustc_trans crate anymore do we?

@@ -0,0 +1,14 @@
// In the rustc_trans crate, references returned by a Frozen pointer type
// could mark them as "noalias", which caused miscompilation errors.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel this should be a codegen test if we're trying to check for noalias metadata?

@jieyouxu

I'll revisit this, this seems like it should be a codegen test

@jieyouxu

See codegen tests for more references, please do ask me if you are stuck or have any questions.

@rustbot author

@rustbot rustbot added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

May 21, 2024

@Oneirical

I have attempted the conversion to a codegen test, more so we can discuss it than claim "it's done". Seeing the other tests putting their flags on library functions and not main() makes me a little worried (I took inspiration from other noalias-related codegen tests such as noalias-box.rs.)

@rustbot review

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

May 22, 2024

jieyouxu

Comment on lines 13 to 21

// CHECK-NOT: noalias
fn main() {
let f = (dummy as fn(),);
(*project(&f))();
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: I think this test could be written as

//@ compile-flags: -Copt-level=1

#![crate_type = "lib"]

fn project(x: &(T,)) -> &T { &x.0 }

fn dummy() {}

// CHECK-LABEL: @foo( // CHECK-NOT: noalias #[no_mangle] pub fn foo() { let f = (dummy as fn(),); (*project(&f))(); }

This way the noalias check must happen after the foo label occurs.

@jieyouxu

@rustbot rustbot added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

May 23, 2024

@Oneirical

@rustbot review

Thanks for the suggestion! I'm just now learning how the codegen tests work, and I see how you made it more similar to the other codegen tests, and prevented the name foo from being altered by compilation with no-mangle.

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

May 23, 2024

@rust-log-analyzer

This comment has been minimized.

@jieyouxu

Thanks, r=me after squashing commits into one.
@bors delegate+

@bors

✌️ @Oneirical, you can now approve this pull request!

If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu

@Oneirical

@Oneirical

@bors

📌 Commit ddb81ce has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

May 23, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

May 23, 2024

@bors

…iaskrgr

Rollup of 8 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

May 23, 2024

@rust-timer

Labels

A-testsuite

Area: The testsuite used to check the correctness of rustc

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)