Add pub struct with allow(dead_code) into worklist by mu001999 · Pull Request #126315 · rust-lang/rust (original) (raw)

mu001999

@mu001999

@rustbot

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Jun 12, 2024

@petrochenkov

@bors

📌 Commit 6445073 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jun 13, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jun 13, 2024

@matthiaskrgr

…rochenkov

Add pub struct with allow(dead_code) into worklist

Fixes rust-lang#126289

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 13, 2024

@bors

…iaskrgr

Rollup of 8 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 13, 2024

@bors

…iaskrgr

Rollup of 8 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jun 13, 2024

@matthiaskrgr

…rochenkov

Add pub struct with allow(dead_code) into worklist

Fixes rust-lang#126289

This was referenced

Jun 13, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 13, 2024

@bors

…iaskrgr

Rollup of 9 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jun 13, 2024

@matthiaskrgr

…rochenkov

Add pub struct with allow(dead_code) into worklist

Fixes rust-lang#126289

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 13, 2024

@bors

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 13, 2024

@bors

…iaskrgr

Rollup of 8 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 14, 2024

@bors

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Jun 14, 2024

@rust-timer

Rollup merge of rust-lang#126315 - mu001999-contrib:fix/126289, r=petrochenkov

Add pub struct with allow(dead_code) into worklist

Fixes rust-lang#126289

@glandium

Can you get the fix on beta?

@mu001999

@apiraino

Beta backport accepted as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle.

@rustbot label +beta-accepted

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 21, 2024

@bors

[beta] backports

r? cuviper

compiler-errors added a commit to compiler-errors/rust that referenced this pull request

Jul 30, 2024

@compiler-errors

…9, r=petrochenkov"

This reverts commit 977c5fd, reversing changes made to 24c94f0.

compiler-errors added a commit to compiler-errors/rust that referenced this pull request

Jul 30, 2024

@compiler-errors

…9, r=petrochenkov"

This reverts commit 977c5fd, reversing changes made to 24c94f0.

compiler-errors added a commit to compiler-errors/rust that referenced this pull request

Jul 30, 2024

@compiler-errors

…9, r=petrochenkov"

This reverts commit 977c5fd, reversing changes made to 24c94f0.

compiler-errors added a commit to compiler-errors/rust that referenced this pull request

Jul 30, 2024

@compiler-errors

…9, r=petrochenkov"

This reverts commit 977c5fd, reversing changes made to 24c94f0.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jul 31, 2024

@matthiaskrgr

…hanges, r=pnkfelix

Revert recent changes to dead code analysis

This is a revert to recent changes to dead code analysis, namely:

There is an additional change stacked on top, which suppresses false-negatives that were masked by this work. I believe the functions that are touched in that code are legitimately unused functions and the types are not reachable since this AnonPipe type is not publically reachable -- please correct me if I'm wrong cc @NobodyXu who added these in #rust-lang#127153.

Some of these reverts (rust-lang#126315 and rust-lang#126618) are only included because it makes the revert apply cleanly, and I think these changes were only done to fix follow-ups from the other PRs?

I apologize for the size of the PR and the churn that it has on the codebase (and for reverting @mu001999's work here), but I'm putting this PR up because I am concerned that we're making ad-hoc changes to fix bugs that are fallout of these PRs, and I'd like to see these changes reimplemented in a way that's more separable from the existing dead code pass. I am happy to review any code to reapply these changes in a more separable way.

cc @mu001999 r? @pnkfelix

Fixes rust-lang#128272 Fixes rust-lang#126169

compiler-errors added a commit to compiler-errors/rust that referenced this pull request

Jul 31, 2024

@compiler-errors

…9, r=petrochenkov"

This reverts commit 977c5fd, reversing changes made to 24c94f0.

tgross35 added a commit to tgross35/rust that referenced this pull request

Aug 1, 2024

@tgross35

…hanges, r=pnkfelix

Revert recent changes to dead code analysis

This is a revert to recent changes to dead code analysis, namely:

There is an additional change stacked on top, which suppresses false-negatives that were masked by this work. I believe the functions that are touched in that code are legitimately unused functions and the types are not reachable since this AnonPipe type is not publically reachable -- please correct me if I'm wrong cc @NobodyXu who added these in #rust-lang#127153.

Some of these reverts (rust-lang#126315 and rust-lang#126618) are only included because it makes the revert apply cleanly, and I think these changes were only done to fix follow-ups from the other PRs?

I apologize for the size of the PR and the churn that it has on the codebase (and for reverting @mu001999's work here), but I'm putting this PR up because I am concerned that we're making ad-hoc changes to fix bugs that are fallout of these PRs, and I'd like to see these changes reimplemented in a way that's more separable from the existing dead code pass. I am happy to review any code to reapply these changes in a more separable way.

cc @mu001999 r? @pnkfelix

Fixes rust-lang#128272 Fixes rust-lang#126169

compiler-errors added a commit to compiler-errors/rust that referenced this pull request

Aug 1, 2024

@compiler-errors

…9, r=petrochenkov"

This reverts commit 977c5fd, reversing changes made to 24c94f0.

tgross35 added a commit to tgross35/rust that referenced this pull request

Aug 1, 2024

@tgross35

…hanges, r=pnkfelix

Revert recent changes to dead code analysis

This is a revert to recent changes to dead code analysis, namely:

There is an additional change stacked on top, which suppresses false-negatives that were masked by this work. I believe the functions that are touched in that code are legitimately unused functions and the types are not reachable since this AnonPipe type is not publically reachable -- please correct me if I'm wrong cc @NobodyXu who added these in #rust-lang#127153.

Some of these reverts (rust-lang#126315 and rust-lang#126618) are only included because it makes the revert apply cleanly, and I think these changes were only done to fix follow-ups from the other PRs?

I apologize for the size of the PR and the churn that it has on the codebase (and for reverting @mu001999's work here), but I'm putting this PR up because I am concerned that we're making ad-hoc changes to fix bugs that are fallout of these PRs, and I'd like to see these changes reimplemented in a way that's more separable from the existing dead code pass. I am happy to review any code to reapply these changes in a more separable way.

cc @mu001999 r? @pnkfelix

Fixes rust-lang#128272 Fixes rust-lang#126169

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

Aug 2, 2024

@jieyouxu

…hanges, r=pnkfelix

Revert recent changes to dead code analysis

This is a revert to recent changes to dead code analysis, namely:

There is an additional change stacked on top, which suppresses false-negatives that were masked by this work. I believe the functions that are touched in that code are legitimately unused functions and the types are not reachable since this AnonPipe type is not publically reachable -- please correct me if I'm wrong cc @NobodyXu who added these in #rust-lang#127153.

Some of these reverts (rust-lang#126315 and rust-lang#126618) are only included because it makes the revert apply cleanly, and I think these changes were only done to fix follow-ups from the other PRs?

I apologize for the size of the PR and the churn that it has on the codebase (and for reverting @mu001999's work here), but I'm putting this PR up because I am concerned that we're making ad-hoc changes to fix bugs that are fallout of these PRs, and I'd like to see these changes reimplemented in a way that's more separable from the existing dead code pass. I am happy to review any code to reapply these changes in a more separable way.

cc @mu001999 r? @pnkfelix

Fixes rust-lang#128272 Fixes rust-lang#126169

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

Aug 2, 2024

@jieyouxu

…hanges, r=pnkfelix

Revert recent changes to dead code analysis

This is a revert to recent changes to dead code analysis, namely:

There is an additional change stacked on top, which suppresses false-negatives that were masked by this work. I believe the functions that are touched in that code are legitimately unused functions and the types are not reachable since this AnonPipe type is not publically reachable -- please correct me if I'm wrong cc @NobodyXu who added these in #rust-lang#127153.

Some of these reverts (rust-lang#126315 and rust-lang#126618) are only included because it makes the revert apply cleanly, and I think these changes were only done to fix follow-ups from the other PRs?

I apologize for the size of the PR and the churn that it has on the codebase (and for reverting @mu001999's work here), but I'm putting this PR up because I am concerned that we're making ad-hoc changes to fix bugs that are fallout of these PRs, and I'd like to see these changes reimplemented in a way that's more separable from the existing dead code pass. I am happy to review any code to reapply these changes in a more separable way.

cc @mu001999 r? @pnkfelix

Fixes rust-lang#128272 Fixes rust-lang#126169

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

Aug 3, 2024

@jieyouxu

…hanges, r=pnkfelix

Revert recent changes to dead code analysis

This is a revert to recent changes to dead code analysis, namely:

There is an additional change stacked on top, which suppresses false-negatives that were masked by this work. I believe the functions that are touched in that code are legitimately unused functions and the types are not reachable since this AnonPipe type is not publically reachable -- please correct me if I'm wrong cc @NobodyXu who added these in #rust-lang#127153.

Some of these reverts (rust-lang#126315 and rust-lang#126618) are only included because it makes the revert apply cleanly, and I think these changes were only done to fix follow-ups from the other PRs?

I apologize for the size of the PR and the churn that it has on the codebase (and for reverting @mu001999's work here), but I'm putting this PR up because I am concerned that we're making ad-hoc changes to fix bugs that are fallout of these PRs, and I'd like to see these changes reimplemented in a way that's more separable from the existing dead code pass. I am happy to review any code to reapply these changes in a more separable way.

cc @mu001999 r? @pnkfelix

Fixes rust-lang#128272 Fixes rust-lang#126169

compiler-errors added a commit to compiler-errors/rust that referenced this pull request

Aug 3, 2024

@compiler-errors

…9, r=petrochenkov"

This reverts commit 977c5fd, reversing changes made to 24c94f0.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 3, 2024

@bors

…nges, r=pnkfelix

Revert recent changes to dead code analysis

This is a revert to recent changes to dead code analysis, namely:

There is an additional change stacked on top, which suppresses false-negatives that were masked by this work. I believe the functions that are touched in that code are legitimately unused functions and the types are not reachable since this AnonPipe type is not publically reachable -- please correct me if I'm wrong cc @NobodyXu who added these in #rust-lang#127153.

Some of these reverts (rust-lang#126315 and rust-lang#126618) are only included because it makes the revert apply cleanly, and I think these changes were only done to fix follow-ups from the other PRs?

I apologize for the size of the PR and the churn that it has on the codebase (and for reverting @mu001999's work here), but I'm putting this PR up because I am concerned that we're making ad-hoc changes to fix bugs that are fallout of these PRs, and I'd like to see these changes reimplemented in a way that's more separable from the existing dead code pass. I am happy to review any code to reapply these changes in a more separable way.

cc @mu001999 r? @pnkfelix

Fixes rust-lang#128272 Fixes rust-lang#126169

compiler-errors added a commit to compiler-errors/rust that referenced this pull request

Aug 3, 2024

@compiler-errors

…9, r=petrochenkov"

This reverts commit 977c5fd, reversing changes made to 24c94f0.

compiler-errors added a commit to compiler-errors/rust that referenced this pull request

Aug 3, 2024

@compiler-errors

…9, r=petrochenkov"

This reverts commit 977c5fd, reversing changes made to 24c94f0.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 5, 2024

@bors

…nges-beta, r=cuviper

Revert recent changes to dead code analysis (beta flavor)

This PR cherry-picks the subset of rust-lang#128404 which actually applies to beta, namely:

And then re-blesses tests.

I opted to do a manual backport of that PR since preparing the revert correctly was quite a hassle.

r? @cuviper (or anyone on release)

bors pushed a commit to rust-lang-ci/rust that referenced this pull request

Aug 6, 2024

@compiler-errors @pietroalbini

…9, r=petrochenkov"

This reverts commit 977c5fd, reversing changes made to 24c94f0.