Mark assoc tys live only if the corresponding trait is live by mu001999 · Pull Request #126618 · rust-lang/rust (original) (raw)
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
📌 Commit a264bff has been approved by pnkfelix
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…nkfelix
Mark assoc tys live only if the corresponding trait is live
r? @pnkfelix
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…nkfelix
Mark assoc tys live only if the corresponding trait is live
r? @pnkfelix
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 10 pull requests
Successful merges:
- rust-lang#124460 (Show notice about "never used" of Debug for enum)
- rust-lang#125740 (transmute size check: properly account for alignment)
- rust-lang#126413 (compiletest: make the crash test error message abit more informative)
- rust-lang#126618 (Mark assoc tys live only if the corresponding trait is live)
- rust-lang#126673 (Ensure we don't accidentally succeed when we want to report an error)
- rust-lang#126804 (On short error format, append primary span label to message)
- rust-lang#126868 (not use offset when there is not ends with brace)
- rust-lang#126893 (Eliminate the distinction between PREC_POSTFIX and PREC_PAREN precedence level)
- rust-lang#126899 (Suggest inline const blocks for array initialization)
- rust-lang#126909 (add
@kobzolto bootstrap team for triagebot)
r? @ghost
@rustbot modify labels: rollup
compiler-errors added a commit to compiler-errors/rust that referenced this pull request
…nkfelix
Mark assoc tys live only if the corresponding trait is live
r? @pnkfelix
bors added a commit to rust-lang-ci/rust that referenced this pull request
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#126618 (Mark assoc tys live only if the corresponding trait is live)
- rust-lang#126746 (Deny
use<>for RPITITs) - rust-lang#126868 (not use offset when there is not ends with brace)
- rust-lang#126884 (Do not ICE when suggesting dereferencing closure arg)
- rust-lang#126893 (Eliminate the distinction between PREC_POSTFIX and PREC_PAREN precedence level)
- rust-lang#126915 (Don't suggest awaiting in closure patterns)
- rust-lang#126943 (De-duplicate all consecutive native libs regardless of their options)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#126618 (Mark assoc tys live only if the corresponding trait is live)
- rust-lang#126746 (Deny
use<>for RPITITs) - rust-lang#126868 (not use offset when there is not ends with brace)
- rust-lang#126884 (Do not ICE when suggesting dereferencing closure arg)
- rust-lang#126893 (Eliminate the distinction between PREC_POSTFIX and PREC_PAREN precedence level)
- rust-lang#126915 (Don't suggest awaiting in closure patterns)
- rust-lang#126943 (De-duplicate all consecutive native libs regardless of their options)
r? @ghost
@rustbot modify labels: rollup
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request
…nkfelix
Mark assoc tys live only if the corresponding trait is live
r? @pnkfelix
bors added a commit to rust-lang-ci/rust that referenced this pull request
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#126618 (Mark assoc tys live only if the corresponding trait is live)
- rust-lang#126746 (Deny
use<>for RPITITs) - rust-lang#126868 (not use offset when there is not ends with brace)
- rust-lang#126884 (Do not ICE when suggesting dereferencing closure arg)
- rust-lang#126893 (Eliminate the distinction between PREC_POSTFIX and PREC_PAREN precedence level)
- rust-lang#126915 (Don't suggest awaiting in closure patterns)
- rust-lang#126943 (De-duplicate all consecutive native libs regardless of their options)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#126618 - mu001999-contrib:dead/enhance, r=pnkfelix
Mark assoc tys live only if the corresponding trait is live
r? @pnkfelix
compiler-errors added a commit to compiler-errors/rust that referenced this pull request
…nce, r=pnkfelix"
This reverts commit 2724aea, reversing changes made to d929a42.
compiler-errors added a commit to compiler-errors/rust that referenced this pull request
…nce, r=pnkfelix"
This reverts commit 2724aea, reversing changes made to d929a42.
compiler-errors added a commit to compiler-errors/rust that referenced this pull request
…nce, r=pnkfelix"
This reverts commit 2724aea, reversing changes made to d929a42.
compiler-errors added a commit to compiler-errors/rust that referenced this pull request
…nce, r=pnkfelix"
This reverts commit 2724aea, reversing changes made to d929a42.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…hanges, r=pnkfelix
Revert recent changes to dead code analysis
This is a revert to recent changes to dead code analysis, namely:
- efdf219 Rollup merge of rust-lang#128104 - mu001999-contrib:fix/128053, r=petrochenkov
- a70dc29 Rollup merge of rust-lang#127017 - mu001999-contrib:dead/enhance, r=pnkfelix
- 31fe962 Rollup merge of rust-lang#127107 - mu001999-contrib:dead/enhance-2, r=pnkfelix
- 2724aea Rollup merge of rust-lang#126618 - mu001999-contrib:dead/enhance, r=pnkfelix
- 977c5fd Rollup merge of rust-lang#126315 - mu001999-contrib:fix/126289, r=petrochenkov
- 13314df Rollup merge of rust-lang#125572 - mu001999-contrib:dead/enhance, r=pnkfelix
There is an additional change stacked on top, which suppresses false-negatives that were masked by this work. I believe the functions that are touched in that code are legitimately unused functions and the types are not reachable since this AnonPipe type is not publically reachable -- please correct me if I'm wrong cc @NobodyXu who added these in #rust-lang#127153.
Some of these reverts (rust-lang#126315 and rust-lang#126618) are only included because it makes the revert apply cleanly, and I think these changes were only done to fix follow-ups from the other PRs?
I apologize for the size of the PR and the churn that it has on the codebase (and for reverting @mu001999's work here), but I'm putting this PR up because I am concerned that we're making ad-hoc changes to fix bugs that are fallout of these PRs, and I'd like to see these changes reimplemented in a way that's more separable from the existing dead code pass. I am happy to review any code to reapply these changes in a more separable way.
cc @mu001999
r? @pnkfelix
Fixes rust-lang#128272 Fixes rust-lang#126169
compiler-errors added a commit to compiler-errors/rust that referenced this pull request
…nce, r=pnkfelix"
This reverts commit 2724aea, reversing changes made to d929a42.
tgross35 added a commit to tgross35/rust that referenced this pull request
…hanges, r=pnkfelix
Revert recent changes to dead code analysis
This is a revert to recent changes to dead code analysis, namely:
- efdf219 Rollup merge of rust-lang#128104 - mu001999-contrib:fix/128053, r=petrochenkov
- a70dc29 Rollup merge of rust-lang#127017 - mu001999-contrib:dead/enhance, r=pnkfelix
- 31fe962 Rollup merge of rust-lang#127107 - mu001999-contrib:dead/enhance-2, r=pnkfelix
- 2724aea Rollup merge of rust-lang#126618 - mu001999-contrib:dead/enhance, r=pnkfelix
- 977c5fd Rollup merge of rust-lang#126315 - mu001999-contrib:fix/126289, r=petrochenkov
- 13314df Rollup merge of rust-lang#125572 - mu001999-contrib:dead/enhance, r=pnkfelix
There is an additional change stacked on top, which suppresses false-negatives that were masked by this work. I believe the functions that are touched in that code are legitimately unused functions and the types are not reachable since this AnonPipe type is not publically reachable -- please correct me if I'm wrong cc @NobodyXu who added these in #rust-lang#127153.
Some of these reverts (rust-lang#126315 and rust-lang#126618) are only included because it makes the revert apply cleanly, and I think these changes were only done to fix follow-ups from the other PRs?
I apologize for the size of the PR and the churn that it has on the codebase (and for reverting @mu001999's work here), but I'm putting this PR up because I am concerned that we're making ad-hoc changes to fix bugs that are fallout of these PRs, and I'd like to see these changes reimplemented in a way that's more separable from the existing dead code pass. I am happy to review any code to reapply these changes in a more separable way.
cc @mu001999
r? @pnkfelix
Fixes rust-lang#128272 Fixes rust-lang#126169
compiler-errors added a commit to compiler-errors/rust that referenced this pull request
…nce, r=pnkfelix"
This reverts commit 2724aea, reversing changes made to d929a42.
tgross35 added a commit to tgross35/rust that referenced this pull request
…hanges, r=pnkfelix
Revert recent changes to dead code analysis
This is a revert to recent changes to dead code analysis, namely:
- efdf219 Rollup merge of rust-lang#128104 - mu001999-contrib:fix/128053, r=petrochenkov
- a70dc29 Rollup merge of rust-lang#127017 - mu001999-contrib:dead/enhance, r=pnkfelix
- 31fe962 Rollup merge of rust-lang#127107 - mu001999-contrib:dead/enhance-2, r=pnkfelix
- 2724aea Rollup merge of rust-lang#126618 - mu001999-contrib:dead/enhance, r=pnkfelix
- 977c5fd Rollup merge of rust-lang#126315 - mu001999-contrib:fix/126289, r=petrochenkov
- 13314df Rollup merge of rust-lang#125572 - mu001999-contrib:dead/enhance, r=pnkfelix
There is an additional change stacked on top, which suppresses false-negatives that were masked by this work. I believe the functions that are touched in that code are legitimately unused functions and the types are not reachable since this AnonPipe type is not publically reachable -- please correct me if I'm wrong cc @NobodyXu who added these in #rust-lang#127153.
Some of these reverts (rust-lang#126315 and rust-lang#126618) are only included because it makes the revert apply cleanly, and I think these changes were only done to fix follow-ups from the other PRs?
I apologize for the size of the PR and the churn that it has on the codebase (and for reverting @mu001999's work here), but I'm putting this PR up because I am concerned that we're making ad-hoc changes to fix bugs that are fallout of these PRs, and I'd like to see these changes reimplemented in a way that's more separable from the existing dead code pass. I am happy to review any code to reapply these changes in a more separable way.
cc @mu001999
r? @pnkfelix
Fixes rust-lang#128272 Fixes rust-lang#126169
jieyouxu added a commit to jieyouxu/rust that referenced this pull request
…hanges, r=pnkfelix
Revert recent changes to dead code analysis
This is a revert to recent changes to dead code analysis, namely:
- efdf219 Rollup merge of rust-lang#128104 - mu001999-contrib:fix/128053, r=petrochenkov
- a70dc29 Rollup merge of rust-lang#127017 - mu001999-contrib:dead/enhance, r=pnkfelix
- 31fe962 Rollup merge of rust-lang#127107 - mu001999-contrib:dead/enhance-2, r=pnkfelix
- 2724aea Rollup merge of rust-lang#126618 - mu001999-contrib:dead/enhance, r=pnkfelix
- 977c5fd Rollup merge of rust-lang#126315 - mu001999-contrib:fix/126289, r=petrochenkov
- 13314df Rollup merge of rust-lang#125572 - mu001999-contrib:dead/enhance, r=pnkfelix
There is an additional change stacked on top, which suppresses false-negatives that were masked by this work. I believe the functions that are touched in that code are legitimately unused functions and the types are not reachable since this AnonPipe type is not publically reachable -- please correct me if I'm wrong cc @NobodyXu who added these in #rust-lang#127153.
Some of these reverts (rust-lang#126315 and rust-lang#126618) are only included because it makes the revert apply cleanly, and I think these changes were only done to fix follow-ups from the other PRs?
I apologize for the size of the PR and the churn that it has on the codebase (and for reverting @mu001999's work here), but I'm putting this PR up because I am concerned that we're making ad-hoc changes to fix bugs that are fallout of these PRs, and I'd like to see these changes reimplemented in a way that's more separable from the existing dead code pass. I am happy to review any code to reapply these changes in a more separable way.
cc @mu001999
r? @pnkfelix
Fixes rust-lang#128272 Fixes rust-lang#126169
jieyouxu added a commit to jieyouxu/rust that referenced this pull request
…hanges, r=pnkfelix
Revert recent changes to dead code analysis
This is a revert to recent changes to dead code analysis, namely:
- efdf219 Rollup merge of rust-lang#128104 - mu001999-contrib:fix/128053, r=petrochenkov
- a70dc29 Rollup merge of rust-lang#127017 - mu001999-contrib:dead/enhance, r=pnkfelix
- 31fe962 Rollup merge of rust-lang#127107 - mu001999-contrib:dead/enhance-2, r=pnkfelix
- 2724aea Rollup merge of rust-lang#126618 - mu001999-contrib:dead/enhance, r=pnkfelix
- 977c5fd Rollup merge of rust-lang#126315 - mu001999-contrib:fix/126289, r=petrochenkov
- 13314df Rollup merge of rust-lang#125572 - mu001999-contrib:dead/enhance, r=pnkfelix
There is an additional change stacked on top, which suppresses false-negatives that were masked by this work. I believe the functions that are touched in that code are legitimately unused functions and the types are not reachable since this AnonPipe type is not publically reachable -- please correct me if I'm wrong cc @NobodyXu who added these in #rust-lang#127153.
Some of these reverts (rust-lang#126315 and rust-lang#126618) are only included because it makes the revert apply cleanly, and I think these changes were only done to fix follow-ups from the other PRs?
I apologize for the size of the PR and the churn that it has on the codebase (and for reverting @mu001999's work here), but I'm putting this PR up because I am concerned that we're making ad-hoc changes to fix bugs that are fallout of these PRs, and I'd like to see these changes reimplemented in a way that's more separable from the existing dead code pass. I am happy to review any code to reapply these changes in a more separable way.
cc @mu001999
r? @pnkfelix
Fixes rust-lang#128272 Fixes rust-lang#126169
jieyouxu added a commit to jieyouxu/rust that referenced this pull request
…hanges, r=pnkfelix
Revert recent changes to dead code analysis
This is a revert to recent changes to dead code analysis, namely:
- efdf219 Rollup merge of rust-lang#128104 - mu001999-contrib:fix/128053, r=petrochenkov
- a70dc29 Rollup merge of rust-lang#127017 - mu001999-contrib:dead/enhance, r=pnkfelix
- 31fe962 Rollup merge of rust-lang#127107 - mu001999-contrib:dead/enhance-2, r=pnkfelix
- 2724aea Rollup merge of rust-lang#126618 - mu001999-contrib:dead/enhance, r=pnkfelix
- 977c5fd Rollup merge of rust-lang#126315 - mu001999-contrib:fix/126289, r=petrochenkov
- 13314df Rollup merge of rust-lang#125572 - mu001999-contrib:dead/enhance, r=pnkfelix
There is an additional change stacked on top, which suppresses false-negatives that were masked by this work. I believe the functions that are touched in that code are legitimately unused functions and the types are not reachable since this AnonPipe type is not publically reachable -- please correct me if I'm wrong cc @NobodyXu who added these in #rust-lang#127153.
Some of these reverts (rust-lang#126315 and rust-lang#126618) are only included because it makes the revert apply cleanly, and I think these changes were only done to fix follow-ups from the other PRs?
I apologize for the size of the PR and the churn that it has on the codebase (and for reverting @mu001999's work here), but I'm putting this PR up because I am concerned that we're making ad-hoc changes to fix bugs that are fallout of these PRs, and I'd like to see these changes reimplemented in a way that's more separable from the existing dead code pass. I am happy to review any code to reapply these changes in a more separable way.
cc @mu001999
r? @pnkfelix
Fixes rust-lang#128272 Fixes rust-lang#126169
compiler-errors added a commit to compiler-errors/rust that referenced this pull request
…nce, r=pnkfelix"
This reverts commit 2724aea, reversing changes made to d929a42.
bors added a commit to rust-lang-ci/rust that referenced this pull request
…nges, r=pnkfelix
Revert recent changes to dead code analysis
This is a revert to recent changes to dead code analysis, namely:
- efdf219 Rollup merge of rust-lang#128104 - mu001999-contrib:fix/128053, r=petrochenkov
- a70dc29 Rollup merge of rust-lang#127017 - mu001999-contrib:dead/enhance, r=pnkfelix
- 31fe962 Rollup merge of rust-lang#127107 - mu001999-contrib:dead/enhance-2, r=pnkfelix
- 2724aea Rollup merge of rust-lang#126618 - mu001999-contrib:dead/enhance, r=pnkfelix
- 977c5fd Rollup merge of rust-lang#126315 - mu001999-contrib:fix/126289, r=petrochenkov
- 13314df Rollup merge of rust-lang#125572 - mu001999-contrib:dead/enhance, r=pnkfelix
There is an additional change stacked on top, which suppresses false-negatives that were masked by this work. I believe the functions that are touched in that code are legitimately unused functions and the types are not reachable since this AnonPipe type is not publically reachable -- please correct me if I'm wrong cc @NobodyXu who added these in #rust-lang#127153.
Some of these reverts (rust-lang#126315 and rust-lang#126618) are only included because it makes the revert apply cleanly, and I think these changes were only done to fix follow-ups from the other PRs?
I apologize for the size of the PR and the churn that it has on the codebase (and for reverting @mu001999's work here), but I'm putting this PR up because I am concerned that we're making ad-hoc changes to fix bugs that are fallout of these PRs, and I'd like to see these changes reimplemented in a way that's more separable from the existing dead code pass. I am happy to review any code to reapply these changes in a more separable way.
cc @mu001999
r? @pnkfelix
Fixes rust-lang#128272 Fixes rust-lang#126169
compiler-errors added a commit to compiler-errors/rust that referenced this pull request
…nce, r=pnkfelix"
This reverts commit 2724aea, reversing changes made to d929a42.
bors added a commit to rust-lang-ci/rust that referenced this pull request
…nges-beta, r=cuviper
Revert recent changes to dead code analysis (beta flavor)
This PR cherry-picks the subset of rust-lang#128404 which actually applies to beta, namely:
- 31fe962 Rollup merge of rust-lang#127107 - mu001999-contrib:dead/enhance-2, r=pnkfelix
- 2724aea Rollup merge of rust-lang#126618 - mu001999-contrib:dead/enhance, r=pnkfelix
- 977c5fd Rollup merge of rust-lang#126315 - mu001999-contrib:fix/126289, r=petrochenkov
- 13314df Rollup merge of rust-lang#125572 - mu001999-contrib:dead/enhance, r=pnkfelix
And then re-blesses tests.
I opted to do a manual backport of that PR since preparing the revert correctly was quite a hassle.
r? @cuviper (or anyone on release)