build libcxx-version only when it doesn't exist by onur-ozkan · Pull Request #126472 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation6 Commits2 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

In #126423, it seems like c++ parsing takes quite amount of time on bootstrap startups. This PR makes libcxx-version to be compiled only when it doesn't exist.

A simple demonstration on the overhead of buiding libcxx-version:

$ rm -rf build/host/libcxx-version

$ x build Building bootstrap Finished dev profile [unoptimized] target(s) in 0.07s

----- LIBCXX VERSION CHECK TOOK: 509ms Building tool rustdoc (stage1 -> stage2, x86_64-unknown-linux-gnu) Finished release profile [optimized] target(s) in 0.25s Build completed successfully in 0:00:02

$ x build Building bootstrap Finished dev profile [unoptimized] target(s) in 0.07s

----- LIBCXX VERSION CHECK TOOK: 2ms Creating a sysroot for stage2 compiler (use rustup toolchain link 'name' build/host/stage2) Building tool rustdoc (stage1 -> stage2, x86_64-unknown-linux-gnu) Finished release profile [optimized] target(s) in 0.14s Build completed successfully in 0:00:01

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

labels

Jun 14, 2024

This comment has been minimized.

LGTM, r=me once PR CI is green.

Signed-off-by: onur-ozkan work@onurozkan.dev

Signed-off-by: onur-ozkan work@onurozkan.dev

📌 Commit e2e1afa has been approved by Kobzol

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jun 14, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jun 14, 2024

…=Kobzol

build libcxx-version only when it doesn't exist

In rust-lang#126423, it seems like c++ parsing takes quite amount of time on bootstrap startups. This PR makes libcxx-version to be compiled only when it doesn't exist.

A simple demonstration on the overhead of buiding libcxx-version:

$ rm -rf build/host/libcxx-version

$ x build
Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.07s

 ----- LIBCXX VERSION CHECK TOOK: 509ms
Building tool rustdoc (stage1 -> stage2, x86_64-unknown-linux-gnu)
    Finished `release` profile [optimized] target(s) in 0.25s
Build completed successfully in 0:00:02

$ x build
Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.07s

 ----- LIBCXX VERSION CHECK TOOK: 2ms
Creating a sysroot for stage2 compiler (use `rustup toolchain link 'name' build/host/stage2`)
Building tool rustdoc (stage1 -> stage2, x86_64-unknown-linux-gnu)
    Finished `release` profile [optimized] target(s) in 0.14s
Build completed successfully in 0:00:01

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 14, 2024

…iaskrgr

Rollup of 8 pull requests

Successful merges:

• rust-lang#125722 (Indicate in non_local_defs lint that the macro needs to change)
• rust-lang#125829 (rustc_span: Add conveniences for working with span formats)
• rust-lang#126128 (Consistently use subtyping in method resolution)
• rust-lang#126192 (Various Redox OS fixes and add i686 Redox OS target)
• rust-lang#126352 (ci: Update centos:7 to use vault repos)
• rust-lang#126354 (Use Variance glob imported variants everywhere)
• rust-lang#126469 (MIR Shl/Shr: the offset can be computed with rem_euclid)
• rust-lang#126472 (build libcxx-version only when it doesn't exist)

r? @ghost @rustbot modify labels: rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jun 14, 2024

…=Kobzol

build libcxx-version only when it doesn't exist

In rust-lang#126423, it seems like c++ parsing takes quite amount of time on bootstrap startups. This PR makes libcxx-version to be compiled only when it doesn't exist.

A simple demonstration on the overhead of buiding libcxx-version:

$ rm -rf build/host/libcxx-version

$ x build
Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.07s

 ----- LIBCXX VERSION CHECK TOOK: 509ms
Building tool rustdoc (stage1 -> stage2, x86_64-unknown-linux-gnu)
    Finished `release` profile [optimized] target(s) in 0.25s
Build completed successfully in 0:00:02

$ x build
Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.07s

 ----- LIBCXX VERSION CHECK TOOK: 2ms
Creating a sysroot for stage2 compiler (use `rustup toolchain link 'name' build/host/stage2`)
Building tool rustdoc (stage1 -> stage2, x86_64-unknown-linux-gnu)
    Finished `release` profile [optimized] target(s) in 0.14s
Build completed successfully in 0:00:01

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 14, 2024

…iaskrgr

Rollup of 8 pull requests

Successful merges:

• rust-lang#125722 (Indicate in non_local_defs lint that the macro needs to change)
• rust-lang#125829 (rustc_span: Add conveniences for working with span formats)
• rust-lang#126192 (Various Redox OS fixes and add i686 Redox OS target)
• rust-lang#126352 (ci: Update centos:7 to use vault repos)
• rust-lang#126354 (Use Variance glob imported variants everywhere)
• rust-lang#126469 (MIR Shl/Shr: the offset can be computed with rem_euclid)
• rust-lang#126472 (build libcxx-version only when it doesn't exist)
• rust-lang#126476 (Fix running bootstrap tests with a local Rust toolchain as the stage0)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 14, 2024

…iaskrgr

Rollup of 8 pull requests

Successful merges:

• rust-lang#125722 (Indicate in non_local_defs lint that the macro needs to change)
• rust-lang#125829 (rustc_span: Add conveniences for working with span formats)
• rust-lang#126192 (Various Redox OS fixes and add i686 Redox OS target)
• rust-lang#126352 (ci: Update centos:7 to use vault repos)
• rust-lang#126354 (Use Variance glob imported variants everywhere)
• rust-lang#126469 (MIR Shl/Shr: the offset can be computed with rem_euclid)
• rust-lang#126472 (build libcxx-version only when it doesn't exist)
• rust-lang#126476 (Fix running bootstrap tests with a local Rust toolchain as the stage0)

r? @ghost @rustbot modify labels: rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jun 15, 2024

…=Kobzol

build libcxx-version only when it doesn't exist

In rust-lang#126423, it seems like c++ parsing takes quite amount of time on bootstrap startups. This PR makes libcxx-version to be compiled only when it doesn't exist.

A simple demonstration on the overhead of buiding libcxx-version:

$ rm -rf build/host/libcxx-version

$ x build
Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.07s

 ----- LIBCXX VERSION CHECK TOOK: 509ms
Building tool rustdoc (stage1 -> stage2, x86_64-unknown-linux-gnu)
    Finished `release` profile [optimized] target(s) in 0.25s
Build completed successfully in 0:00:02

$ x build
Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.07s

 ----- LIBCXX VERSION CHECK TOOK: 2ms
Creating a sysroot for stage2 compiler (use `rustup toolchain link 'name' build/host/stage2`)
Building tool rustdoc (stage1 -> stage2, x86_64-unknown-linux-gnu)
    Finished `release` profile [optimized] target(s) in 0.14s
Build completed successfully in 0:00:01

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 15, 2024

…iaskrgr

Rollup of 7 pull requests

Successful merges:

• rust-lang#125722 (Indicate in non_local_defs lint that the macro needs to change)
• rust-lang#125829 (rustc_span: Add conveniences for working with span formats)
• rust-lang#126192 (Various Redox OS fixes and add i686 Redox OS target)
• rust-lang#126352 (ci: Update centos:7 to use vault repos)
• rust-lang#126354 (Use Variance glob imported variants everywhere)
• rust-lang#126469 (MIR Shl/Shr: the offset can be computed with rem_euclid)
• rust-lang#126472 (build libcxx-version only when it doesn't exist)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jun 15, 2024

…iaskrgr

Rollup of 9 pull requests

Successful merges:

• rust-lang#126354 (Use Variance glob imported variants everywhere)
• rust-lang#126367 (Point out failing never obligation for DEPENDENCY_ON_UNIT_NEVER_TYPE_FALLBACK)
• rust-lang#126469 (MIR Shl/Shr: the offset can be computed with rem_euclid)
• rust-lang#126471 (Use a consistent way to filter out bounds instead of splitting it into three places)
• rust-lang#126472 (build libcxx-version only when it doesn't exist)
• rust-lang#126497 (delegation: Fix hygiene for self)
• rust-lang#126501 (make bors ignore comments in PR template)
• rust-lang#126509 (std: suggest OnceLock over Once)
• rust-lang#126512 (Miri subtree update)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Jun 15, 2024

Rollup merge of rust-lang#126472 - onur-ozkan:improve-libcxx-build, r=Kobzol

build libcxx-version only when it doesn't exist

In rust-lang#126423, it seems like c++ parsing takes quite amount of time on bootstrap startups. This PR makes libcxx-version to be compiled only when it doesn't exist.

A simple demonstration on the overhead of buiding libcxx-version:

$ rm -rf build/host/libcxx-version

$ x build
Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.07s

 ----- LIBCXX VERSION CHECK TOOK: 509ms
Building tool rustdoc (stage1 -> stage2, x86_64-unknown-linux-gnu)
    Finished `release` profile [optimized] target(s) in 0.25s
Build completed successfully in 0:00:02

$ x build
Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.07s

 ----- LIBCXX VERSION CHECK TOOK: 2ms
Creating a sysroot for stage2 compiler (use `rustup toolchain link 'name' build/host/stage2`)
Building tool rustdoc (stage1 -> stage2, x86_64-unknown-linux-gnu)
    Finished `release` profile [optimized] target(s) in 0.14s
Build completed successfully in 0:00:01

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)