make bors ignore comments in PR template by lqd · Pull Request #126501 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation6 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Member
• Loading
As discussed here, the existing PR template is not yet ignored by bors and the html comments show up in git history.
This PR uses markers so the html comments are deleted by the bot.
r? lcnr
@bors r+
Not 100% sure this will work, but let's try it.
📌 Commit c006748 has been approved by Mark-Simulacrum
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#126354 (Use
Varianceglob imported variants everywhere) - rust-lang#126367 (Point out failing never obligation for
DEPENDENCY_ON_UNIT_NEVER_TYPE_FALLBACK) - rust-lang#126469 (MIR Shl/Shr: the offset can be computed with rem_euclid)
- rust-lang#126471 (Use a consistent way to filter out bounds instead of splitting it into three places)
- rust-lang#126472 (build
libcxx-versiononly when it doesn't exist) - rust-lang#126497 (delegation: Fix hygiene for
self) - rust-lang#126501 (make bors ignore comments in PR template)
- rust-lang#126509 (std: suggest OnceLock over Once)
- rust-lang#126512 (Miri subtree update)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
I wonder what will new contributors think of this, it might confuse them:
Maybe we should add something like "please delete the markers at the top and bottom please" xD
Why? You don’t need to remove the markers if this worked.
Yeah, it's just that it's maybe not obvious that:
- The comments will disappear in the rendered text (although that can be checked with the preview)
- The homu comments are not actually important if you modify the text (it might seem like something important that should be kept there).
I was mostly mentioning 2). But as you said, if the markers stay there, that's fine. Unless people only replace the inner comment and put text between the markers 😀
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.