On short error format, append primary span label to message by estebank · Pull Request #126804 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation17 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
The error-format=short output only displays the path, error code and main error message all in the same line. We now add the primary span label as well after the error message, to provide more context.
r? @davidtwco
rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
This comment has been minimized.
This comment has been minimized.
📌 Commit 57a82e0 has been approved by davidtwco
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…, r=davidtwco
On short error format, append primary span label to message
The error-format=short output only displays the path, error code and main error message all in the same line. We now add the primary span label as well after the error message, to provide more context.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…, r=davidtwco
On short error format, append primary span label to message
The error-format=short output only displays the path, error code and main error message all in the same line. We now add the primary span label as well after the error message, to provide more context.
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 10 pull requests
Successful merges:
- rust-lang#124460 (Show notice about "never used" of Debug for enum)
- rust-lang#125740 (transmute size check: properly account for alignment)
- rust-lang#126413 (compiletest: make the crash test error message abit more informative)
- rust-lang#126618 (Mark assoc tys live only if the corresponding trait is live)
- rust-lang#126673 (Ensure we don't accidentally succeed when we want to report an error)
- rust-lang#126804 (On short error format, append primary span label to message)
- rust-lang#126868 (not use offset when there is not ends with brace)
- rust-lang#126893 (Eliminate the distinction between PREC_POSTFIX and PREC_PAREN precedence level)
- rust-lang#126899 (Suggest inline const blocks for array initialization)
- rust-lang#126909 (add
@kobzolto bootstrap team for triagebot)
r? @ghost
@rustbot modify labels: rollup
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
📌 Commit 8b7ff89 has been approved by davidtwco
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
bors added a commit to rust-lang-ci/rust that referenced this pull request
…r=davidtwco
On short error format, append primary span label to message
The error-format=short output only displays the path, error code and main error message all in the same line. We now add the primary span label as well after the error message, to provide more context.
This comment has been minimized.
Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
The error-format=short output only displays the path, error code and
main error message all in the same line. We now add the primary span label
as well after the error message, to provide more context.
📌 Commit 1bbaf6e has been approved by davidtwco
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
This was referenced
Aug 6, 2024
Finished benchmarking commit (93ea767): comparison URL.
Overall result: no relevant changes - no action needed
@rustbot label: -perf-regression
Instruction count
This benchmark run did not return any relevant results for this metric.
Max RSS (memory usage)
Results (primary -0.0%)
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | 3.1% | [3.1%, 3.1%] | 1 |
| Regressions ❌ (secondary) | - | - | 0 |
| Improvements ✅ (primary) | -3.2% | [-3.2%, -3.2%] | 1 |
| Improvements ✅ (secondary) | - | - | 0 |
| All ❌✅ (primary) | -0.0% | [-3.2%, 3.1%] | 2 |
Cycles
This benchmark run did not return any relevant results for this metric.
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 760.794s -> 760.454s (-0.04%)
Artifact size: 336.95 MiB -> 336.90 MiB (-0.02%)
Labels
This PR was explicitly merged by bors.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.