De-duplicate all consecutive native libs regardless of their options by Urgau · Pull Request #126943 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation7 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Address #126913 (comment) by no longer de-duplicating based on the "options" but by only looking at the generated link args, as to avoid consecutive libs that originated from different native-lib with different options (like raw-dylib on Windows) but isn't relevant for --print=native-static-libs.
Area: port run-make Makefiles to rmake.rs
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.
cc @jieyouxu
bors added a commit to rust-lang-ci/rust that referenced this pull request
De-duplicate all consecutive native libs regardless of their options
Address rust-lang#126913 (comment) by no longer de-duplicating based on the "options" but by only looking at the generated link args, as to avoid consecutive libs that originated from different native-lib with different options (like raw-dylib on Windows) but isn't relevant for --print=native-static-libs.
r? @petrochenkov
try-job: x86_64-msvc
☀️ Try build successful - checks-actions
Build commit: 97a99ea (97a99ea9774afa22ae9eba3074694b8d97f6e884)
📌 Commit 604caa0 has been approved by petrochenkov
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
compiler-errors added a commit to compiler-errors/rust that referenced this pull request
De-duplicate all consecutive native libs regardless of their options
Address rust-lang#126913 (comment) by no longer de-duplicating based on the "options" but by only looking at the generated link args, as to avoid consecutive libs that originated from different native-lib with different options (like raw-dylib on Windows) but isn't relevant for --print=native-static-libs.
r? @petrochenkov
bors added a commit to rust-lang-ci/rust that referenced this pull request
…mpiler-errors
Rollup of 7 pull requests
Successful merges:
- rust-lang#126893 (Eliminate the distinction between PREC_POSTFIX and PREC_PAREN precedence level)
- rust-lang#126907 (Fixes for 32-bit SPARC on Linux)
- rust-lang#126932 (Tweak
FlatPat::newto avoid a temporarily-invalid state) - rust-lang#126934 (fix broken build cache caused by rustdoc builds)
- rust-lang#126943 (De-duplicate all consecutive native libs regardless of their options)
- rust-lang#126946 (Add missing slash in
const_eval_selectdoc comment) - rust-lang#126947 (Delegation: ast lowering refactor)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#126618 (Mark assoc tys live only if the corresponding trait is live)
- rust-lang#126746 (Deny
use<>for RPITITs) - rust-lang#126868 (not use offset when there is not ends with brace)
- rust-lang#126884 (Do not ICE when suggesting dereferencing closure arg)
- rust-lang#126893 (Eliminate the distinction between PREC_POSTFIX and PREC_PAREN precedence level)
- rust-lang#126915 (Don't suggest awaiting in closure patterns)
- rust-lang#126943 (De-duplicate all consecutive native libs regardless of their options)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#126618 (Mark assoc tys live only if the corresponding trait is live)
- rust-lang#126746 (Deny
use<>for RPITITs) - rust-lang#126868 (not use offset when there is not ends with brace)
- rust-lang#126884 (Do not ICE when suggesting dereferencing closure arg)
- rust-lang#126893 (Eliminate the distinction between PREC_POSTFIX and PREC_PAREN precedence level)
- rust-lang#126915 (Don't suggest awaiting in closure patterns)
- rust-lang#126943 (De-duplicate all consecutive native libs regardless of their options)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#126618 (Mark assoc tys live only if the corresponding trait is live)
- rust-lang#126746 (Deny
use<>for RPITITs) - rust-lang#126868 (not use offset when there is not ends with brace)
- rust-lang#126884 (Do not ICE when suggesting dereferencing closure arg)
- rust-lang#126893 (Eliminate the distinction between PREC_POSTFIX and PREC_PAREN precedence level)
- rust-lang#126915 (Don't suggest awaiting in closure patterns)
- rust-lang#126943 (De-duplicate all consecutive native libs regardless of their options)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#126943 - Urgau:dedup-all, r=petrochenkov
De-duplicate all consecutive native libs regardless of their options
Address rust-lang#126913 (comment) by no longer de-duplicating based on the "options" but by only looking at the generated link args, as to avoid consecutive libs that originated from different native-lib with different options (like raw-dylib on Windows) but isn't relevant for --print=native-static-libs.
r? @petrochenkov
Labels
Area: port run-make Makefiles to rmake.rs
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.