Add wasm32-wasip2 to build-manifest tool by alexcrichton · Pull Request #127867 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation3 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
This is an accidental omission of mine from #126967 which means that rustup target add wasm32-wasip2 isn't working on today's nightlies.
This is an accidental omission of mine from rust-lang#126967 which means that
rustup target add wasm32-wasip2 isn't working on today's nightlies.
rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
📌 Commit aebf4d0 has been approved by Mark-Simulacrum
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
bors added a commit to rust-lang-ci/rust that referenced this pull request
bors added a commit to rust-lang-ci/rust that referenced this pull request
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#127867 - alexcrichton:add-wasm32-wasip2-to-dist-manifest, r=Mark-Simulacrum
Add wasm32-wasip2 to build-manifest tool
This is an accidental omission of mine from rust-lang#126967 which means that rustup target add wasm32-wasip2 isn't working on today's nightlies.
alexcrichton added a commit to alexcrichton/rust that referenced this pull request
This is another accidental omission from rust-lang#126967 (in addition
to rust-lang#127867) which fixes an issue where wasm-component-ld isn't
distributed via rustup just yet because while it's present in the
sysroot it's not present in the tarballs.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…t-ld-for-real-this-time-maybe-let-see-after-this-merges, r=onur-ozkan
Fix inclusion of wasm-component-ld in dist artifacts
This is another accidental omission from rust-lang#126967 (in addition to rust-lang#127867) which fixes an issue where wasm-component-ld isn't distributed via rustup just yet because while it's present in the sysroot it's not present in the tarballs.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#128060 - alexcrichton:include-wasm-component-ld-for-real-this-time-maybe-let-see-after-this-merges, r=onur-ozkan
Fix inclusion of wasm-component-ld in dist artifacts
This is another accidental omission from rust-lang#126967 (in addition to rust-lang#127867) which fixes an issue where wasm-component-ld isn't distributed via rustup just yet because while it's present in the sysroot it's not present in the tarballs.
alexcrichton added a commit to alexcrichton/rust that referenced this pull request
It turns out the stars did not actually align for this to get released
in Rust 1.81 alas. Full tier 2 status for wasm32-wasip2 required two
PRs:
- rust-lang#126967 - this made it into Rust 1.81
- rust-lang#127867 - this didn't make the cut and is in Rust 1.82 instead
This wasn't caught until just after today's release so the plan is to remove the release notes for 1.81 and coordinate to instead add these as release notes to 1.82.
alexcrichton added a commit to alexcrichton/rust that referenced this pull request
It turns out the stars did not actually align for this to get released
in Rust 1.81 alas. Full tier 2 status for wasm32-wasip2 required two
PRs:
- rust-lang#126967 - this made it into Rust 1.81
- rust-lang#127867 - this didn't make the cut and is in Rust 1.82 instead
This wasn't caught until just after today's release so the plan is to remove the release notes for 1.81 and coordinate to instead add these as release notes to 1.82.
This was referenced
Sep 5, 2024
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request
…release-notes, r=pietroalbini
Remove wasm32-wasip2's tier 2 status from release notes
It turns out the stars did not actually align for this to get released in Rust 1.81 alas. Full tier 2 status for wasm32-wasip2 required two PRs:
- rust-lang#126967 - this made it into Rust 1.81
- rust-lang#127867 - this didn't make the cut and is in Rust 1.82 instead
This wasn't caught until just after today's release so the plan is to remove the release notes for 1.81 and coordinate to instead add these as release notes to 1.82.
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request
…release-notes, r=pietroalbini
Remove wasm32-wasip2's tier 2 status from release notes
It turns out the stars did not actually align for this to get released in Rust 1.81 alas. Full tier 2 status for wasm32-wasip2 required two PRs:
- rust-lang#126967 - this made it into Rust 1.81
- rust-lang#127867 - this didn't make the cut and is in Rust 1.82 instead
This wasn't caught until just after today's release so the plan is to remove the release notes for 1.81 and coordinate to instead add these as release notes to 1.82.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…release-notes, r=pietroalbini
Remove wasm32-wasip2's tier 2 status from release notes
It turns out the stars did not actually align for this to get released in Rust 1.81 alas. Full tier 2 status for wasm32-wasip2 required two PRs:
- rust-lang#126967 - this made it into Rust 1.81
- rust-lang#127867 - this didn't make the cut and is in Rust 1.82 instead
This wasn't caught until just after today's release so the plan is to remove the release notes for 1.81 and coordinate to instead add these as release notes to 1.82.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#129995 - alexcrichton:remove-wasm32-wasip2-release-notes, r=pietroalbini
Remove wasm32-wasip2's tier 2 status from release notes
It turns out the stars did not actually align for this to get released in Rust 1.81 alas. Full tier 2 status for wasm32-wasip2 required two PRs:
- rust-lang#126967 - this made it into Rust 1.81
- rust-lang#127867 - this didn't make the cut and is in Rust 1.82 instead
This wasn't caught until just after today's release so the plan is to remove the release notes for 1.81 and coordinate to instead add these as release notes to 1.82.
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.