Remove wasm32-wasip2's tier 2 status from release notes by alexcrichton · Pull Request #129995 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation3 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
It turns out the stars did not actually align for this to get released in Rust 1.81 alas. Full tier 2 status for wasm32-wasip2 required two PRs:
- Promote the wasm32-wasip2 target to Tier 2 #126967 - this made it into Rust 1.81
- Add wasm32-wasip2 to build-manifest tool #127867 - this didn't make the cut and is in Rust 1.82 instead
This wasn't caught until just after today's release so the plan is to remove the release notes for 1.81 and coordinate to instead add these as release notes to 1.82.
It turns out the stars did not actually align for this to get released
in Rust 1.81 alas. Full tier 2 status for wasm32-wasip2 required two
PRs:
- rust-lang#126967 - this made it into Rust 1.81
- rust-lang#127867 - this didn't make the cut and is in Rust 1.82 instead
This wasn't caught until just after today's release so the plan is to remove the release notes for 1.81 and coordinate to instead add these as release notes to 1.82.
rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the release subteam, which will review and decide on the PR/issue.
labels
📌 Commit a551ccc has been approved by pietroalbini
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request
…release-notes, r=pietroalbini
Remove wasm32-wasip2's tier 2 status from release notes
It turns out the stars did not actually align for this to get released in Rust 1.81 alas. Full tier 2 status for wasm32-wasip2 required two PRs:
- rust-lang#126967 - this made it into Rust 1.81
- rust-lang#127867 - this didn't make the cut and is in Rust 1.82 instead
This wasn't caught until just after today's release so the plan is to remove the release notes for 1.81 and coordinate to instead add these as release notes to 1.82.
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request
…release-notes, r=pietroalbini
Remove wasm32-wasip2's tier 2 status from release notes
It turns out the stars did not actually align for this to get released in Rust 1.81 alas. Full tier 2 status for wasm32-wasip2 required two PRs:
- rust-lang#126967 - this made it into Rust 1.81
- rust-lang#127867 - this didn't make the cut and is in Rust 1.82 instead
This wasn't caught until just after today's release so the plan is to remove the release notes for 1.81 and coordinate to instead add these as release notes to 1.82.
bors added a commit to rust-lang-ci/rust that referenced this pull request
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 6 pull requests
Successful merges:
- rust-lang#129021 (Check WF of source type's signature on fn pointer cast)
- rust-lang#129781 (Make
./x.py <cmd> compiler/<crate>aware of the crate's features) - rust-lang#129963 (Inaccurate
{Path,OsStr}::to_string_lossy()documentation) - rust-lang#129969 (Make
Ty::boxed_tyreturn anOption) - rust-lang#129995 (Remove wasm32-wasip2's tier 2 status from release notes)
- rust-lang#130013 (coverage: Count await when the Future is immediately ready )
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#129995 - alexcrichton:remove-wasm32-wasip2-release-notes, r=pietroalbini
Remove wasm32-wasip2's tier 2 status from release notes
It turns out the stars did not actually align for this to get released in Rust 1.81 alas. Full tier 2 status for wasm32-wasip2 required two PRs:
- rust-lang#126967 - this made it into Rust 1.81
- rust-lang#127867 - this didn't make the cut and is in Rust 1.82 instead
This wasn't caught until just after today's release so the plan is to remove the release notes for 1.81 and coordinate to instead add these as release notes to 1.82.
bors-ferrocene bot added a commit to ferrocene/ferrocene that referenced this pull request
1245: [1.83] Backport KP docs, release notes fix r=pietroalbini a=Hoverbear
Backports
Also backports rust-lang/rust@24906b5 which which upstream is also doing: rust-lang/rust#135934
In the case of 24906b5, this is somewhat of a special circumstance. We noticed during our own release process that our 1.81 (so 24.11) release notes had changed and this change (along with rust-lang/rust#126967 which was removed with rust-lang/rust#129995) had disappeared. We confirmed the fix for rust-lang/rust#129960 is indeed in tree, but upstream never ported the release note update to their main branch. This port is being done in rust-lang/rust#135934.
Co-authored-by: Pietro Albini pietro.albini@ferrous-systems.com
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the release subteam, which will review and decide on the PR/issue.