Migrate raw-dylib-alt-calling-convention, raw-dylib-c and redundant-libs run-make tests to rmake by Oneirical · Pull Request #128107 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation54 Commits3 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Oneirical

Part of #121876 and the associated Google Summer of Code project.

Please try:

// try-job: x86_64-msvc
// try-job: x86_64-mingw
// try-job: i686-msvc
try-job: x86_64-gnu-llvm-17
try-job: aarch64-apple

@rustbot

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-run-make

Area: port run-make Makefiles to rmake.rs

A-testsuite

Area: The testsuite used to check the correctness of rustc

S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

labels

Jul 23, 2024

@rustbot

The run-make-support library was changed

cc @jieyouxu

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

@Kobzol

@Kobzol Kobzol changed the titleMigrate raw-dylib-alt-calling-conventions, raw-dylib-c and redundant-libs run-make tests to rmake Migrate raw-dylib-alt-calling-convention, raw-dylib-c and redundant-libs run-make tests to rmake

Jul 23, 2024

@bors

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jul 23, 2024

@bors

@rust-log-analyzer

This comment has been minimized.

@bors

@bors bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jul 23, 2024

@bors

jieyouxu

//@ ignore-cross-compile
// Reason: the compiled binary is executed
//FIXME(Oneirical): msvc

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: try checking .dll.lib for import library on msvc.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-let lib_path = dynamic_lib_name(lib_name); +let lib_path = if is_msvc() { format!("{lib_name}.dll.lib") } else { dynamic_lib_name(lib_name) };

in run_make_support's c_build

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, that was misguided, I'm trying to do the check in the test itself now.

@Oneirical

Please try again. @rustbot ready

Note to self: if this works, add this comment:

    // On msvc, dynamic libraries are compiled by rustc to:
    // bar.dll     // dylib
    // bar.dll.lib // import library for the dylib
    // bar.dll.exp // export library for the dylib
    // msvc's underlying link.exe requires the import library for the dynamic library as input.
    // That is why the library is bar.dll.lib, not bar.dll.

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Jul 26, 2024

@Kobzol

@bors

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jul 26, 2024

@bors

@rust-log-analyzer

This comment has been minimized.

@bors

@bors bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jul 26, 2024

@Oneirical

Normalization added, please re-approve.
@rustbot review

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Aug 5, 2024

@jieyouxu

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 6, 2024

@bors

@bors

@jieyouxu

Note to self: needs second batch of try jobs for linux and apple

@bors

☀️ Try build successful - checks-actions
Build commit: 656a643 (656a643e49bde0bb3553459dd9b420ad9add788f)

@jieyouxu

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 6, 2024

@bors

@bors

@bors

☀️ Try build successful - checks-actions
Build commit: 91c0888 (91c088870341579fe5751ac47b28b738e5ff4a1d)

@jieyouxu

@bors r+ rollup=iffy (c libs)

@bors

📌 Commit 011727f has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Aug 6, 2024

tgross35 added a commit to tgross35/rust that referenced this pull request

Aug 7, 2024

@tgross35

tgross35 added a commit to tgross35/rust that referenced this pull request

Aug 7, 2024

@tgross35

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 7, 2024

@bors

@bors

@tgross35

@bors retry

This is in a rollup but bors snapped it up faster than me

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 7, 2024

@bors

Rollup of 7 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 7, 2024

@bors

Rollup of 7 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 7, 2024

@bors

Rollup of 7 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Aug 7, 2024

@rust-timer

Labels

A-run-make

Area: port run-make Makefiles to rmake.rs

A-testsuite

Area: The testsuite used to check the correctness of rustc

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)