Enable msvc for link-args-order by ChrisDenton · Pull Request #128647 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation8 Commits1 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

ChrisDenton

I could not see any reason in #70665 why this test needs to specifically use ld. Maybe to provide a consistent linker input line? In any case, the test does work for the MSVC linker.

try-job: i686-msvc
try-job: x86_64-msvc

@ChrisDenton

@rustbot

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

jieyouxu

Member

@jieyouxu jieyouxu left a comment • Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, r=me maybe with a few windows-msvc try-jobs.

@jieyouxu

@bors

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 4, 2024

@bors

Enable msvc for link-args-order

I could not see any reason in rust-lang#70665 why this test needs to specifically use ld. Maybe to provide a consistent linker input line? In any case, the test does work for the MSVC linker.

try-job: i686-msvc try-job: x86_64-msvc

@bors

☀️ Try build successful - checks-actions
Build commit: 0d15b41 (0d15b41ffcb49aaa9e2ce88300f9629c5b646523)

@ChrisDenton

@bors

📌 Commit 3268b2e has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Aug 4, 2024

ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request

Aug 5, 2024

@ChrisDenton

…youxu

Enable msvc for link-args-order

I could not see any reason in rust-lang#70665 why this test needs to specifically use ld. Maybe to provide a consistent linker input line? In any case, the test does work for the MSVC linker.

try-job: i686-msvc try-job: x86_64-msvc

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 5, 2024

@bors

tgross35 added a commit to tgross35/rust that referenced this pull request

Aug 5, 2024

@tgross35

…youxu

Enable msvc for link-args-order

I could not see any reason in rust-lang#70665 why this test needs to specifically use ld. Maybe to provide a consistent linker input line? In any case, the test does work for the MSVC linker.

try-job: i686-msvc try-job: x86_64-msvc

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 5, 2024

@bors

tgross35 added a commit to tgross35/rust that referenced this pull request

Aug 7, 2024

@tgross35

…youxu

Enable msvc for link-args-order

I could not see any reason in rust-lang#70665 why this test needs to specifically use ld. Maybe to provide a consistent linker input line? In any case, the test does work for the MSVC linker.

try-job: i686-msvc try-job: x86_64-msvc

tgross35 added a commit to tgross35/rust that referenced this pull request

Aug 7, 2024

@tgross35

…youxu

Enable msvc for link-args-order

I could not see any reason in rust-lang#70665 why this test needs to specifically use ld. Maybe to provide a consistent linker input line? In any case, the test does work for the MSVC linker.

try-job: i686-msvc try-job: x86_64-msvc

This was referenced

Aug 7, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 7, 2024

@bors

Rollup of 7 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 7, 2024

@bors

Rollup of 7 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 7, 2024

@bors

Rollup of 7 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Aug 7, 2024

@rust-timer

Rollup merge of rust-lang#128647 - ChrisDenton:link-args-order, r=jieyouxu

Enable msvc for link-args-order

I could not see any reason in rust-lang#70665 why this test needs to specifically use ld. Maybe to provide a consistent linker input line? In any case, the test does work for the MSVC linker.

try-job: i686-msvc try-job: x86_64-msvc

Labels

A-run-make

Area: port run-make Makefiles to rmake.rs

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.