Suggest Replacing Comma with Semicolon in Incorrect Repeat Expressions by veera-sivarajan · Pull Request #128110 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation23 Commits2 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Jul 23, 2024

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, let me post what I had pending

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

cjgillot added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Oct 27, 2024

Dylan-DPC added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Nov 4, 2024

Thanks for your patience.
@bors r+ rollup

📌 Commit 98cc345 has been approved by cjgillot

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jan 8, 2025

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jan 8, 2025

This was referenced

Jan 8, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jan 9, 2025

…iaskrgr

Rollup of 6 pull requests

Successful merges:

• rust-lang#128110 (Suggest Replacing Comma with Semicolon in Incorrect Repeat Expressions)
• rust-lang#134609 (Add new {x86_64,i686}-win7-windows-gnu targets)
• rust-lang#134875 (Implement const Destruct in old solver)
• rust-lang#135221 (Include rustc and rustdoc book in replace-version-placeholder)
• rust-lang#135231 (bootstrap: Add more comments to some of the test steps)
• rust-lang#135256 (Move mod cargo below the import statements)

Failed merges:

• rust-lang#135195 (Make lit_to_mir_constant and lit_to_const infallible)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Jan 9, 2025

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.