bootstrap: Add more comments to some of the test steps by Zalathar · Pull Request #135231 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation5 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Some of the test steps have names that don't clearly indicate what they actually do.
While there is ongoing experimental work to actually rename the steps (e.g. #135071), that's dependent on figuring out what the new names should actually be. In the meantime, we can still improve things by adding comments to help describe the steps, which will remain useful even after any renaming.
r? @clubby789
rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is very helpful 🩵
Comment on lines +1041 to +1044
| /// Runs `src/tools/tidy` and `cargo fmt --check` to detect various style |
|---|
| /// problems in the repository. |
| /// |
| /// (To run the tidy tool's internal tests, use the alias "tidyselftest" instead.) |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remark: lol
📌 Commit ceabc95 has been approved by jieyouxu
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
bootstrap: Add more comments to some of the test steps
Some of the test steps have names that don't clearly indicate what they actually do.
While there is ongoing experimental work to actually rename the steps (e.g. rust-lang#135071), that's dependent on figuring out what the new names should actually be. In the meantime, we can still improve things by adding comments to help describe the steps, which will remain useful even after any renaming.
This was referenced
Jan 8, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 6 pull requests
Successful merges:
- rust-lang#128110 (Suggest Replacing Comma with Semicolon in Incorrect Repeat Expressions)
- rust-lang#134609 (Add new
{x86_64,i686}-win7-windows-gnutargets) - rust-lang#134875 (Implement
const Destructin old solver) - rust-lang#135221 (Include rustc and rustdoc book in replace-version-placeholder)
- rust-lang#135231 (bootstrap: Add more comments to some of the test steps)
- rust-lang#135256 (Move
mod cargobelow the import statements)
Failed merges:
- rust-lang#135195 (Make
lit_to_mir_constantandlit_to_constinfallible)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#135231 - Zalathar:test-step-notes, r=jieyouxu
bootstrap: Add more comments to some of the test steps
Some of the test steps have names that don't clearly indicate what they actually do.
While there is ongoing experimental work to actually rename the steps (e.g. rust-lang#135071), that's dependent on figuring out what the new names should actually be. In the meantime, we can still improve things by adding comments to help describe the steps, which will remain useful even after any renaming.
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)